linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Michal Hocko <mhocko@kernel.org>,
	Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	Oleg Nesterov <oleg@redhat.com>,
	Vladimir Davydov <vdavydov@parallels.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Markus Trippelsdorf <markus@trippelsdorf.de>,
	Arkadiusz Miskiewicz <a.miskiewicz@gmail.com>,
	Ralf-Peter Rohbeck <Ralf-Peter.Rohbeck@quantum.com>,
	Jiri Slaby <jslaby@suse.com>, Olaf Hering <olaf@aepfle.de>,
	Joonsoo Kim <js1304@gmail.com>, linux-mm <linux-mm@kvack.org>
Subject: Re: More OOM problems
Date: Sun, 18 Sep 2016 14:18:22 -0700	[thread overview]
Message-ID: <CA+55aFx8qwCVZFa9VZTMMgzhn9qphsrOFYJVWtfHs9bAVEWhGw@mail.gmail.com> (raw)
In-Reply-To: <214a6307-3bcf-38e1-7984-48cc9f838a48@suse.cz>

On Sun, Sep 18, 2016 at 2:00 PM, Vlastimil Babka <vbabka@suse.cz> wrote:
>
> Sounds like SLUB. SLAB would use order-0 as long as things fit. I would
> hope for SLUB to fallback to order-0 (or order-1 for 8kB) instead of
> OOM, though. Guess not...

SLUB it is - and I think that's pretty much all the world these days.
SLAB is largely deprecated.

We should probably start to remove SLAB entirely, and I definitely
hope that no oom people run with it. SLUB is marked default in our
config files, and I think most distros follow that (I know Fedora
does, didn't check others).

> Well, order-3 is actually PAGE_ALLOC_COSTLY_ORDER, and costly orders
> have to be strictly larger in all the tests. So order-3 is in fact still
> considered "small", and thus it actually results in OOM instead of
> allocation failure.

Yeah, but I do think that "oom when you have 156MB free and 7GB
reclaimable, and haven't even tried swapping" counts as obviously
wrong.

I'm not saying the code should fail and return NULL either, of course.

So  PAGE_ALLOC_COSTLY_ORDER should *not* mean "oom rather than return
NULL". It really has to mean "try a _lot_ harder".

                 Linus

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2016-09-18 21:18 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-18 20:03 More OOM problems Linus Torvalds
2016-09-18 20:26 ` Lorenzo Stoakes
2016-09-18 20:58   ` Linus Torvalds
2016-09-18 21:13     ` Vlastimil Babka
2016-09-18 21:34       ` Lorenzo Stoakes
2016-09-19  8:32   ` Michal Hocko
2016-09-19  8:42     ` Lorenzo Stoakes
2016-09-19  8:53       ` Michal Hocko
2016-09-25 21:48         ` Lorenzo Stoakes
2016-09-26  7:48           ` Michal Hocko
2016-09-18 21:00 ` Vlastimil Babka
2016-09-18 21:18   ` Linus Torvalds [this message]
2016-09-19  6:27     ` Jiri Slaby
2016-09-19  7:01     ` Michal Hocko
2016-09-19  7:52       ` Michal Hocko
2016-09-19  1:07   ` Andi Kleen
     [not found]     ` <alpine.DEB.2.20.1609190836540.12121@east.gentwo.org>
2016-09-19 14:31       ` Andi Kleen
2016-09-19 14:39         ` Michal Hocko
2016-09-19 14:41         ` Vlastimil Babka
2016-09-19 18:18           ` Linus Torvalds
2016-09-19 19:57           ` Christoph Lameter
2016-09-18 22:00 ` Vlastimil Babka
2016-09-19  6:56   ` Michal Hocko
2016-09-19  6:48 ` Michal Hocko
2016-09-21  7:04 ` Raymond Jennings
2016-09-21  7:29   ` Michal Hocko
2016-09-29  6:12   ` More OOM problems (sorry fro the mail bomb) Raymond Jennings
2016-09-29  7:03     ` Vlastimil Babka
2016-09-29 20:08       ` Raymond Jennings
2016-09-29 21:20         ` Vlastimil Babka
2016-09-30 19:48           ` Raymond Jennings
     [not found] <eafb59b5-0a2b-0e28-ca79-f044470a2851@Quantum.com>
     [not found] ` <20160930214448.GB28379@dhcp22.suse.cz>
     [not found]   ` <982671bd-5733-0cd5-c15d-112648ff14c5@Quantum.com>
2016-10-11  6:44     ` More OOM problems Michal Hocko
2016-10-11  7:10       ` Vlastimil Babka
2016-10-30  4:17         ` Simon Kirby
2016-10-31 21:41           ` Vlastimil Babka
2016-10-31 21:51             ` Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+55aFx8qwCVZFa9VZTMMgzhn9qphsrOFYJVWtfHs9bAVEWhGw@mail.gmail.com \
    --to=torvalds@linux-foundation.org \
    --cc=Ralf-Peter.Rohbeck@quantum.com \
    --cc=a.miskiewicz@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=js1304@gmail.com \
    --cc=jslaby@suse.com \
    --cc=linux-mm@kvack.org \
    --cc=markus@trippelsdorf.de \
    --cc=mhocko@kernel.org \
    --cc=olaf@aepfle.de \
    --cc=oleg@redhat.com \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=vbabka@suse.cz \
    --cc=vdavydov@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).