linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mm: hide a #warning for COMPILE_TEST
@ 2018-02-16 15:25 Arnd Bergmann
  2018-02-16 17:42 ` Linus Torvalds
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-02-16 15:25 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Arnd Bergmann, stable, Michal Hocko, Kirill A. Shutemov,
	Dave Jiang, Jan Kara, Ingo Molnar, Jérôme Glisse,
	Huang Ying, Matthew Wilcox, Ross Zwisler, Hugh Dickins,
	Tobin C Harding, linux-mm, linux-kernel

We get a warning about some slow configurations in randconfig kernels:

mm/memory.c:83:2: error: #warning Unfortunate NUMA and NUMA Balancing config, growing page-frame for last_cpupid. [-Werror=cpp]

The warning is reasonable by itself, but gets in the way of
randconfig build testing, so I'm hiding it whenever CONFIG_COMPILE_TEST
is set. The warning was added in 2013 in commit 75980e97dacc ("mm: fold
page->_last_nid into page->flags where possible").

Cc: stable@vger.kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 mm/memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/memory.c b/mm/memory.c
index a728bed16c20..fc7779165dcf 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -81,7 +81,7 @@
 
 #include "internal.h"
 
-#ifdef LAST_CPUPID_NOT_IN_PAGE_FLAGS
+#if defined(LAST_CPUPID_NOT_IN_PAGE_FLAGS) && !defined(CONFIG_COMPILE_TEST)
 #warning Unfortunate NUMA and NUMA Balancing config, growing page-frame for last_cpupid.
 #endif
 
-- 
2.9.0

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mm: hide a #warning for COMPILE_TEST
  2018-02-16 15:25 [PATCH] mm: hide a #warning for COMPILE_TEST Arnd Bergmann
@ 2018-02-16 17:42 ` Linus Torvalds
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Torvalds @ 2018-02-16 17:42 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Andrew Morton, stable, Michal Hocko, Kirill A. Shutemov,
	Dave Jiang, Jan Kara, Ingo Molnar, Jérôme Glisse,
	Huang Ying, Matthew Wilcox, Ross Zwisler, Hugh Dickins,
	Tobin C Harding, linux-mm, Linux Kernel Mailing List

On Fri, Feb 16, 2018 at 7:25 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>
> The warning is reasonable by itself, but gets in the way of
> randconfig build testing, so I'm hiding it whenever CONFIG_COMPILE_TEST
> is set.

Ack, looks sane, so I just applied it directly to my tree instead of
waiting for this to get back to me from Andrew ;)

                 Linus

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-02-16 17:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-16 15:25 [PATCH] mm: hide a #warning for COMPILE_TEST Arnd Bergmann
2018-02-16 17:42 ` Linus Torvalds

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).