From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f173.google.com (mail-ig0-f173.google.com [209.85.213.173]) by kanga.kvack.org (Postfix) with ESMTP id 956826B0005 for ; Tue, 23 Feb 2016 12:46:09 -0500 (EST) Received: by mail-ig0-f173.google.com with SMTP id z8so13410138ige.0 for ; Tue, 23 Feb 2016 09:46:09 -0800 (PST) Received: from mail-io0-x22a.google.com (mail-io0-x22a.google.com. [2607:f8b0:4001:c06::22a]) by mx.google.com with ESMTPS id vs5si40285832igb.33.2016.02.23.09.46.08 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Feb 2016 09:46:08 -0800 (PST) Received: by mail-io0-x22a.google.com with SMTP id l127so220432718iof.3 for ; Tue, 23 Feb 2016 09:46:08 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20160223103221.GA1418@node.shutemov.name> References: <20160211192223.4b517057@thinkpad> <20160211190942.GA10244@node.shutemov.name> <20160211205702.24f0d17a@thinkpad> <20160212154116.GA15142@node.shutemov.name> <56BE00E7.1010303@de.ibm.com> <20160212181640.4eabb85f@thinkpad> <20160223103221.GA1418@node.shutemov.name> Date: Tue, 23 Feb 2016 09:46:08 -0800 Message-ID: Subject: Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM) From: Linus Torvalds Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" Cc: Gerald Schaefer , Christian Borntraeger , "Kirill A. Shutemov" , linux-mm , Linux Kernel Mailing List , "Aneesh Kumar K.V" , Andrew Morton , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , ppc-dev , Catalin Marinas , Will Deacon , "linux-arm-kernel@lists.infradead.org" , Martin Schwidefsky , Heiko Carstens , linux-s390 , Sebastian Ott On Tue, Feb 23, 2016 at 2:32 AM, Kirill A. Shutemov wrote: > > I still worry about pmd_present(). It looks wrong to me. I wounder if > patch below makes a difference. Let's hope that's it, but in the meantime I do want to start the discussion about what to do if it isn't. We're at rc5, and 4.5 is just a few weeks away, and so far this issue hasn't gone anywhere. So the *good* scenario is that your pmd_present() patch fixes it, and we can all take a relieved breath. But if not, what then? It looks like we have two options: (a) do a (hopefully minimal) revert. I say "hopefully minimal", but I suspect the revert is going to have to undo pretty much all of the core THP changes. I'd hate to see that, because I really liked the cleanups. (b) mark THP as "depends on !S390" in the 4.5 release The (b) option is obviously much simpler, but it's a regression. I really don't like it, even if it generally shouldn't be the kind of regression that is actually user-noticeable (apart from performance). I also hate the fact that while the problem only seems to happen on s390, we don't even understand it, so maybe it's a more generic issue that for some reason just ends up being *much* more noticeable on one odd architecture that happens to be a bit different. I'm inclined to think of (b) as just a "give us more time to figure it out" thing, but I'm also worried that it will then make people not pursue this issue. How big is a revert patch that makes THP work on s390 again? Can we do a revert that keeps the infrastructure intact and makes it easy to revisit the THP cleanups later? Or is the revert inevitably going to be all the core patches in that series? Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org