From: Linus Torvalds <torvalds@linux-foundation.org>
To: Benjamin LaHaise <bcrl@kvack.org>
Cc: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
Sasha Levin <sasha.levin@oracle.com>,
Tang Chen <tangchen@cn.fujitsu.com>,
Gu Zheng <guz.fnst@cn.fujitsu.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>,
linux-aio@kvack.org, linux-mm <linux-mm@kvack.org>
Subject: Re: git pull -- [PATCH] aio: v2 ensure access to ctx->ring_pages is correctly serialised
Date: Thu, 27 Mar 2014 14:34:08 -0700 [thread overview]
Message-ID: <CA+55aFyj2XFMkT1T=EPPw1CANt6atyFNmMaeaDm-p-NWfRNA+w@mail.gmail.com> (raw)
In-Reply-To: <20140327205749.GM17679@kvack.org>
On Thu, Mar 27, 2014 at 1:57 PM, Benjamin LaHaise <bcrl@kvack.org> wrote:
>
> *nod* -- I added that to the below variant.
You still have "goto err" for cases that have the ctx locked. Which
means that the thing gets free'd while still locked, which causes
problems for lockdep etc, so don't do it.
Do what I did: add a "err_unlock" label, and make anybody after the
mutex_lock() call it. No broken shortcuts.
Linus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-03-27 21:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 13:46 git pull -- [PATCH] aio: v2 ensure access to ctx->ring_pages is correctly serialised Benjamin LaHaise
2014-03-27 18:16 ` Linus Torvalds
2014-03-27 19:43 ` Linus Torvalds
2014-03-27 20:08 ` Benjamin LaHaise
2014-03-27 20:22 ` Linus Torvalds
2014-03-27 20:57 ` Benjamin LaHaise
2014-03-27 21:34 ` Linus Torvalds [this message]
2014-03-28 14:58 ` Benjamin LaHaise
2014-03-28 17:08 ` Linus Torvalds
2014-03-28 17:22 ` Benjamin LaHaise
2014-03-28 17:31 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+55aFyj2XFMkT1T=EPPw1CANt6atyFNmMaeaDm-p-NWfRNA+w@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=bcrl@kvack.org \
--cc=guz.fnst@cn.fujitsu.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sasha.levin@oracle.com \
--cc=stable@vger.kernel.org \
--cc=tangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).