From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx150.postini.com [74.125.245.150]) by kanga.kvack.org (Postfix) with SMTP id 0A2086B0072 for ; Thu, 25 Oct 2012 19:10:09 -0400 (EDT) Received: by mail-wg0-f45.google.com with SMTP id dq12so1459170wgb.26 for ; Thu, 25 Oct 2012 16:10:08 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1351175972.12171.14.camel@twins> References: <20121008150949.GA15130@redhat.com> <20121017040515.GA13505@redhat.com> <1351167554.23337.14.camel@twins> <1351175972.12171.14.camel@twins> From: Linus Torvalds Date: Thu, 25 Oct 2012 16:09:48 -0700 Message-ID: Subject: Re: [patch for-3.7] mm, mempolicy: fix printing stack contents in numa_maps Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Peter Zijlstra Cc: David Rientjes , Sasha Levin , Mel Gorman , Rik van Riel , Dave Jones , Andrew Morton , KOSAKI Motohiro , bhutchings@solarflare.com, Konstantin Khlebnikov , Naoya Horiguchi , Hugh Dickins , KAMEZAWA Hiroyuki , linux-kernel@vger.kernel.org, linux-mm@kvack.org On Thu, Oct 25, 2012 at 7:39 AM, Peter Zijlstra wrote: > > So I think the below should work, we hold the spinlock over both rb-tree > modification as sp free, this makes mpol_shared_policy_lookup() which > returns the policy with an incremented refcount work with just the > spinlock. > > Comments? Looks reasonable, if annoyingly complex for something that shouldn't be important enough for this. Oh well. However, please check me on this: the need for this is only for linux-next right now, correct? All the current users in my tree are ok with just the mutex, no? Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org