From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24CB5C5B543 for ; Sat, 7 Jun 2025 23:58:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 927856B0088; Sat, 7 Jun 2025 19:58:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B0C26B0089; Sat, 7 Jun 2025 19:58:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77B1A6B008A; Sat, 7 Jun 2025 19:58:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 547866B0088 for ; Sat, 7 Jun 2025 19:58:50 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id ED80D140259 for ; Sat, 7 Jun 2025 23:58:49 +0000 (UTC) X-FDA: 83530272378.26.30CAC23 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf08.hostedemail.com (Postfix) with ESMTP id 30139160002 for ; Sat, 7 Jun 2025 23:58:48 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b="LAWH/xCa"; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf08.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749340728; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SZb0yQu3bW7FIgr5rV6Gh9DpSUWQW7LKM4W2HiNGYQg=; b=VvmTK7QH5H9goU7bFZinkk8IeY20FmiCtdNqC8+Z80Up3FwLvEQidT5RWg7e2g09U9Ww8g V2KJrcl+C6AcTvkNB9QCKLEZGfQw9aIos3lqWPws+wBPXuRNM0nWEL1pN34A5AfFwXxMke u2iTU8V333bkPOzolximNcDQquFG2kw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749340728; a=rsa-sha256; cv=none; b=FOTJTiBCcQdrIIhOGyob8dKd5ygs/PIZJ5KWdUUakwdC1uz0du1ETV34qgUN7dercvc1AA e158GgpthEBAbtkcxLEuc0dBk/yqS7DBBDEf6yrspCMRFDlpHqredRP2SryaHx8+Y2jW9Z FhMTnjs1vb/R84b2JL5/hfIxfjVQjyo= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b="LAWH/xCa"; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf08.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-4a442a3a2bfso59000101cf.1 for ; Sat, 07 Jun 2025 16:58:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1749340727; x=1749945527; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=SZb0yQu3bW7FIgr5rV6Gh9DpSUWQW7LKM4W2HiNGYQg=; b=LAWH/xCaoouVvp605KLSKrSM2HSY0rBbkVWbKLVEKCj9XjKjOiFvE7CFONYrSawcET et/ThJ6qyZvxSRbHIRUMkokIDwgVxe/zYN+VZ69Vngpddo5ltR0us9+tF1U6FuEPr0zP aWWIq+JiQ1rGMeOiblD5dOTEaQq6+K3+Rpm37N6iZKZ00d1YUga1zPoP40rjmLUPb0Il bvPiR+vsRAWYVSShbjgS5tKs252fftZeVsy0C5/sVXYWr9dEQJl4lSV3fAoj0AfRn2pN L/w8+/FFZffpOIa3GO6/KmaonaI17CD1u6cc5CJFFeTgbmiWbMNyYa1g0RaFI6z3E6Ls NEgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749340727; x=1749945527; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SZb0yQu3bW7FIgr5rV6Gh9DpSUWQW7LKM4W2HiNGYQg=; b=KJEyu8teOjR3nUmqIVX5/Su9IwpiMsdXoH74JJvOtlsQNi0TH70E7In6cXYTztSIM/ FEwN5CU/0W7pTcwnWNR8Ien51uxob8Jh0aKEP9ewSQ++AgFm0LjfS0MUB2ZCTdC6EFKb ovpBLjtMVPSeUy1UnWqS0hbaxyZMkOJAVSAm5PtfDsCC3mcwTRTnppWOEMh99OC8806u bhzdyknoqV/EhQ+lp9o/I70eOjR2RMY81F27M+Xq51K4rmR9vbvQ6BUws6u0bQ1j5AP1 bHRJbF9nQOpYJ3cV719ImVmhjeyhqstby0Eu7WAbb+TnpNx96hYaZUfrUfJqK3mglMe+ RikQ== X-Forwarded-Encrypted: i=1; AJvYcCXmEdtTu5gWE8YgzZ7r/WeDxN78Gfn6X7JxcsMjzbSkdamp/oV1MbNSeut19jZ7h98wBxE+Ysyt0g==@kvack.org X-Gm-Message-State: AOJu0Yy8HxOir101+cThYSU4aeNnTPhjLKWdp0IDrRKCyarH25o6iUoC 5RCF1T7oT0ipRT8PbxqZeIBYFeC2ot4QSwS4LFSddLhJJ0seWPL89yeCO5AteKDe5lG4gZE4Rqj V/bqqF3tz60oTVv8XlLv06umjIspWM7ObGP73iLRUtg== X-Gm-Gg: ASbGnct2xiZIoYqx/phIh9BKJLWjLoTjWbh5+6NMsi6HsbRh9HoLwOAUSQTWj2eVPoV vLHvmc0i6RrCYrcm5NemxuFbgav492/GNkWBE6nef7hTWbqpM7PPBEOhuCJwBp5C8ul2pI4O1TX qvl5UfnJb4WfBIKvYGc+Jjy3X+7a3Ce4BYt55DDLc8 X-Google-Smtp-Source: AGHT+IEB97RE71KtJwLfGv6pP8Smnjv6c4dtCN8qnbdxkUOKkq++jlKJyn0l2dku3FDr9koONk+VDXarqF/XGOS6QJM= X-Received: by 2002:a05:622a:1a0e:b0:4a4:3c3e:5754 with SMTP id d75a77b69052e-4a5b9d8de25mr154274911cf.32.1749340727206; Sat, 07 Jun 2025 16:58:47 -0700 (PDT) MIME-Version: 1.0 References: <20250515182322.117840-1-pasha.tatashin@soleen.com> <20250515182322.117840-7-pasha.tatashin@soleen.com> In-Reply-To: From: Pasha Tatashin Date: Sat, 7 Jun 2025 19:58:10 -0400 X-Gm-Features: AX0GCFul3L2zzvlJ2GXtOx9lQ9B5uuJgCwhDk6D1c4MrC7_egkKEFjQyvbKOx48 Message-ID: Subject: Re: [RFC v2 06/16] luo: luo_subsystems: add subsystem registration To: David Matlack Cc: pratyush@kernel.org, jasonmiu@google.com, graf@amazon.com, changyuanl@google.com, rppt@kernel.org, rientjes@google.com, corbet@lwn.net, rdunlap@infradead.org, ilpo.jarvinen@linux.intel.com, kanie@linux.alibaba.com, ojeda@kernel.org, aliceryhl@google.com, masahiroy@kernel.org, akpm@linux-foundation.org, tj@kernel.org, yoann.congal@smile.fr, mmaurer@google.com, roman.gushchin@linux.dev, chenridong@huawei.com, axboe@kernel.dk, mark.rutland@arm.com, jannh@google.com, vincent.guittot@linaro.org, hannes@cmpxchg.org, dan.j.williams@intel.com, david@redhat.com, joel.granados@kernel.org, rostedt@goodmis.org, anna.schumaker@oracle.com, song@kernel.org, zhangguopeng@kylinos.cn, linux@weissschuh.net, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, gregkh@linuxfoundation.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, rafael@kernel.org, dakr@kernel.org, bartosz.golaszewski@linaro.org, cw00.choi@samsung.com, myungjoo.ham@samsung.com, yesanishhere@gmail.com, Jonathan.Cameron@huawei.com, quic_zijuhu@quicinc.com, aleksander.lobakin@intel.com, ira.weiny@intel.com, andriy.shevchenko@linux.intel.com, leon@kernel.org, lukas@wunner.de, bhelgaas@google.com, wagi@kernel.org, djeffery@redhat.com, stuart.w.hayes@gmail.com, ptyadav@amazon.de Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 30139160002 X-Stat-Signature: hf961xr5nu38zxcd7813nsxjbdk5ecqs X-Rspam-User: X-HE-Tag: 1749340728-560476 X-HE-Meta: U2FsdGVkX1/6ZpD3kJDze6EJq9JUGW6+kWBtBmsaKZgGxrv71bkn+D02bT69ZF8pTkupnFSCiDeWbPFr3zo0LpRSyt+8EBhVwj5uyFRo5dQUDQdJP6oddVMU6hQUw+WYbw6/9716Gunf4ZyZMkWoFtCiDzVANBN+klKLelhhqHYk61NQ0sZC5yqQtPLZtKonmqmg655MwAvZ5M70ndt5hEd2Fa2tkfrxd4LpQ47d97Itoc2P58fcr6bynnhUo0CAMB/hhllAtrq/ILUH4v/85tPcEQCHAkAJwhFukZBmhmCsaOQe8FAf0d+UKXSVrPwNqoqofZXxxbxv2+K+kHPVmDWRT6jx/JP6WYqEQHPZaVrOfEhA0x9mO2S4DPYZ6vSVlrDeov3Fut3zOjvtmlgUv5yq++DAKU/PeXEh2P4hah1dTw4PMUWP6COopZqc3xZD3R9os2Um2Vhb96JiUzv+9kxRKnuoUYXn4ezAQEjUwuZDP2+d81H98TNSkEwWC4Jc91sOOpfbHv0P9KJtvfjddB8z8E1mo2sP+q5kFZbIkAL8EoRiH1uRi1QOa4XZJOZNTODjS4q9iR7UG9sHxHhltRI/NVX8enY4XYyljvyLbluw7SOeRwPz3bST9bABeZouvZgmJCaVFOKC7L94XDGj54AEom6ins2sWztPbJPPK4+3B1dlPBfABr1/UbaayvQZUxNQ1Xli03Mrq6rQp7JKEEXYYu06Sx2k9KVMVj0LduvudxU8PByHr8D/FeEvB0XrwfjJHYSvGqDr1encjQbGwB9XH+r1knM+KnTIJ4Jd0qunXBR3PwFW0dGnOjxG7o1GV64xwgWGrqpRxS/S7aQVuRkd277he9lux3jV7yen2XWye0AG4wBkmh37VQU7BQFrdqkmNoJPqkF0NXnjppgA3c47HODt+x0X3+WHHuNMkCrpbbgDrHMwC6ug08zz/2LTzrpQceq2/MhylaWLM9q iqNmk27N w8o1hjhLzAIZtLnMB645narcrKCnOA052XZ27UcW5HCyp0SP+0QdapdQfV3oxK8wVGDfX1A5BCa/etymWDtgSdTIe1SIRZO1LqQRV8QRWJlEXEQPpSwXvzNnEubwr/AuDm0v7YS0ruZeJjuPfr5u0r6iGaAaM31COfq2Ef8b8EQIBx5iwKQhu0F2Vs0J9H8ZgJYVyw8m5ovgCj6m7KkSEkDP6rfn2lmmtNtr/iWuA9yMVNw68XC7qjcUThVHxdPGNJ3ihl8Xc+3ilIn/5dEFgUQu42hLlqdf/3yfAURK1yZ2gc7oLpoXAgN5THprXAR9kAP+01PPOBJPBxzJQNzNHVvpcRri7+5CIt9UB/AcparRBAY+doXaJNN9Tew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > Suggest using guard()() and scoped_guard() throughout this series > instead of manual lock/unlock and up/down. That will simplify the code > and reduce the chance of silly bugs where a code path misses an > unlock/down. This is an interesting suggestion. I have not really considered using guard()/scoped_guard(). I personally prefer regular lock/unlock/goto error, IMO the code is more readable this way, but I may revisit this in the future. Also, at least in mm guards are not used, i.e. `git grep scoped_guard mm` returns no results.