From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE79AC5B543 for ; Sat, 7 Jun 2025 17:11:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FD4A6B0088; Sat, 7 Jun 2025 13:11:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2AD0B6B0089; Sat, 7 Jun 2025 13:11:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C3E36B008A; Sat, 7 Jun 2025 13:11:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 00C796B0088 for ; Sat, 7 Jun 2025 13:11:54 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 12A60C25B9 for ; Sat, 7 Jun 2025 17:11:54 +0000 (UTC) X-FDA: 83529246948.13.6644B7C Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf18.hostedemail.com (Postfix) with ESMTP id 2E9651C0009 for ; Sat, 7 Jun 2025 17:11:52 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=oBzfMhag; spf=pass (imf18.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749316312; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xCjDvC5VWjJ5q6LZN7UNywkRQBZa6ThceH1qu0z8bUo=; b=obBxq/CMgF1gdkF5N5E8EsIXUF13WHC/S5plgh88VUnNu+1Wu+nB7HEBL65awBJ9Yff2BC 1v3NXXBMlhhwXiI+f6AZz3atEgIP9aHGtRhUAYk1ItRD6m4ejmhpOA8bAjzvm5RvcBBErY AePpmz0ueujd3zdtK+cMWSpjWmxq10U= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=oBzfMhag; spf=pass (imf18.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749316312; a=rsa-sha256; cv=none; b=IH7z+sh06EoqfikgIrTTpaeRjMC3OlhoOA6cT/ixD0TbUweqjb9rVQVwm6YO30XeMjEXMV eer+Rn/Trb02+/M5K7HZCg65L97v3f/9dYingZF2jSDm0YP3wVVPapUXHAsp8PY00/YsBM G2B3yqA6pTzvsK4dU0HFoz32SOkg2dE= Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-4a43e277198so24689891cf.1 for ; Sat, 07 Jun 2025 10:11:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1749316311; x=1749921111; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=xCjDvC5VWjJ5q6LZN7UNywkRQBZa6ThceH1qu0z8bUo=; b=oBzfMhagBIPXKUTFW6Sbmydf03NtGw4hHlTokGXTL0ff5t6r6hnN9OCG8kWeJDHwGX Xzoo4VjEfw+s2yrdsiG19aqNO4vKE7h9zvMYQtl1Df5Gu5yxqDETwXHmkARx1dhkbk3G +KKVPXx58hUzHUSnKZWwNIudbNxUwYCg1/B8mRCvQmXBFQLgOULt4+ZUC76noid+I+Ae kB9zFa9bNK0I/GbMvrAm5N/xL1eXRiAmMoiDlcSH01OFDWaeB0RrDg7dHKGGqxEoRSlW AHIZIBBRoaoA5Pae4MZSCHT0J+66nNmvskHL5L/n3mp6XDSgJDXnANj6ILEd/v+3JcWx OYSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749316311; x=1749921111; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xCjDvC5VWjJ5q6LZN7UNywkRQBZa6ThceH1qu0z8bUo=; b=JRmf8ZFPIVyo52F7WyWvei2NLYsasr1iMAc1huo9rRsVKnUtAtX4jtRBgoKyrWduEQ Q6Kxs0iQjjsr70sfiHh1ZzzKAwSJNTzhPUmqUQ4Q6akxvOfkr6s3VR8bnY381GQ4U8sI ypZBWzaQ8pHsWQ46CTMC5W9bpity9wgMq9avFS7gBw1iOEEjzC1WONcTZP/a67V1rbiO qlk8fo0nZ3VOan6HuIQN32+diQY3FcFizkD3EHD2+LiqfjhAF9d2KpbsMuRc4f9rn7Tw 1ttyxSyMeVfbyNMqyWZ2eNXc/g0ON9Z7zU1eP+rkfta9hW80JMMQsO5dlBOuz87pQKzP 5W0Q== X-Forwarded-Encrypted: i=1; AJvYcCX/lRPQySdAhShbEe2VDNiKtxX6VVcUn5PiaDDRzNx7qjBFzrOLRNu7SxOcjJjQDqMi3qs8hEDYMA==@kvack.org X-Gm-Message-State: AOJu0YykGn5fTHl60SrCejGx8/tcScqiltz150d43e1HJvWFxLCtMGSu L7StaZsCXEJJe9UsefmPZeYUQ1AoYV72KdlMaN5wzs4q9sfjNobuMGN3dzyFwMyFzQQeC8SZwna KESY3sXB3vWQ7cXRWZ4drMzZBMIICzX1aPl1b8UU7rw== X-Gm-Gg: ASbGnctVXHXKGyLTGzdPCJGZ4NDuSwhmFJP6eeLar4qu9/udCtpXJ/JeNw5Ug+RZJMV DD25UudhHnGjdHmPYvyub2UfMpK2iTe71O5XtMf9se5g9UxsobQ18byxpf/0sgX8oqwQ8bbThEF /bjptTBn53KEp8Vw9xAyL2UQoyKvk+AiFbynJhsE3vWZFJAhUqlts= X-Google-Smtp-Source: AGHT+IHlSewL0I2vem9w0XYHFAWl27pFyN/ynItNRVl7X1CCmIYg2bBDpzo/TCiXt0R5950IoAoIr0C9zLp8Pm4BRfk= X-Received: by 2002:ac8:7dcd:0:b0:4a6:e7a8:65b2 with SMTP id d75a77b69052e-4a6e7a866a8mr81570511cf.10.1749316311198; Sat, 07 Jun 2025 10:11:51 -0700 (PDT) MIME-Version: 1.0 References: <20250515182322.117840-1-pasha.tatashin@soleen.com> <20250515182322.117840-5-pasha.tatashin@soleen.com> In-Reply-To: From: Pasha Tatashin Date: Sat, 7 Jun 2025 13:11:14 -0400 X-Gm-Features: AX0GCFvnA9qdFD2JyIoGnpA5SZYSuxL26F_4ltSyZwRGc77_a-JtPWOeIGmCXfU Message-ID: Subject: Re: [RFC v2 04/16] luo: luo_core: Live Update Orchestrator To: Pratyush Yadav Cc: jasonmiu@google.com, graf@amazon.com, changyuanl@google.com, rppt@kernel.org, dmatlack@google.com, rientjes@google.com, corbet@lwn.net, rdunlap@infradead.org, ilpo.jarvinen@linux.intel.com, kanie@linux.alibaba.com, ojeda@kernel.org, aliceryhl@google.com, masahiroy@kernel.org, akpm@linux-foundation.org, tj@kernel.org, yoann.congal@smile.fr, mmaurer@google.com, roman.gushchin@linux.dev, chenridong@huawei.com, axboe@kernel.dk, mark.rutland@arm.com, jannh@google.com, vincent.guittot@linaro.org, hannes@cmpxchg.org, dan.j.williams@intel.com, david@redhat.com, joel.granados@kernel.org, rostedt@goodmis.org, anna.schumaker@oracle.com, song@kernel.org, zhangguopeng@kylinos.cn, linux@weissschuh.net, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, gregkh@linuxfoundation.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, rafael@kernel.org, dakr@kernel.org, bartosz.golaszewski@linaro.org, cw00.choi@samsung.com, myungjoo.ham@samsung.com, yesanishhere@gmail.com, Jonathan.Cameron@huawei.com, quic_zijuhu@quicinc.com, aleksander.lobakin@intel.com, ira.weiny@intel.com, andriy.shevchenko@linux.intel.com, leon@kernel.org, lukas@wunner.de, bhelgaas@google.com, wagi@kernel.org, djeffery@redhat.com, stuart.w.hayes@gmail.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 2E9651C0009 X-Stat-Signature: sr6dgyuk8zkzm68ybayeu7ks15og3uk9 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1749316311-594133 X-HE-Meta: U2FsdGVkX1+oMALqKoLlSB2RWeyfUSOsU98E3EaxHfJpFpipaK7zV2KZ4/v9LvNQWaXaZi/hs0+uLi69vS4jlq1HQFkRtj7iLGlneX+/40OFs84F0LbS+uwtQ625GW/iwd+T/qG6XiOthVq6P6ApV2Z31SbEIbqVNiPFecqoHSQwJ2zXBIfjqXavoR6KJD068A4gWHrMnjlOglvTh00/7NmszWTJ7BljlpFYGldgbD9ShyEm60aXWOZujMSnQ/EiuTxU9v/nHr5Jz36o0iStQZJsFG0P3sDtei6TPLS0llcd23eVlfwDn8kxAM7p29FGLjNbXMTpYWSC7I8koI3jlEvRlls0A5EMxBVaXUSpnLAKZ8uPj51TFUaR+ikrhh+YsrfB4GTCMwwELbl4aYvaBKBCLysD2UzflgTqeEB2YAsmyeVegWjRevjDEyqH7gIIqHrxjAtdUU95EKoqCzAQeTajuHNtwNN+WZX8Wd3SUktDtJhlp5kJHrMizqEpdCvDZ6evqBHR3sQU31n/Nw3wNpyPlYC0lefBujdvLf/baxGg3IUTOviJAk8Iw6Znfu2YPu9KN0MXtQu51oDP8gnUlh29jU+vXq+GKC5keIgtofcZ/nbU5iPCjtDP+fD+Ilr0XWEraa3e/qYpvXSoh1xOek80CmPp6XAyd2fA58iA+L/r14DgI4RwJNuToqDXqz1EOYVm4JamM30Vl86/J2nMaegAtxvToxUzJP54fHmW5rHdYHmylO4ixIk99g4K2N72P1tdYs5WJ1GRGCGMjKIdMoQOTnAfTwl2YQdIwp40+tcq1GdDjV/HZbdAjRzMR1+tHlRdnnLGzGnL8m05tMBXLsv9TOD8IBmZrWgvNsbEPjF8RFnymxePK1pAMUmkFB1C0T+TPpzw+JTdsr5NeYZkNu071UWL4VOW/O33B9eprcsxuQ0rWJOIICp+ZNG8i7h+4QCStuxLSXyMdFy5NtT N3m2kIXk Q1+fc80uCC27HQtNyilHoGoPZVK8KGW59WmxfIpyLhrKJN+/+DbE9VFnspK0GGi6AZmmeoK2Zhu2cPrFIeiha+qW/ktRFE+HJpvYUMbNKmrWbmSt/IUZxJz14tP2iNTe3Zdh0BF90iATZt2pHckiXphEw6kaWZf6BbmKWwymcDrfoR584rg4tlPAI+XfuyNNms718+4Wy/KhmA+4gsT6QRVsFBVNFkUYk7aCcSJhJJL4ga13U9Ou9SHLYqmPAZ3GLfU45+8wJ8JfduwXmpncGsmS3Cy3b1vJqT2H0N4zdtpvrLuYJYi1reXRBbcf2EXtoJHH/XH8y5KlJHhh4g8MUEYigi1GdZ8LWxmzibLfb5PUGK2ZGMIwvd1Jr5w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > + * Based on the outcome of the notification process: > > + * - If luo_do_freeze_calls() returns 0 (all callbacks succeeded), the state > > + * is set to %LIVEUPDATE_STATE_FROZEN using luo_set_state(), indicating > > + * readiness for the imminent kexec. > > + * - If luo_do_freeze_calls() returns a negative error code (a callback > > + * failed), the state is reverted to %LIVEUPDATE_STATE_NORMAL using > > + * luo_set_state() to cancel the live update attempt. > > Would we end up with a more robust serialization in subsystems or > filesystems if we do not allow freeze to fail? Then they would be forced > to ensure they have everything in order by the time the system goes into > prepared state, and only need to make small adjustments in the freeze > callback. > The reboot syscall is allowed to fail. Since freeze happens once we leave userspace, it is the only chance left to conduct proper verification that serialization assumptions have been maintained. For example, if, after the prepare phase, some mutations are not allowed for preserved resources (such as DMA re-mappings, etc.), the freeze phase is the only place where we can perform this verification and return an error to the user. So, while I agree it could simplify the state machine by allowing cancellation only from the prepared state, I think it is important to leave this ability for the freeze phase as well. Pasha