From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 209D8C54E67 for ; Thu, 14 Mar 2024 13:53:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 90394800A8; Thu, 14 Mar 2024 09:53:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B39180073; Thu, 14 Mar 2024 09:53:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A2D8800A8; Thu, 14 Mar 2024 09:53:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6A9BC80073 for ; Thu, 14 Mar 2024 09:53:08 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3E7211A14FD for ; Thu, 14 Mar 2024 13:53:08 +0000 (UTC) X-FDA: 81895786056.17.57B631B Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) by imf01.hostedemail.com (Postfix) with ESMTP id 72BB14001A for ; Thu, 14 Mar 2024 13:53:06 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=SwhVxe2s; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf01.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710424386; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/0LZ9JPaPO9MvJ92RSmTjppyGkKV74icycuPX6dPtYM=; b=PaR4B1is/PE5vUTXuUtcU4xklXcWmALYP0eUEIpihflYNto9K2vBnRDMVmo7vumZF9/xaR aUh5A97Z0Jqyo7pt0FmqTP/E4yR5ByvS14vGa2DkawZDsP4w7Iw2LcyMNCNugJBERePz2B kx3UyjyTwRKcfgNUrrjG7WrFR4e6U3k= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=SwhVxe2s; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf01.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710424386; a=rsa-sha256; cv=none; b=T3uGtVol/yAWEzf1Pe67RKWjiJGPEeSHMxxnYvmJ49wVOLXAVjMFGhQbAbN65DvoTjeHRn KvaKACnxxXLUKD9Z6DJ1kvPjOwyKj4KP2gBHJFlNZ6jja+iaZD4stQEIUqTvpaPfVjhucj Cema/sqxj3rd/Wbiwc4XtFfXpvhR5Gk= Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-609408d4b31so10408087b3.0 for ; Thu, 14 Mar 2024 06:53:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1710424385; x=1711029185; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/0LZ9JPaPO9MvJ92RSmTjppyGkKV74icycuPX6dPtYM=; b=SwhVxe2srxdXEVjSxqzmahOJjVKbT9p3O6j3nu8NsnWCDLVqiNAoJLMEo/4nMJWK2x B9ZJynqhUpwsoweUIW+JwHoHMA30bE6zsRoUp8V8KgxA821ZjZfl2C3s1/L4Lb66ZVdZ OA0rTCq18wno54JxmUrvIan4DzN+UM5bhNqpszcpsE+E/OXzHCKxrNSNo2HzTV5r09Am qurZfaVvcHvn4te0+ORdJNA7IMeQe/9WqKbxHbKNdCm46D67GGx8t0ECB50P7tBJ96Hq yBmGiRi4JyqqSq6N6XVrqeWR6X/YY8ecpeShb5D8u0cUVsXTxNp9vaqCP6QmIUPhCfk5 ifAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710424385; x=1711029185; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/0LZ9JPaPO9MvJ92RSmTjppyGkKV74icycuPX6dPtYM=; b=f8+1nFFge7szqWMvbEkKMD+nqbCOOSH7cnxfdr2dEjyn4Wh0sxm74T0rRukjWRjoaU ya9oKELoNwKZfpKHTt3sDmGwmgrMq4KuRaLDelaGUxVSHOwn0GhiwuZclPC9MMySoLpO wxj98CD+3dO5mXcWK6C1kxenFb1UkIYIdyW4vvRoKWhQxChCzT3QtqXtg0WCSE7EkP/6 ysyRg4cOiP5HMSNlVTY4BU6Hpaxf7taINXUjiaTJQflscPEoAeCs/E3c3BWZ8zYPgSgA kkcpmrLrTxG6jNkbNMg453bFfWbcISjQ9M/A+M5rU3ldPISY7HSq+9CKtK1U3/7T6CDV YQQg== X-Forwarded-Encrypted: i=1; AJvYcCU5MQVFe538YcnOgR7aZqwuL8Vo0oIJ3nOVduMPbg3L+Jf537uUUqTX696KzUCUfcpgbJQvr4peM4WE+I724lV0ApU= X-Gm-Message-State: AOJu0Yw98fu75dXqlVB/QPD1ul6K+pJnhmekYbCcKH8/OoZ5UnsjskhG w0dltl5/Qg+K7EL/vbk8PaQygwvalk0X3V0ovcj6rXkOQJUTEoAvxctc7rQui2rSPWgtjhasViX e8tAgn1oT8vidxq/lzW2HmJps//D+iHceEMDDkw== X-Google-Smtp-Source: AGHT+IE8FrfuS9Wh8W8HqQpkZWATt/l2PywIiLHJSDvG8y5Wb8/Xq75KW08PYGCynXNtvQpY5TzVN3kJU7yqPeErXOo= X-Received: by 2002:a81:5208:0:b0:609:f7cc:4bb7 with SMTP id g8-20020a815208000000b00609f7cc4bb7mr788909ywb.46.1710424385457; Thu, 14 Mar 2024 06:53:05 -0700 (PDT) MIME-Version: 1.0 References: <20240311164638.2015063-1-pasha.tatashin@soleen.com> <20240311164638.2015063-7-pasha.tatashin@soleen.com> <6f351959-4711-4a21-8c46-94e536d2eff8@csgroup.eu> In-Reply-To: <6f351959-4711-4a21-8c46-94e536d2eff8@csgroup.eu> From: Pasha Tatashin Date: Thu, 14 Mar 2024 09:52:29 -0400 Message-ID: Subject: Re: [RFC 06/14] fork: zero vmap stack using clear_page() instead of memset() To: Christophe Leroy Cc: Nikolay Borisov , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "akpm@linux-foundation.org" , "x86@kernel.org" , "bp@alien8.de" , "brauner@kernel.org" , "bristot@redhat.com" , "bsegall@google.com" , "dave.hansen@linux.intel.com" , "dianders@chromium.org" , "dietmar.eggemann@arm.com" , "eric.devolder@oracle.com" , "hca@linux.ibm.com" , "hch@infradead.org" , "hpa@zytor.com" , "jacob.jun.pan@linux.intel.com" , "jgg@ziepe.ca" , "jpoimboe@kernel.org" , "jroedel@suse.de" , "juri.lelli@redhat.com" , "kent.overstreet@linux.dev" , "kinseyho@google.com" , "kirill.shutemov@linux.intel.com" , "lstoakes@gmail.com" , "luto@kernel.org" , "mgorman@suse.de" , "mic@digikod.net" , "michael.christie@oracle.com" , "mingo@redhat.com" , "mjguzik@gmail.com" , "mst@redhat.com" , "npiggin@gmail.com" , "peterz@infradead.org" , "pmladek@suse.com" , "rick.p.edgecombe@intel.com" , "rostedt@goodmis.org" , "surenb@google.com" , "tglx@linutronix.de" , "urezki@gmail.com" , "vincent.guittot@linaro.org" , "vschneid@redhat.com" Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 72BB14001A X-Stat-Signature: 6ro55ouy9qgpe5ec4p5wo5pmnb7hdicu X-HE-Tag: 1710424386-732230 X-HE-Meta: U2FsdGVkX1+aOshxtYDZm064r5+ND8t1Q+f9T3+BDQ4l1lS3EzY3OTisJqHYVuRY2f142JUrFnMSvoBjUqOyxyKKyRazFUE3+aBts22fXObzErWDa5lCnbNApl0TewXXsV9y8ojNgX3YNWOutd1TdnVMaEfqMwo4bUYNKPk0e5/HxJRghz9mgI//iSu9D+p+nwMGJHrYFS8sITx6EHnlYStd9LtKulOeMTFP97DOgm/zdaNu7I+ljOTXryQT+C+owGAuPXeizfwTecXvM00pgw9kDIk689SilYaqpErdYuwvBiIkBfdSMrRMJu2Vat9+3oysqdyJGA2ruwvWUCRrsXy/GdIpxcmB16eLClNT0ME+8BvAHVIsj9B9r6y/lNShbi06hsYB0tV2DgiIo93QiMOcszr1aNPyVZ2bVsIG5bIPRgbuctd19nVb1ZTdfV7tlBbeOmE3L4trgaNl9w5hp2maPCiJpmbEd/Y5lrgzloJbk5mu49CpZNoqbGEX+XTb4NEDPvUhzbZc/9BxlbKi4RiO69wbgLPftr5Ru0DByAqzWKsU4Rt59uVxO8Cj7G4aVKEuDdDktvfsa4evcOCb1BUftU0c8JmhAn6OGVqogLJqtenQr2ZcqaHwoJZoR0CFTQ8+eFupNvUbMvDxPLG/8DszgnSDPtAh7UcLYICteXA8BMYUh2FNIxMhITJ7WwwuDr5FneswRSkjTh13rf1UKtNSlreOyJNxwaYY+PBJIIF/duhNnK/AJdIWTGZ1gjVfJnecmoeodWAimBq1I6iP2uSS89U7zASjwKL19qSb24WmDJAbk5vF9okRUW0OfO4S+i6LGM9jUfx83UBtwJErgSx9I1/pCia5DybTtYyKI9lABE/11OHdC6ELLZomIuuJv9StZ/9hB51d/mLN/7waA7wQZCsRzLKRPPb3IByAeq0Y/JHj2lnMJj4+M7NoVRjvcX2VOyXAviAxilz3NMl L9+OrJRi 5b40PKTl9sINh75oZQJYXrI6A5UCpGeNSmZ81wzQphzbYhnhdiknicC6mXMuFATqLUhsf7pzGq9g8VmaTaCGpQvsWNez1MST3Wefc/S7TE0QylaYZh9tmb3lrracLjcAGjKrWd/By00q4/mk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000012, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > But the pages were already physically discontiguous before your change, > what's the difference ? Pages were not physically contiguous before my change. They were allocated with __vmalloc_node_range() which allocates sparse pages and maps them to a virtually contiguous span of memory within [VMALLOC_START, VMALLOC_END) range. > It doesn't matter that the pages are physically discontiguous as far as > they are virtually contiguous, which should still be the case here for a > stack. This patch is a preparation patch for the "dynamic kernel stack" feature, in the description it says: This is because with dynamic stacks we might have only partially populated stacks. We could compute the populated part of the stack, and determine its start and end mapped VA range by using vm_area->pages[] and vm_area->nr_pages, but that would make code a little uglier especially becuase we would need to take into the account if stack is growing up or down.. Therefore, using clear_page() is simpler and should be fast enough. Thanks, Pasha