From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23B74C54E60 for ; Sun, 17 Mar 2024 15:16:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D3286B0092; Sun, 17 Mar 2024 11:16:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 95A716B0093; Sun, 17 Mar 2024 11:16:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D47D6B0095; Sun, 17 Mar 2024 11:16:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 64E9D6B0092 for ; Sun, 17 Mar 2024 11:16:09 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3599C120804 for ; Sun, 17 Mar 2024 15:16:09 +0000 (UTC) X-FDA: 81906881658.07.88BEDF7 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by imf05.hostedemail.com (Postfix) with ESMTP id 3014B10001F for ; Sun, 17 Mar 2024 15:16:07 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=aMlLvjpB; spf=pass (imf05.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710688567; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A/SLJTPrYdvSiWiNqrR3D72kmqik90U4Q+5rpGyYCw0=; b=dVXQiClWbJzL/ggBenxZrJdnL3B/+cI3fwOCvo5JtatBg5Ml6h6F//Gsu4DePMVyaJlcAm Mq7GgA6CtkQknpXYxAFHgSRl+JcLRfoLRHFz9e/6Dln+geVv+s8l70nZ97zP9zzJBFu4QA MNqeblAXdoM6WqdGJJpRs0q1HhCsgYA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710688567; a=rsa-sha256; cv=none; b=2U0elyPbHXDqTLTu841B6ndj6cacGZvykHxKwsag+Q7vFFXHfgOZDqL/q0TXpfoP+UQ/vh dNnXfG6rF3vDdFFQR75XrWsOcV3ufTdA0ptN8HwbmI7Ml9cqaUXo5pNug7ttoAZy5N3KV9 Uke15dpARV9XhcJsl8KzpbdjMcW9BMM= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=aMlLvjpB; spf=pass (imf05.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.172 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-430baec7bb5so11008251cf.0 for ; Sun, 17 Mar 2024 08:16:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1710688566; x=1711293366; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=A/SLJTPrYdvSiWiNqrR3D72kmqik90U4Q+5rpGyYCw0=; b=aMlLvjpB3540yF8lFX/kvs4AQ0qAeNPLfNuYQbU468DggVw7qSow3WQxLPPEwobZKz 2b5ITwbixFc3Y2FI22nISUKC+ln/1tdIWi4RDtirL8P8f12X0bjP3lTR8bswCSZ1zVpp yxlLEXqfQKII1YjYYHwFq4a6wv6WwXRwVbMEgtBnjvsA0WkV+fJKCKtpYASQAZHaH+GB BqoqcylLmzgXDkDlpLPJVdHbbNpaN3DOuhwcj98dPZHXVoPoSA1EDzuh0dqX91b4xqFN RYyvv+KsjE9DtURcqkMX4JQ3F6S3ohjy7w+RP2wLjA6H9ogpCw8ge1NR0cZ067AJwH/D lFHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710688566; x=1711293366; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A/SLJTPrYdvSiWiNqrR3D72kmqik90U4Q+5rpGyYCw0=; b=LDfwdf/lxNMVgnCfcxs6hlnUbqkNOpvc1wXTDln4UEfL7n+mUy6ooB+Qk0h83GXr49 TAafAuriymZmYkn8niH3wnqj2JBIX8fB/Dt57l7n67E9JUL8dsVJV68dEPWE2zNeeE57 +eHZDfhPuqzn3lpWtMFkAyt+pyw2LAybLmVvhzhiM+bS7RXnw7kmMQljbJshB4wG4V/L DCsO+qwXK14ov20sX3EDke0+sbBZi1+MEsb0OTxYTxeUAHDhhC2Y5mzzjrGy6a9JPzzU rotRTTPE9T1cG26xIImMLUpiQqwNYwN4Ewwrg3vB5sxRRraXWawPqFN8tGLD5AB62L13 kX6w== X-Forwarded-Encrypted: i=1; AJvYcCX91CcziNQBH+sqM3y+SHNjNRqils8kexDcoMWNFBHOvVxeCw+VfOsCjWnNz4RhXdGtQtE4xlfm1xgtYKboUMRgWGo= X-Gm-Message-State: AOJu0YzQegYrSDHyYcWILIkU8e6F/3UHFDkbJuRci/EJc4weGiVoVfYJ gyWX58uKWD1d39QR5fbFsyOL79WE0w9kTm403NSPX7BFwyDxlRXxH6kLaj6jL5didXqzBjVNzI6 9ViiNL4Ftt+gmJaFx7SCWWmUMZq629L6FuSR3mw== X-Google-Smtp-Source: AGHT+IFyMnpiLXfaKDgSZc8JDytGevRilFiWhY+KM0uCrVLml93IBlU+ayqqnkbK9D40N3mi9WfLuogGFdgae/8Py/I= X-Received: by 2002:ac8:7e95:0:b0:430:bb91:2ae9 with SMTP id w21-20020ac87e95000000b00430bb912ae9mr6676290qtj.14.1710688566343; Sun, 17 Mar 2024 08:16:06 -0700 (PDT) MIME-Version: 1.0 References: <20240311164638.2015063-1-pasha.tatashin@soleen.com> <20240311164638.2015063-9-pasha.tatashin@soleen.com> <5b98c4a1-26c0-4b69-b000-44ae97eb6edb@wanadoo.fr> In-Reply-To: <5b98c4a1-26c0-4b69-b000-44ae97eb6edb@wanadoo.fr> From: Pasha Tatashin Date: Sun, 17 Mar 2024 11:15:30 -0400 Message-ID: Subject: Re: [RFC 08/14] fork: separate vmap stack alloction and free calls To: Christophe JAILLET Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, x86@kernel.org, bp@alien8.de, brauner@kernel.org, bristot@redhat.com, bsegall@google.com, dave.hansen@linux.intel.com, dianders@chromium.org, dietmar.eggemann@arm.com, eric.devolder@oracle.com, hca@linux.ibm.com, hch@infradead.org, hpa@zytor.com, jacob.jun.pan@linux.intel.com, jgg@ziepe.ca, jpoimboe@kernel.org, jroedel@suse.de, juri.lelli@redhat.com, kent.overstreet@linux.dev, kinseyho@google.com, kirill.shutemov@linux.intel.com, lstoakes@gmail.com, luto@kernel.org, mgorman@suse.de, mic@digikod.net, michael.christie@oracle.com, mingo@redhat.com, mjguzik@gmail.com, mst@redhat.com, npiggin@gmail.com, peterz@infradead.org, pmladek@suse.com, rick.p.edgecombe@intel.com, rostedt@goodmis.org, surenb@google.com, tglx@linutronix.de, urezki@gmail.com, vincent.guittot@linaro.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 3014B10001F X-Rspam-User: X-Stat-Signature: arbioqmatbnrprwb76j37jhc99k7sets X-Rspamd-Server: rspam03 X-HE-Tag: 1710688567-862175 X-HE-Meta: U2FsdGVkX19TUWDsRohTJhQUjbeZq1btdn2bsu/AayYJFI7ICpMswDfg4Mkgjrabx0LezmdTgy3qQyULsY1J2RNO7O9xzaLMDVK6gHoCQ2AhbQisVWK5M/g3sCaucJoID/JuFYhHrMGgvd4qSsB9dqkiRJzZ806YIWFOUwrO9uEM28q2hR5HCXOUw4AgAwR9Mgvg8hPTDccqa6Zg3/cmitl5oETH9L/i4ugPV5Xi9Kwv2DBCYkbNH+j0Absu8TAa+Ns9IA++wtKnY/Ji//8eaXrvqstPJEA9ra0m36qcCZLOfeoq5H+QdrlN4TicrkHO1CT8fXrDQfiDR23P4EP0SuiEdW+JLrQEfbdU77t8Efq7nhTl3zMMeFA79LuKwWG2RBP8SXFcunnhK8lRkZHxxHxcIeC8TVdEJgApn3Lc21NkRZuc9PugB76VuIBDeSgTQxGw+AVp0kbPj3uwkiiRsikult0b9ifsCZJLk8R1j9U2QfU+BPfTRa0OQoi8/s0PJekXHvr26dPySRuxNqcVbl7T6tfFn9BRLtVOrvnGqagt+ugSM8OYWyhHNUBi9H+rWbp4ky45DN47UskYumU08kp5+E9MypAssAFt5g0DjWsAzbTFUzOIm3wlFL8ao1VP2hR1gvByRAbFB33B9b0owmQtfH9ZIujnzbAFId1yxJ+4jEr1aV7foVcXYEbL82ynbB1UwN7gTnMCBRcA9Nqgj9+IIDPPWPHcjByfgUMGP+LedbAfm2l6bOQ52XSdNCJio+eUq6B//HV9qMlt4nwqeqClZpJEkdn1nRf7NGXEqRzfhRkIzHVMPd+fadqdHAX9kKwQFLyIz3pVKsPaPCmg/cGC64xpdip2IeJMOIHeTyflRAJMHQ7wjEagLb8JW8+h83VrzTCf+rAo4IG77OgA3w3aLhYB4nHCNG0dUrOiEIU5Y91pRMLVJLPTLYXpLTl9C4ZrbctDu6KACKIvIYA x79CfXEt EyanrOlvpWKNYddDiPUeDT+MpM3CGSJSdMf0tgzG/bE5N6/6CH+TiwxWAY3pY1I/9Ob9AP458j5iUJzEXIuUMKOElkXim5l9kPnD57+7MzX0hVE03FW7a3lOSzkUGeyqQp+Q9jDXQgxVHfN5ZZaFu0YYqITryNGylSh8E/Uokc2Ism+4QtqQl7zLI/6XvA79dYLxhhZvCcnllc8Qq1xnZqcpN7i7cl8AKUKzbHiMJFre82YvUCI6DTcpuyorSSiwSt0IeTJXQMWn9LPUQfFOX1i0Snwylp0StWLFJ0/JkETDYxnNMOSBA0mDtFmk4rGajyIg4untOVnPlptiFUmvScMa8SoT4EP2Ee0dq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Mar 17, 2024 at 10:52=E2=80=AFAM Christophe JAILLET wrote: > > Le 11/03/2024 =C3=A0 17:46, Pasha Tatashin a =C3=A9crit : > > In preparation for the dynamic stacks, separate out the > > __vmalloc_node_range and vfree calls from the vmap based stack > > allocations. The dynamic stacks will use their own variants of these > > functions. > > > > Signed-off-by: Pasha Tatashin > > --- > > kernel/fork.c | 53 ++++++++++++++++++++++++++++++--------------------= - > > 1 file changed, 31 insertions(+), 22 deletions(-) > > > > diff --git a/kernel/fork.c b/kernel/fork.c > > index 3004e6ce6c65..bbae5f705773 100644 > > --- a/kernel/fork.c > > +++ b/kernel/fork.c > > @@ -204,6 +204,29 @@ static bool try_release_thread_stack_to_cache(stru= ct vm_struct *vm_area) > > return false; > > } > > > > +static inline struct vm_struct *alloc_vmap_stack(int node) > > +{ > > + void *stack; > > + > > + /* > > + * Allocated stacks are cached and later reused by new threads, > > + * so memcg accounting is performed manually on assigning/releasi= ng > > + * stacks to tasks. Drop __GFP_ACCOUNT. > > + */ > > + stack =3D __vmalloc_node_range(THREAD_SIZE, THREAD_ALIGN, > > + VMALLOC_START, VMALLOC_END, > > + THREADINFO_GFP & ~__GFP_ACCOUNT, > > + PAGE_KERNEL, > > + 0, node, __builtin_return_address(0)= ); > > + > > + return (stack) ? find_vm_area(stack) : NULL; > > Nit: superfluous () Thank you. > > > +} > > ... >