From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BDC2C35FFC for ; Tue, 25 Mar 2025 14:05:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09E33280039; Tue, 25 Mar 2025 10:05:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 024C928000C; Tue, 25 Mar 2025 10:05:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE1FB280039; Tue, 25 Mar 2025 10:05:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BC92528000C for ; Tue, 25 Mar 2025 10:05:02 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C4A151A0592 for ; Tue, 25 Mar 2025 14:05:02 +0000 (UTC) X-FDA: 83260244844.04.A5C43F3 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf14.hostedemail.com (Postfix) with ESMTP id B203910002B for ; Tue, 25 Mar 2025 14:05:00 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=hOPx8lUM; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf14.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742911500; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KKMJVcSSYFhFkaF9OI9BOHOle5JxWrFZ54yuemRi3B0=; b=HC2aiU8+BlwiFsQ7kYIQeFIxrZ2zsdRS1DnT7EcjaY30D2NGwsLKIshwZnFZabGbV5akWL LIGJmY0SyRG2uYE7gf5YEdkJ7m8FSZf3bIAGMgW9rME5NT+fH4Mt0j1cR2q2uZtRv9pjKy sZolLxphDfd60rnt/dufCsrN0Mm6e+E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742911500; a=rsa-sha256; cv=none; b=BkwS1QxxxAAPTo6seLejQvQJWJ7uf8oHrGDq/jpDJRcu2rugtF+Vxejci7SF5GtzTs93Fh SGpKocvTS62UxrRN+1ylBXKE/Z/7RCmmsdFIjAu5Wfva1j+PFK9UbeIM3Z1ZiQ6GWJemSV t5S1LlZIG3fOw4OSe1IEFV+NQ+Ci7yU= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=hOPx8lUM; dmarc=pass (policy=none) header.from=soleen.com; spf=pass (imf14.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-4766631a6a4so56501011cf.2 for ; Tue, 25 Mar 2025 07:05:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1742911500; x=1743516300; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KKMJVcSSYFhFkaF9OI9BOHOle5JxWrFZ54yuemRi3B0=; b=hOPx8lUM/jzbTqjW27Q2t36XW8E+1ju0uNMmqs/ELvdUKlnvZ7Cv/7Z4Gr4qZDCN3B HW3pHQ04EH+thNl8USeivzkjMdy4APXx6OV7jHiqRxU75IQZPFvy5YB8iAcHOAD4xQe3 oYIv3okaA4EUyKw+vd9L9NFCzZgKxnAeInUYm8p5FrHTGQNDV8aRdBBwb6X48gPf43n7 HFUmyAVEYuNlv+5NlUQfwvd70DAo+OCukBIzyLpRDySl/FcLMOHkUU8v/3S/EjmqFxmf lyS0Nv/RnSZbakARUZnYHU5fPdGoeDnjjms/HqvfmgqWGNB3xkvINDrglLyurKIBeBjg 981A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742911500; x=1743516300; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KKMJVcSSYFhFkaF9OI9BOHOle5JxWrFZ54yuemRi3B0=; b=cHZUmbaHWEosb4dVg3BSvc0j5e1nP1g3pe05igd2R+oIjMr2y9vtbW40+SpZpiXc0g /Zyt2psv98jYXVfWEmu+A9i5so0UV9/5MlNmUxiZJP7/TPOUS3MWOSs7xTa5Q+jZMV4+ Nle/StviV3No4/pK0dSC53z/jTtynm/iw426sJCmAWsqPxK2gIi2i1+0PHlX2vtl9kyh HRgZNglRwWdASTVqP8a2toPMwulacpZ3AhFyuB4CBKdx5br1mwUMgcKzBlf4iUjsqxd/ YpZ9qlcE3k4/dyQ5O08eMhJV2mJ++1yqPFbzsVeSeYlXQap5uGEepMeidSJf5F9ZWcnD ss+A== X-Forwarded-Encrypted: i=1; AJvYcCVKpZcJZWaxXl4oQIj/q27A/NkbeK8Lrm/J08CONJZTMS5MHEB6mB29Vlz6vxB5gPc8PVyxsczTyQ==@kvack.org X-Gm-Message-State: AOJu0YwNr+7bgSYy6kZufAYXsLQd9cVOt65XtRY55mUPNpdtP3blt770 lpTRBDxnT1py6ARv/BI3UgYN9nG+qXFlV+ipy1EF4anDToZTJoLXwFirTrLLEWa7SEoFwPFM5Gr 5+zt8GzgLZrqxWNxIOd68POzKb+RHB6BAKQ0Cow== X-Gm-Gg: ASbGnctSZ6x/eiy0yRacTpdIqQ/rk6IAH4DABe70iawIqWeqbnfhlFBrkAlu1yBEN/0 hiyVDqd0SaBvHCVuWZ300412YnBebJZhQdHt11ZTvEP5RNpBLLh8RicvU/f3p7OPA8qtKMflRrU Q/dgXTP20xWbxcOML7Xrf/ONZR X-Google-Smtp-Source: AGHT+IGMYVQtiX/h+EVJlPHZz5Rq/az3V8wIPVjd4SZUiiPGocRCmY6VSmvm0irS2U8qQcxFKzIzc2oRCd6fuO2LGmc= X-Received: by 2002:a05:622a:248e:b0:476:b56d:eb46 with SMTP id d75a77b69052e-4771dd77d25mr264001271cf.15.1742911499617; Tue, 25 Mar 2025 07:04:59 -0700 (PDT) MIME-Version: 1.0 References: <20250320015551.2157511-1-changyuanl@google.com> <20250320015551.2157511-12-changyuanl@google.com> In-Reply-To: From: Pasha Tatashin Date: Tue, 25 Mar 2025 10:04:21 -0400 X-Gm-Features: AQ5f1Jrjo6HkojvC1uIVMuAy34VVl7CYnqSMt1jjfTIiYkTHpp9oYG_kKxOqyPA Message-ID: Subject: Re: [PATCH v5 11/16] kexec: add config option for KHO To: Baoquan He Cc: Dave Young , Changyuan Lyu , linux-kernel@vger.kernel.org, graf@amazon.com, akpm@linux-foundation.org, luto@kernel.org, anthony.yznaga@oracle.com, arnd@arndb.de, ashish.kalra@amd.com, benh@kernel.crashing.org, bp@alien8.de, catalin.marinas@arm.com, dave.hansen@linux.intel.com, dwmw2@infradead.org, ebiederm@xmission.com, mingo@redhat.com, jgowans@amazon.com, corbet@lwn.net, krzk@kernel.org, rppt@kernel.org, mark.rutland@arm.com, pbonzini@redhat.com, hpa@zytor.com, peterz@infradead.org, ptyadav@amazon.de, robh+dt@kernel.org, robh@kernel.org, saravanak@google.com, skinsburskii@linux.microsoft.com, rostedt@goodmis.org, tglx@linutronix.de, thomas.lendacky@amd.com, usama.arif@bytedance.com, will@kernel.org, devicetree@vger.kernel.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B203910002B X-Stat-Signature: ts7h8zswunh4wx5wmt6qbzcxbkxd37qp X-Rspam-User: X-HE-Tag: 1742911500-856627 X-HE-Meta: U2FsdGVkX1+StVe3m9xLAO0RHJzEk3LiaB36oGOmv4N0XJJvjFZ60auSVABXhnnV6CWRk52pAA+QeQzECDPp1orcD4g7HU4/3xoRWnsL50fVP0QXdLTqcPe5xteILQyEGEQCU+lp01mqq6O3vya+PWJJZ/PXDl9OHThu6Bsc/n3FYaALvQGAYN3QixvS15RkG6qQ2iLBBnNlz28Ls3zL+X8ohEl75xHvwp0yiHR5ric65wBRCdiHEI9emZf/HEnWv50fuQSlkVolDjVgkow9FO0XlQ44hHc+EgmrEWogYZLWgPzuEArNO91XrGnd2kufJV5nopR9NaWQFbR5pnyIO/y3cvXmJN25r9f8xcX58dlzFNaOFhpLlYAnPzBq6t1YJOOhz8RJrOKoImVfXUxa+tYd/EtZFD40e3jyCECe1ZUPXSwuIVN+83Sz27LiZATyZfmeH69gTFY7UM05tVwYv2K1pHepuUSq7VZjQObmSIRNKOk31zSepeeEQh/5gXNQnXbjuawik4kDoCgxLJX6W3LBfbaN4YzMKwWY4nyPBGzT54vb42oCiEuHdSdJIWqirMrF8YnY/VrlohCcpgi8hrW0hLlxVIOG9JwKjfbhXdDoviaQk+fQqYnt/LtWzKa97oITnJTfN+7ZMzmeZKQ489orVibOavfk6/19Fb57wmW1zbbMy/A3czCzVnAemPzenEWKe6Z3mAMORBCsOmTNUgEXT/bd7acCrjgtbTflIp7vUxLaLQeBhlsfcKcqkxGhrsRDAphL70HhGKFHgpVLpVVLoyroKLM1aEqm6scC4hYwtPMoPJAYDCihljmIWqzyfBcXVpAhNa/xZocA5NqS0JbU1lwBYibXYzSzcgcMOvUkk7H0pzJABdZaeCWdg89b5qdbpSZFrCJBP4nY/YO6HXLmWmq6DR0irRNl5x0ReO2IOXFxrWCjBLDU56pUMeE7BJEzlUptnI4vzdZ8Ose P7SjGuyG k3TbDxEXvctWfBNV9WVg0PUQ125mxO2CC/+uDTntPL1m8Aj61NM1seNDbMxB7vA3l+KmKadiUAgq95mHYln1I53XS8yn5UdQN5nOmyMnM9Q2wgh3K7BziNG4a++8PpJMnWIwGFUaNpdjzJzZV6Xs5rriwxTHP4NgEdGLfrdPlOF7S7b9AqmMXwD4tpRGTf5+XrvJ49uXtnVTI6/v/IX484Aa0hV5Q46E1iZrpsuzsLmnyKpPYSyORSrPViw+TC/w+9qlvW5q5uP/SJYNZNQkSAStOqfG0xpl0rGC5ml4qz/lAV0GM2F7mlX4PqnxmgLtdiopiW8Cg70tkL/jxW27wigWVF2vPF0+DIflq2NFBSK4lwqVBTsz/KkVl9ZR04uo22UYOq1IBjnut+75upJ/qmf8Ai8/af88DO5np X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 25, 2025 at 2:58=E2=80=AFAM Baoquan He wrote: > > On 03/24/25 at 12:18pm, Dave Young wrote: > > On Thu, 20 Mar 2025 at 23:05, Changyuan Lyu wro= te: > > > > > > From: Alexander Graf > > > > > > We have all generic code in place now to support Kexec with KHO. This > > > patch adds a config option that depends on architecture support to > > > enable KHO support. > > > > > > Signed-off-by: Alexander Graf > > > Co-developed-by: Mike Rapoport (Microsoft) > > > Signed-off-by: Mike Rapoport (Microsoft) > > > Co-developed-by: Changyuan Lyu > > > Signed-off-by: Changyuan Lyu > > > --- > > > kernel/Kconfig.kexec | 15 +++++++++++++++ > > > 1 file changed, 15 insertions(+) > > > > > > diff --git a/kernel/Kconfig.kexec b/kernel/Kconfig.kexec > > > index 4d111f871951..57db99e758a8 100644 > > > --- a/kernel/Kconfig.kexec > > > +++ b/kernel/Kconfig.kexec > > > @@ -95,6 +95,21 @@ config KEXEC_JUMP > > > Jump between original kernel and kexeced kernel and invoke > > > code in physical address mode via KEXEC > > > > > > +config KEXEC_HANDOVER > > > + bool "kexec handover" > > > + depends on ARCH_SUPPORTS_KEXEC_HANDOVER && ARCH_SUPPORTS_KEXE= C_FILE > > > + select MEMBLOCK_KHO_SCRATCH > > > + select KEXEC_FILE > > > + select DEBUG_FS > > > + select LIBFDT > > > + select CMA > > > + select XXHASH > > > + help > > > + Allow kexec to hand over state across kernels by generating= and > > > + passing additional metadata to the target kernel. This is u= seful > > > + to keep data or state alive across the kexec. For this to w= ork, > > > + both source and target kernels need to have this option ena= bled. > > > + > > > > Have you tested kdump? In my mind there are two issues, one is with > > CMA enabled, it could cause kdump crashkernel memory reservation > > failures more often due to the fragmented low memory. Secondly, in > > kho scracth memorys are reserved much later than crashkernel, we may not > need to worry about it. > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > start_kernel() > ...... > -->setup_arch(&command_line); > -->arch_reserve_crashkernel(); > ...... > -->mm_core_init(); > -->kho_memory_init(); > > > kdump kernel dump the crazy scratch memory in vmcore is not very > > meaningful. Otherwise I suspect this is not tested under kdump. If > > so please disable this option for kdump. > > Yeah, it's not meaningful to dump out scratch memorys into vmcore. We > may need to dig them out from eflcorehdr. While it's an optimization, > kho scratch is not big relative to the entire system memory. It can be > done in later stage. My personal opinion. But, we don't; we only dump out the regular CMA memory that absolutely should be part of vmcore. When scratch is used during boot, it is used for regular early boot kernel allocations, such as to allocate memmap, which is an essential part of the crash dump. Pasha