From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B49CAC54E60 for ; Thu, 14 Mar 2024 17:15:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48AD6800CF; Thu, 14 Mar 2024 13:15:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43B24800B4; Thu, 14 Mar 2024 13:15:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 30468800CF; Thu, 14 Mar 2024 13:15:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1EF61800B4 for ; Thu, 14 Mar 2024 13:15:37 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AECF5120930 for ; Thu, 14 Mar 2024 17:15:36 +0000 (UTC) X-FDA: 81896296272.02.77EC607 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) by imf09.hostedemail.com (Postfix) with ESMTP id B115A140009 for ; Thu, 14 Mar 2024 17:15:34 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=J55lnhnV; spf=pass (imf09.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.222.169 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710436534; a=rsa-sha256; cv=none; b=Fl48Pl5EVaGtU076VEchaDGkysXCxAm6D0+K5jGYxWmOGmnlkXEqe358aFzSU8Ea9+OzNp YLBb1oATyBMEk5BJqoKiy/GQBW4qWiX6dPDaM6ptQmuCzQ5sZGdwAdvsZ2SxMToUzb+Q2j VyRoHf+NtaRU/EWkGZYxnlCAhnR5nHg= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=J55lnhnV; spf=pass (imf09.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.222.169 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710436534; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9B4CXRFsjej7KTIynVIuz7r6GJvXz0ei6DUmelRAZHg=; b=G8eBK2NVxVzjSPU9Hkhgy5RBD21RKejSWgCNlghrWXGeOLasHvsvSi8SkT7xYAukR1SNg8 bSveI96Omdb80439FUpYBLoVjROtO6GYNqs//2x/z1X4uLHECadUVmClyWJJgjubhTpc5z +tzR9lsk388RgTDL1nN+miYHsKXNqcw= Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-78908fd7bb4so58526485a.3 for ; Thu, 14 Mar 2024 10:15:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1710436534; x=1711041334; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=9B4CXRFsjej7KTIynVIuz7r6GJvXz0ei6DUmelRAZHg=; b=J55lnhnVS0HjZsfJvUKPLOIm7eb7mNCx3/5yJHM+UGpYh5iyTpptWjpN+8GG6C9cIv A+mQ/5DxDRCmLzqUnn3ehiisTiALLzhR5JrqvF/qfGVLYPptFU3fc60y3Hnr2z4KoOPk Vphg1Y6GxQ/JH3dR8Bz2vzxCCfbJo0wUwVLYop8o647n94SEV5iQGSusa+hLku/7APZb 1gQr8ZeSk55P084Fg/Ns6m8KaQ0gIn32CvlZJtgGhFd4QjGuiU4ZiN30XyfNrq8OCnxW hU6vd6ICeEU8mFK3R3hAxi4avuqjYNvvcLfiLqvDGSEbjtdqt60ncxKAxWeuT1E+rjos ApfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710436534; x=1711041334; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9B4CXRFsjej7KTIynVIuz7r6GJvXz0ei6DUmelRAZHg=; b=oEgmDMELkIu59OwWLqWLNPdg6t211wR7HtjHToSbm24eD8clDqhO5th/PIiozu2Aug czhjs8tAJ57TdNQlZN3BaNSU/h+LmOP+DHguxJkzSOjJrd+0Ckr/vfUByPmkwR89ziJZ OkwGFxYMJxdz5PpFmtawaDHN/pTilGqE0/O9c3PX5tdZZ7+EUAkm/7uY6xdUZwPw6CSe fuvHGRRYwOpmUwzjXQUlf0xImWCitopFXlW4WcM5d6iZ2k8x5f5jcs1G97LoFlvH9Kzx Y0g9YraT6ZEirZBxGUVnl4h82Hh1DTMlxxW26QQ1itN+wzSDD98+8580D6Olq1f5wkof 3/zA== X-Forwarded-Encrypted: i=1; AJvYcCVz98pw+/5GULXnIm+6fBRNDXwy0oaNm/ZsndBoy2PxJQERiUT4xHSh9F1APPuVaLaiEkCg/ihv+xDhu9y+Tp9lA9A= X-Gm-Message-State: AOJu0YwUJUI4jFzDZ/2wI4DVd57cM2Me+XZcRhcfuV/7/SGqG/6PzFPW WEIi7vO34x1qIizzkExNDZZpx9MgDbLUG/+s2Od9L0MkYeX6yCeDfnXOkOYESFZPl7b/Wn/9wPE Dl7aW2HsfLK3OB+vAVTNOdThGAkVMC99L50dm/w== X-Google-Smtp-Source: AGHT+IFcsQ5Nlg5NEiqBm3DwbkibUkhYMw9DyW8AcuUZ2SO3yMvSThREoaam/CVmQhCQlWZCaZqK8GR5uh9TcgEMS+I= X-Received: by 2002:ac8:5a0b:0:b0:42f:3093:b4bf with SMTP id n11-20020ac85a0b000000b0042f3093b4bfmr2576867qta.37.1710436533416; Thu, 14 Mar 2024 10:15:33 -0700 (PDT) MIME-Version: 1.0 References: <20240311164638.2015063-1-pasha.tatashin@soleen.com> <20240311164638.2015063-9-pasha.tatashin@soleen.com> In-Reply-To: From: Pasha Tatashin Date: Thu, 14 Mar 2024 13:14:56 -0400 Message-ID: Subject: Re: [RFC 08/14] fork: separate vmap stack alloction and free calls To: Jeff Xie Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, x86@kernel.org, bp@alien8.de, brauner@kernel.org, bristot@redhat.com, bsegall@google.com, dave.hansen@linux.intel.com, dianders@chromium.org, dietmar.eggemann@arm.com, eric.devolder@oracle.com, hca@linux.ibm.com, hch@infradead.org, hpa@zytor.com, jacob.jun.pan@linux.intel.com, jgg@ziepe.ca, jpoimboe@kernel.org, jroedel@suse.de, juri.lelli@redhat.com, kent.overstreet@linux.dev, kinseyho@google.com, kirill.shutemov@linux.intel.com, lstoakes@gmail.com, luto@kernel.org, mgorman@suse.de, mic@digikod.net, michael.christie@oracle.com, mingo@redhat.com, mjguzik@gmail.com, mst@redhat.com, npiggin@gmail.com, peterz@infradead.org, pmladek@suse.com, rick.p.edgecombe@intel.com, rostedt@goodmis.org, surenb@google.com, tglx@linutronix.de, urezki@gmail.com, vincent.guittot@linaro.org, vschneid@redhat.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B115A140009 X-Stat-Signature: id1s9n8p5pnye86cziq8br57pfwksr4d X-Rspam-User: X-HE-Tag: 1710436534-339657 X-HE-Meta: U2FsdGVkX18OgdB2TF8EemZB9Y71wXAWeMgeloCS1f9wahVwG04rZJe5MRrCKOY3FGYpxuMjLLvxaM3uEwc4iaUnp3W2UpWCnZ5q6MQdOMXdi0mxkWe7WBK8BCBKGWN/5wrpUMxTx+fe/I03VkS5curGSnSzZrNI8ETHeHlD8qdhXYF8SDf7Ll5TrTNpWBjmY2r9qockOti0gmMkBSXVGIwfoQjodliDgng0ry4DldgneUHzyTuPKp9te7dV9uNZsMVLe3A4VLmTtkMNhyQfODGvcnedV8yRCPVaJUVOM2gTD5oqa5BQeg65JyIhd64qtlVlJlIJIDOw0oQm/B+AbcKTlMftnOC3i161nXVhjghuuSsSURN+bJlwZAn3Uvvu3dt4OxaiBw+EdZE8bMtfGi7Uax14WXC7JtyNH0Yd6djwHPgdSCyM0D0qL4i7HDfTT+fL2WDeRWJjwHi4zEht6aEYlIgQj37cOPeSdG8SX6VBeJPVutkP/zf9tWs0kUAGCbPoUK6+9jkxkQ/N5CfyqJLcTtLBb4zDtjFlL8zqDdbCoDIMHyOOce3E10ziAhNcwDvLwfsYjePD/ejFQsi9MUE1LM/JdhuuZ71A7xIRBJU/B6MryS+PBc1KPf4m5td2Ta6FMikPjHMkzogxWh56D8hSnpUITPzwtACDMWoga4nHgwidxs4iRbm5uwa6c8jt9oN8sq8WlNP4DGqpkKJF0Y3RC3pKjSHzsDWWQAt4p2Rp0BZSqCdwepIjvZ9s+Wr4vuma1DlpQpZjvetjhBxvjLD7u81u6ODsaRclnY9MvZW2sxzupKCWTw1W3GIfTRvPbBZ0L8thhUbFY43r9lu4gFXsBT98QERVo1MOy27O09g5qlWMYFfWmuzlT3ckDpDBd+dGdc6PsDkkW5yzaZVm/qu9xYg6qccjAkEyXU6SulOI2uIGy4SF4+Tb3Vu3WG4uwkklr/ZKr7wUqTCMW07 cGedk4JS gYBGJypxTlT1o9uDdDeKewVgSMV0f26mj4b03ZrC3acpkp14AR7AEU3Lg7tPwn00sb6ZDoMuG7ydk11qtCSVvkwfq8bFOxX2TU2FDq2Rm4GSqRWZGITmRGi1kU6VDNU4JH+KgwMBTZwnWH0MiAGhJRn+WEw+2F6vQAIzFLtPXkOv7lLQ8avKssVXo5PMSQ/W65i9O/sM2BNnEupDdIF3PtjaWooAFYo9d9ZBg8aZgqt+vwOWdIOHj+BTtV09PRI4/ekoFsL/aHTAaM1JbI8CFyoL3Uzl3mXdw+L7/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > I've discovered that the function free_vmap_stack() can trigger a warning. > It appears that free_vmap_stack() should handle interrupt context and > task context separately as vfree(). Hi Jeff, Thank you for reporting this. Yes, it appears free_vmap_stack() may get called from the interrupt context, and yet we call remove_vm_area() that takes locks. I will fix it in the next version similar to the way you suggested by adding an in_interrupt() case. Thank you, Pasha > [root@JeffXie ]# poweroff > [root@JeffXie ]# umount: devtmpfs busy - remounted read-only > [ 93.036872] EXT4-fs (vda): re-mounted > 2e1f057b-471f-4c08-a7b8-611457b221f2 ro. Quota mode: none. > The system is going down NOW! > Sent SIGTERM to all processes > Sent SIGKILL to all processes > Requesting system poweroff > [ 94.043540] ------------[ cut here ]------------ > [ 94.043977] WARNING: CPU: 0 PID: 0 at kernel/smp.c:786 > smp_call_function_many_cond+0x4e5/0x550 > [ 94.044744] Modules linked in: > [ 94.045024] CPU: 0 PID: 0 Comm: swapper/0 Not tainted > 6.8.0-00014-g82270db6e1f0 #91 > [ 94.045697] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), > BIOS 1.15.0-1 04/01/2014 > [ 94.046399] RIP: 0010:smp_call_function_many_cond+0x4e5/0x550 > [ 94.046914] Code: 48 8b 78 08 48 c7 c1 a0 84 16 81 4c 89 f6 e8 22 > 11 f6 ff 65 ff 0d 23 38 ec 7e 0f 85 a1 fc ff ff 0f 1f 44 00 00 e9 97 > fc ff ff <0f> 0b e9 61 > [ 94.048509] RSP: 0018:ffffc90000003e48 EFLAGS: 00010206 > [ 94.048965] RAX: ffffffff82cb3fd0 RBX: ffff88811862cbc0 RCX: 0000000000000003 > [ 94.049598] RDX: 0000000000000100 RSI: 0000000000000000 RDI: 0000000000000000 > [ 94.050226] RBP: ffff8881052c5090 R08: 0000000000000000 R09: 0000000000000001 > [ 94.050861] R10: ffffffff82a060c0 R11: 0000000000008847 R12: ffff888102eb3500 > [ 94.051480] R13: ffff88811862b800 R14: ffff88811862cc38 R15: 0000000000000000 > [ 94.052109] FS: 0000000000000000(0000) GS:ffff888118600000(0000) > knlGS:0000000000000000 > [ 94.052812] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 94.053318] CR2: 00000000004759e0 CR3: 0000000002a2e000 CR4: 0000000000750ef0 > [ 94.053955] PKRU: 55555554 > [ 94.054203] Call Trace: > [ 94.054433] > [ 94.054632] ? __warn+0x84/0x140 > [ 94.054925] ? smp_call_function_many_cond+0x4e5/0x550 > [ 94.055362] ? report_bug+0x199/0x1b0 > [ 94.055697] ? handle_bug+0x3c/0x70 > [ 94.056010] ? exc_invalid_op+0x18/0x70 > [ 94.056350] ? asm_exc_invalid_op+0x1a/0x20 > [ 94.056728] ? smp_call_function_many_cond+0x4e5/0x550 > [ 94.057179] ? __pfx_do_kernel_range_flush+0x10/0x10 > [ 94.057622] on_each_cpu_cond_mask+0x24/0x40 > [ 94.057999] flush_tlb_kernel_range+0x98/0xb0 > [ 94.058390] free_unmap_vmap_area+0x2d/0x40 > [ 94.058768] remove_vm_area+0x3a/0x70 > [ 94.059094] free_vmap_stack+0x15/0x60 > [ 94.059427] rcu_core+0x2bf/0x980 > [ 94.059735] ? rcu_core+0x244/0x980 > [ 94.060046] ? kvm_clock_get_cycles+0x18/0x30 > [ 94.060431] __do_softirq+0xc2/0x292 > [ 94.060760] irq_exit_rcu+0x6a/0x90 > [ 94.061074] sysvec_apic_timer_interrupt+0x6e/0x90 > [ 94.061507] > [ 94.061704] > [ 94.061903] asm_sysvec_apic_timer_interrupt+0x1a/0x20 > [ 94.062367] RIP: 0010:default_idle+0xf/0x20 > [ 94.062746] Code: 4c 01 c7 4c 29 c2 e9 72 ff ff ff 90 90 90 90 90 > 90 90 90 90 90 90 90 90 90 90 90 f3 0f 1e fa eb 07 0f 00 2d 33 b4 2a > 00 fb f4 c3 cc c0 > [ 94.064342] RSP: 0018:ffffffff82a03e70 EFLAGS: 00000212 > [ 94.064805] RAX: ffff888118628608 RBX: ffffffff82a0c980 RCX: 0000000000000000 > [ 94.065429] RDX: 4000000000000000 RSI: ffffffff82725be8 RDI: 000000000000a14c > [ 94.066066] RBP: 0000000000000000 R08: 000000000000a14c R09: 0000000000000001 > [ 94.066705] R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 > [ 94.067311] R13: 0000000000000000 R14: ffffffff82a0c030 R15: 00000000000000ac > [ 94.067936] default_idle_call+0x2c/0xd0 > [ 94.068284] do_idle+0x1ce/0x210 > [ 94.068584] cpu_startup_entry+0x2a/0x30 > [ 94.068931] rest_init+0xc5/0xd0 > [ 94.069224] arch_call_rest_init+0xe/0x30 > [ 94.069597] start_kernel+0x58e/0x8d0 > [ 94.069929] x86_64_start_reservations+0x18/0x30 > [ 94.070353] x86_64_start_kernel+0xc6/0xe0 > [ 94.070725] secondary_startup_64_no_verify+0x16d/0x17b > [ 94.071189] > [ 94.071392] ---[ end trace 0000000000000000 ]--- > [ 95.040718] e1000e: EEE TX LPI TIMER: 00000000 > [ 95.055005] ACPI: PM: Preparing to enter system sleep state S5 > [ 95.055619] reboot: Power down > > > ./scripts/faddr2line ./vmlinux smp_call_function_many_cond+0x4e5/0x550 > smp_call_function_many_cond+0x4e5/0x550: > smp_call_function_many_cond at kernel/smp.c:786 (discriminator 1) > > 756 static void smp_call_function_many_cond(const struct cpumask *mask, > 757 smp_call_func_t func, void *info, > 758 unsigned int scf_flags, > 759 smp_cond_func_t cond_func) > [...] > 781 * When @wait we can deadlock when we interrupt between > llist_add() and > 782 * arch_send_call_function_ipi*(); when !@wait we can > deadlock due to > 783 * csd_lock() on because the interrupt context uses the same csd > 784 * storage. > 785 */ > 786 WARN_ON_ONCE(!in_task()); > // <<< warning here > [...] > > > > -- > Thanks, > JeffXie