From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B75A5C04FF9 for ; Tue, 16 Apr 2024 15:21:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44E896B0095; Tue, 16 Apr 2024 11:21:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FE7A6B0096; Tue, 16 Apr 2024 11:21:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29FD16B0098; Tue, 16 Apr 2024 11:21:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0ACC16B0095 for ; Tue, 16 Apr 2024 11:21:32 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C1A891A0ABD for ; Tue, 16 Apr 2024 15:21:31 +0000 (UTC) X-FDA: 82015759182.13.E5C588D Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) by imf15.hostedemail.com (Postfix) with ESMTP id 02DFCA0013 for ; Tue, 16 Apr 2024 15:21:28 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=PYCFyfA6; spf=pass (imf15.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.167.178 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713280889; a=rsa-sha256; cv=none; b=glTKB6FKNdKkUyl6rl6YOZ10DRCF6K0F0yq0EB+A/0N58iP9a5rxJ+Y9+SsWdfvh7vIsvo u/i9pzXpsvzB4n+F3UizIMJ2xvAIAbs5KjOhBYxG6EOpPfH2/CAiM0FKFedMR/zkFhP088 +xHO8bQpvpSePCqFPNx1YIJBxG1i0iQ= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=soleen-com.20230601.gappssmtp.com header.s=20230601 header.b=PYCFyfA6; spf=pass (imf15.hostedemail.com: domain of pasha.tatashin@soleen.com designates 209.85.167.178 as permitted sender) smtp.mailfrom=pasha.tatashin@soleen.com; dmarc=pass (policy=none) header.from=soleen.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713280889; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=exledq5bMAia+aXMZpT405bPUyxwjZwz2jrsj3ug3iU=; b=crFlzaUYw2A9pb2tfmBvGTG1xq1jEwznJUayYyaUrmHILq9Q4ykS8qjepu4Go+z7WfbxpU 4hNRxE1sIF2x+c4gec1OJB01ZxQM8Y3Pie++fDBNJzej/2NL4ce1q4iIRmd1uyRKKlztMz 85nhiAUS5JI3EqcmKHwr1y2d9KSo8P4= Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-3c7299c06b8so116109b6e.3 for ; Tue, 16 Apr 2024 08:21:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1713280888; x=1713885688; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=exledq5bMAia+aXMZpT405bPUyxwjZwz2jrsj3ug3iU=; b=PYCFyfA6KvPrfNJ2nHD1z27Yy4tokdjX6bH0WU4x1rT+fVvGJuy5pde2szC3dwvaDy NrjzgGe4y2xvNJlOSiYILtR9yd1/o6V7q4b2XjcizIdiAQ9gth90XI8HbIRKtXdL376n AX5lMVkR2R+nV84rFho8MFoY3nIcyumMc4BtwbKlLvdouU9g5Fx7QshIICOCk5soL4yK v0KEGP7S8JM/gMRSY3ieLJvcqJZwEPBt1XYatf+F5nHxzyNT62zn96P8kj0kIE6f0MmN oPei7oPCyMEY74n8Aje3B8Mt8VOvMrssPzzfmi2/klHnY9BlDhIYwxtMLCUiYfF9XC8x I2Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713280888; x=1713885688; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=exledq5bMAia+aXMZpT405bPUyxwjZwz2jrsj3ug3iU=; b=J9znVOaUQpNEKAnq14glMxVDh52UCHj+VAabOi6QcV4ZgwOQcB3Jjzd2yBdtaV8gBi PnHmdRs+AScmhL6VbfTMSYhSsZgzUamAeESctjwlxfNRJ15lB998JBA7L0+mAy6RgNlz f9YYS6YyPSFiIMVEB9yR5syZGh+QoGl+O4KxJ4xvsvYtJCw/dGNROTm/gU7lPw9LHzsi l7Q849dQh9YV52PYdyNc0Mj1C4e/qJ5p6uXzHIRPJX153K6t09U2UHXypx7mWwIjnC9e 1r4KqzDD7w29Qz6Ps8Hh5XoFssFvubzpBLpfgpTC2wYjh/BgSxNNUjPhkGkJDSgz0CvM 2U6Q== X-Forwarded-Encrypted: i=1; AJvYcCXP7qDrMhtCZpEHE2j1c+cEU8N+etc0hXiuyq6+UYEHmqF8koOCCko1J0aoqk5sO9DyXnPMobajFPOj/yxfZVuoBGY= X-Gm-Message-State: AOJu0YxnjuBeR2JE5ke+9Hqzuim7SP+gSpO/mREN7vnra8L9EHcqpU3r mS9EFgg8V2R4jQrqmM89p5Q3pQ3s/69XiLXb8qLeQ6T9iNfj8GT4Edyc2TRhifv3JwTWDbjEAgZ MC98W5kp4yk3JuiNOP4EhjGVk0gGxvz5QLS4X3IruqSye+0pFGCA= X-Google-Smtp-Source: AGHT+IEzIDbt1nv61jBn1hxVgQUgKLj9IptmcEGg280bncRezKEdmUANI7RRW6ggZhu/f/pXAfQEYDULv3yUDKUOg3g= X-Received: by 2002:a05:6808:114e:b0:3c6:641:819e with SMTP id u14-20020a056808114e00b003c60641819emr16759446oiu.54.1713280888012; Tue, 16 Apr 2024 08:21:28 -0700 (PDT) MIME-Version: 1.0 References: <20240416012559.4536-1-richard.weiyang@gmail.com> In-Reply-To: <20240416012559.4536-1-richard.weiyang@gmail.com> From: Pasha Tatashin Date: Tue, 16 Apr 2024 11:20:51 -0400 Message-ID: Subject: Re: [PATCH] mm/sparse: guard the size of mem_section is power of 2 To: Wei Yang Cc: rppt@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, Pavel Tatashin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 02DFCA0013 X-Stat-Signature: xj1otfjd9ymqqx99cpi13njqhpi8emik X-Rspam-User: X-HE-Tag: 1713280888-935762 X-HE-Meta: U2FsdGVkX19u6Gn4PauLFlfeEf5Q2UjAy4dtF9lyoTLXpQ35IVMnD8wiDY/ZTSy3Ph2eEV4BlXRFOdiMTAu5ddUgl6oORPtzUbwTxg4zF2OyXSbfsrrgXLxe0vwg7ea7OCujvRxtdYH7SU0KxW+r7R4rhmtVW9Ii1bfGMBg2c42e5bWR99rlXpu/T6dA+EHLVHpaFynYWFyw2KIGrkn6hG9MKCPxv6254VGj4zbPN/Pv7KpTdfGf8g9yTc29B3HXirFWYQP5p5cxW4iR4qv85bRjTxanuhIH6YVcC18+O4nX06M0j4bg6rWYcfqs5QD7iVCk3Y+A5NCDJ2aLhte1V5GoTtTOwI/cJecH4gqShnmOdpSReeDLmitqhOQbo7nLtNIrRkbVo7y2egmPvdThVu26+30MEr8VNCH+Zy1DV6uuH7IIucdPq4l6HOkDpL38z0L/3NnI0s1jbyYwfDRPnUt6DhhFyO1XpQ5N8SDp3y0s2UNTZl/4BhMzh3LkdSRAXIKXc215Bog/qwPd8WkfEFimIBL73D34BoNcvGkkr7lVkgJuD2SyovDYbcbR98IGt7+CoTqDVTBTnhfsSpAjDyzIP2bCSCEf/OSpDGuIbvTNi/viSXaQzn7iW66wUWdWl6fUeEadO+0ooMMxqvk0+q9+ISYN56F60lTQKrWchJXpBXdUuObQwbcK6PVKXVSjoXBxwQ4p2L69eijhkFkT+iZKj8/ljkACpd5N1TonsldqLIQb2O5MEbsc534RxCHSaDX5nktHAjSi2/mIX5pGypeQ3qyQkeQeyXCq01CkhilZUiZX5e4/+O7b7mYe+RWWEhnCD5ygC8UK45meeveaw+HNKFDugv0+GH6p04+7msyQZRHNUA4u8TT62cs4Oj5xTXPb1vZDwo2uw3fiVSO9YoYFkBcuRmBrCefhyUoz9lwlx6cBhSjZFsbm8loNRvRtld7ngZVNr599mP+6+MX vf/FF7Dh Hl/qtaTXhb3/kwgRvPjQYI5wMA24pPKtgPnbniimiwNxa130vJS32Yeq0kSxBRnXXMnvpuyL4dhGwLTz+GuJc8cSQm/6NNi9Vlsj0+kl/biRBM7zrD8wS6G2jNHeAA0XvcxLgLf14IytdSUPAUPSrxwaXEvh7PG1aky4h9RbI8a+Tw0k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000019, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 15, 2024 at 9:26=E2=80=AFPM Wei Yang wrote: > > We usually have this check, while commit 2a3cb8baef71 ("mm/sparse: > delete old sparse_init and enable new one") missed to take it. > > Signed-off-by: Wei Yang > CC: Pavel Tatashin > --- > mm/sparse.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/sparse.c b/mm/sparse.c > index aed0951b87fa..a7d92fe7be19 100644 > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -560,6 +560,8 @@ void __init sparse_init(void) > unsigned long pnum_end, pnum_begin, map_count =3D 1; > int nid_begin; > > + /* see include/linux/mmzone.h 'struct mem_section' definition */ > + BUILD_BUG_ON(!is_power_of_2(sizeof(struct mem_section))); Reviewed-by: Pasha Tatashin Thanks, Pasha