From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CF92C5B559 for ; Wed, 4 Jun 2025 12:32:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 965CE6B05A6; Wed, 4 Jun 2025 08:32:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93D6B6B05AC; Wed, 4 Jun 2025 08:32:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 852F96B05AD; Wed, 4 Jun 2025 08:32:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 64ED26B05A6 for ; Wed, 4 Jun 2025 08:32:16 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E3FD51D742F for ; Wed, 4 Jun 2025 12:32:15 +0000 (UTC) X-FDA: 83517655830.17.F0B0380 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by imf25.hostedemail.com (Postfix) with ESMTP id 03271A000C for ; Wed, 4 Jun 2025 12:32:13 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VXfRG6HH; spf=pass (imf25.hostedemail.com: domain of tabba@google.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=tabba@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749040334; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Oycp2DysTZTgsSQN7AQGA8/4fiD8DvR35ri7QGVd1xY=; b=8VfqatvA2w9730Js8m4Y8r5mbUyF/CRq5w+wNGB0iCm/GOmMpPbEOIrLYFbx4u72IgjxEv ykRnr98Y5SUDi5/T54eDG9QgjLOCrEyy2y/7HuzFwJXjIWbsjcNhzK1Rmq6zRceV9ym5sp 6OTc+vkT5Mztl7fejkC79Wco37f7ABE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749040334; a=rsa-sha256; cv=none; b=UyTfe3h8SfYCywgwI2IRQDvloLKwIqvSkIru6SGICzLKof6V/fg2MhioA9XPw7+DQVE7QE RYhH9OTjtxlvlWF7MxiajFgpCfStoJowiySoiG3t10yS7k4/5K4FLciU/MCfanHZ6uSVLS 53fb6Q7NnxxHvrVhWwzcgVPb7fzL6EU= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VXfRG6HH; spf=pass (imf25.hostedemail.com: domain of tabba@google.com designates 209.85.160.181 as permitted sender) smtp.mailfrom=tabba@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-47e9fea29easo383451cf.1 for ; Wed, 04 Jun 2025 05:32:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1749040333; x=1749645133; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Oycp2DysTZTgsSQN7AQGA8/4fiD8DvR35ri7QGVd1xY=; b=VXfRG6HHFnQcPlkZd7geBXfEzeJWkLQg+pQdYDv40iMxf9hVCM6BZmZMPNvRdiiuIC D7kRXT1/oJe67WIGIepaH3WTzDFT5komKZZrtQMFxBqwksOWnS/n1hafM3e8NX1ViuuZ cGd7iOaieUmJqFZYF6IMtAETikZB7MKEqVZc1Nhd4jOE2YKPR+zJdPvRwjmkyGYBhIbL 3dNoZLVCyz5p4VgEbmFCCUPq2hvZYzMr0xmibM+l6SLzUhKpYSy9MdoiMepcqH3LWNjI yGhe9A984jtAIrff9q+DOwE97p9sDuBCK9gQBUxfpJUCmlm1+SaFeV/mV6HLUDxnCuqu j/kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749040333; x=1749645133; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Oycp2DysTZTgsSQN7AQGA8/4fiD8DvR35ri7QGVd1xY=; b=nbOTgkhVKAFvyTuKU42pSY1dBVliD2te/9DFwMEBcyn8WGBq2TFVgJSUNmf23lHLiz JU6Lv8xc9mpvBwOqGoNjcXIWMxlqPAQ8G8gRokR0JHBhGxZc2H9Q4ySo0plvfnsnFJ5F WQAD+SyytVaUC4tlG8rfdbNoSZye60o50MYwPAjDU+Mhfp90696YtavI9ncFMl87QR5T SUu5ha895PxyjxkRhsw1R4hNT5tzSZmd/6bm6n34tZRqEc1U6CybGlaf5uqZCZk0/MZz 3xlXqK81PGmNaEaPUHH6+sfMyMNMvBt2r5QLLg/0qN/i2LsGGJb+Dt/+gbqMns7YFHnK 51Ug== X-Forwarded-Encrypted: i=1; AJvYcCWh2kYQ8vKJ6TEvlyPfBs+WOSGdLPkOvEdxBh6vX5nuPoCLukSdRRsIMgoMO+MaQ3r6j5cVKGVZPA==@kvack.org X-Gm-Message-State: AOJu0Yypub4Ffxld2UOuv0g2DiXfbMA6JgNtjvgW25aeDql0aA1FV+JF Y+afL8AgLi1yltpkaCdgPFffOIvpHIStss7Uec23qsGwakc0ca4J489X4mMb/2xXG/Ot1NKPGDW N38l7hRm0FmwXprPxy6e7iS1fDvdXWtpdZNECZ6W/ X-Gm-Gg: ASbGncv5Yd1OS8LOW21/mxLCvGHxd0qtP/OaAApfEt77prKQVrh70HSWExIljN8EGPA 6eElosa5ATxGDWKFJdkh46CWC+O1pTIw7q0t322sY4R86zazB9sc7Kfmah9hguuzFCQOkCjUdIF 7vCI4UfCyD8wCzimQvtXCAfV2DIhkE0xrLMUGk/3Vp+3M9ISnsa6b7WTuVDS6qpgCFYJ+GJwd4d q7n4C912w== X-Google-Smtp-Source: AGHT+IG3L6mqoQoAVI94cLa7Ir+MBMDlUg7HjPA78hOi8RtusDiX4fUH4PfN6jsw7EgzxNzZlEXWTTF/eVJa7Ll7G64= X-Received: by 2002:a05:622a:a0e:b0:486:c718:1578 with SMTP id d75a77b69052e-4a5a52d641cmr3709391cf.22.1749040332675; Wed, 04 Jun 2025 05:32:12 -0700 (PDT) MIME-Version: 1.0 References: <20250527180245.1413463-1-tabba@google.com> <20250527180245.1413463-10-tabba@google.com> In-Reply-To: From: Fuad Tabba Date: Wed, 4 Jun 2025 13:31:36 +0100 X-Gm-Features: AX0GCFtQkOaG8vC3W7Pt65KUSQEh4Kx0R_oAJds8qIizcawQAXuvpXqZaNOzgzg Message-ID: Subject: Re: [PATCH v10 09/16] KVM: guest_memfd: Track shared memory support in memslot To: David Hildenbrand Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 03271A000C X-Stat-Signature: 89h66a5uhhh58bpygukmbtqpcr4rzfox X-Rspam-User: X-HE-Tag: 1749040333-734911 X-HE-Meta: U2FsdGVkX18S7EEaccD9xeIwOi91WtdtvaOBjL0DyNHOmYwuJPyHbgjsgWXkhKqaAjOg9aUTtJ+yXTRMFDGVrG0pzmZGr5jPsS/7Mlui1ilva2Et4lghPFyhNM2WBhEDV7XMpn3kbNRvbgUJ2wllE0VTX++y/w1Zd5gm7pNq/WYdm43pXr8/3YaakXiZ3KeIpjGqN3xneKX8vxd4mSEY942uIHxxRjrF2zcVGxU3ZVRZQ6dJfip9uir1/6jCb2Zy2J4/ILB/i5xD4TaFbeQgdG6bVYmPaK537E+a8/YtnyqZtMFJD5UaV/6cSk6JO3QIggYpotl+VYoOFwHM2je6wUeuR5Atrr/xS4XJZ3p87aApbvXGproGg8NHgxJtovIc7wOKlMYObeqcQ0upzY81cpOsVNeglDmO8/q1raWauw0q+VBWL7N/bg8e/qMBcklxyKYSa8RQ3Pw2EXoho4C6qvBT2Dg7KrFLS5FbQG4q7B0YbE8VpsdlcX3KQSk3p2NFlECa1BGyNDo0CWfrF+uHHO8qnVB+dmCK7Cq/7K5InSIRK91FU/g8MSsrpdLga7S/tHb9pTiPHdQBna8JhfjrO8gOEAQw9EuUwU5NlJRdrcfMLPQSbvS5O66o6yX+ri3h9hnsIZ4IF0U4H5q1mFGA2UvSkYwiDUr2TR0sZc63vrbn6u3595xRtrFO20zmEnGCQZuDqy2+HWQ62Uji7EXqFkVzHlUtTyDcICFNYAaDnc+L22qhq1nCj7P9Sy/mfrbO28czoP5Rh5c+OG6IKcAIJWf/C16h8K3sH4eNsyJ59jQgtpRBUXP/OdcfIJsP6TK1rSmi46ZfsnN/P/josIf75qtP2tYb3ONzUFqipO+4KwNTuZgZZbxHhjZ/FocuLQhlfi3+3W15hpVYgoC9cEfm4g3pQQKGN/ItUY07FTkvktH/O5747jTPrR+86Ag6cLt06ZMzB6ulLu8rTAFV44+ xYlKmnDW 4ckYqWfHopVVV12RyUcHLJVBB3RLnHRSfbe9ANNHNayH7HqXW3GXfRIOwiZ4nRHucVPNidRE3uqaFXEnXxUbxZloKoss/5Z5ybczYcpfdq0kGq9/uCy0rQADjh5VfTES6I0m0oJz3v5JV8shDOqdSi1CNiA037OpLCWgOygkY0bP8PYS8Cny7bK3opj/0xPByB5FWk+tjYlIIsLWp73pL62eVgNe7ac2cbcAA+jh8CtPUpvpP09sydp/lX2GzO8eIscHYmJV3EAYohZOTAqaAlSDODbnhdNtbD3RD4+F/zwaM+I2hNP9v4uDmPG59fuQZaa6/3bY72pElaCdTd9ezRoy7eYeClV+tg/AYkHv7jQ0o/NQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 4 Jun 2025 at 13:25, David Hildenbrand wrote: > > On 27.05.25 20:02, Fuad Tabba wrote: > > Track whether a guest_memfd-backed memslot supports shared memory within > > the memslot itself, using the flags field. The top half of memslot flags > > is reserved for internal use in KVM. Add a flag there to track shared > > memory support. > > > > This saves the caller from having to check the guest_memfd-backed file > > for this support, a potentially more expensive operation due to the need > > to get/put the file. > > > > Suggested-by: David Hildenbrand > > Signed-off-by: Fuad Tabba > > --- > > include/linux/kvm_host.h | 11 ++++++++++- > > virt/kvm/guest_memfd.c | 8 ++++++-- > > 2 files changed, 16 insertions(+), 3 deletions(-) > > > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > > index ba83547e62b0..edb3795a64b9 100644 > > --- a/include/linux/kvm_host.h > > +++ b/include/linux/kvm_host.h > > @@ -54,7 +54,8 @@ > > * used in kvm, other bits are visible for userspace which are defined in > > * include/uapi/linux/kvm.h. > > */ > > -#define KVM_MEMSLOT_INVALID (1UL << 16) > > +#define KVM_MEMSLOT_INVALID (1UL << 16) > > +#define KVM_MEMSLOT_SUPPORTS_SHARED (1UL << 17) > > Should there be a "GMEM" in there? I'll change it to KVM_MEMSLOT_SUPPORTS_GMEM_SHARED. I thought of adding _MEM as well, but it starts getting too long :) Thanks, /fuad > -- > Cheers, > > David / dhildenb >