From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8660BC5B549 for ; Wed, 4 Jun 2025 13:31:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 126B06B05FA; Wed, 4 Jun 2025 09:31:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FE596B05FB; Wed, 4 Jun 2025 09:31:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 016E86B05FC; Wed, 4 Jun 2025 09:31:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D7AB16B05FA for ; Wed, 4 Jun 2025 09:31:51 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9C241161330 for ; Wed, 4 Jun 2025 13:31:51 +0000 (UTC) X-FDA: 83517806022.03.633EF64 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf27.hostedemail.com (Postfix) with ESMTP id BB56B40021 for ; Wed, 4 Jun 2025 13:31:49 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ni2zt32b; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of tabba@google.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=tabba@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749043909; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U64ULQY366JHJ6Sx1aslM0i3znI6AoNF+AhIqQiQaNw=; b=eR6apqfZcuEuA+Fm8St8D7GwAeqBYiNbJyDdqMRg8h9G8E/dpP1FeMUPqp/gQCVbDrldE1 q433J1RFyw2MIv1s/jnpmTG03/6AGz5isRKod1/VbGYBbmyFlTv97mFtG9B6HJkFJBD68+ XgRxdNw4ibrWTQ844VRGpZuH792iUUU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749043909; a=rsa-sha256; cv=none; b=6+xQgxCb4Q0M9fXrJ18AnDw++qUGKYaB/vbkIHI50L/QA71/vOJeFiYYwWzgN96AuPCacd UEGOzM6k12SFH3J0g8TmBT1kT47DBz03xNFTFiqmXAD3zCcppjiQ1QlysxSsD5lQmpa7/j PxqiRhdKMnE2S3El7bcfqyfcq5POSO8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ni2zt32b; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of tabba@google.com designates 209.85.160.171 as permitted sender) smtp.mailfrom=tabba@google.com Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-4a5ac8fae12so77611cf.0 for ; Wed, 04 Jun 2025 06:31:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1749043909; x=1749648709; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=U64ULQY366JHJ6Sx1aslM0i3znI6AoNF+AhIqQiQaNw=; b=ni2zt32bSk9xn+Suz6jMewbrn6fNaTEltfWMCnYSZPGhAiNkDMvtgIUZOlI47Cig4n Guq4SOKOM14TfJWQA4l80xrEECWap+PjywKsh25wnLFFtSZnaykMrO/KUqtzk0ouAGLS WKGAh5PuGd70zGL+Ry5eq3MFXmXsFr7M9zR5Z9lR6WNBreiAeGffZUIJcoumA05c/ca5 jGzrMWAPfm47rpey56hTgRf41uOLmdLbW/UOt+PLmol1/C9nb5Ft5wG2yOxKrJyUP4tE yS/hlJ4IM96FXdqlQ6iei0NP9ibOQKtRryFe/j/b+BBm9qKnz7YPjJr1e2WaZHyxko9j u0rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749043909; x=1749648709; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=U64ULQY366JHJ6Sx1aslM0i3znI6AoNF+AhIqQiQaNw=; b=fteeS+E8LrXRPm4qMrN1bKe1m8q7j1tP31sQDtK2zH9eRiq1fQsFnjK3jqWjUxHbQe l6cV0XfePmS6SwX8KfWPcQVgnh4Fz499MkiywBWg7az3d1GPp+LZN3k+yljxKtd+cBJw k8w0ETIWy1qXKdnsyeiahSJSqVfyVvMGfEkxIVa4+HIhFqB8tKn0NJ8vnKCJvbSYA8yl MOPVUH+i7msPTz+H2KB089tYeTgM0ECgxSE8Kqf7fPj3OqKqLp2dDBE0HssMU3uSf4Pk mm1l+/scf41bZquPHbpxXcUWrI1TXpvwVyJnwHRYLk/8aua9GiBMVquJi/oac4WCHEKe KWCQ== X-Forwarded-Encrypted: i=1; AJvYcCU+tx/BFGQCNfqvdQ0UIRTCmJ66q49CNr2/27AVpbFp2jMhMi/LDaZAQ7vVyXHE0DqF0YvL2e0s9g==@kvack.org X-Gm-Message-State: AOJu0YzRY1jm1wOvyClUxLvAVmCSQhOuqzaRUpLsoEpBXLBnAzI/Teq6 8Z0TmiH3vU/0JtI/kv+ftl9zZltnpiMuPG8qkjnev8Yvsb9uuueRl0IEvZywFa8paRdCkHkhCih k1q4KcAXrSwpdtFP6vudI8o283y0CNnfOPFbT0nxo X-Gm-Gg: ASbGncsCj//njXLYrfpFhJlP7Jn1V/9gdXu9G7xiXic9l+uPOkTW9A3aOu09qSyroIM z3ayfGvMVMpKDCiiDJLAPF4wFhrSCaLSTLIJnX3CRphdcuD3x0O/BhVjIQjQZWbhnth0keDPMJz 0dFpUmCgOoUSpP5hnwmQDkfW4I5+956j016fdplSJktBe1A/3lfadAbIHyH/Iz4e2blhuPIu0= X-Google-Smtp-Source: AGHT+IHFxNyfeCkrmPB39UOxojEdJAvr9WP0K1kR8JJNwFVpZqhXOBdLWxdCHfxLQMAur6bywA3oSFCMPjvNqDTSLOA= X-Received: by 2002:a05:622a:5912:b0:48a:5b89:473b with SMTP id d75a77b69052e-4a5a60dcaf0mr3295721cf.7.1749043908478; Wed, 04 Jun 2025 06:31:48 -0700 (PDT) MIME-Version: 1.0 References: <20250527180245.1413463-1-tabba@google.com> <20250527180245.1413463-15-tabba@google.com> <2195c01b-3a17-46c5-a013-66922e8509bd@redhat.com> In-Reply-To: <2195c01b-3a17-46c5-a013-66922e8509bd@redhat.com> From: Fuad Tabba Date: Wed, 4 Jun 2025 14:31:11 +0100 X-Gm-Features: AX0GCFtqukMxO0pis2hyEa-S596-RXzEqFLluLmu-N319w02tyWHzt3chjxqO1k Message-ID: Subject: Re: [PATCH v10 14/16] KVM: arm64: Enable mapping guest_memfd in arm64 To: David Hildenbrand Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: BB56B40021 X-Stat-Signature: 5kqsposfj5hocyzq1x9yjjcarbtordz8 X-Rspam-User: X-HE-Tag: 1749043909-546737 X-HE-Meta: U2FsdGVkX18rOQ6+9geZgRUHSnuvxcGeUPf5r8ZJzh6QdRG7jcBoy7CIwHamkipujTBPFcItBTVSOw1dC/q9PvIGF99D7nPo8mL654wS/7ZVYhT9978wWMtfGqAfm+H7zPxNCZrbQZzoRQ2ux1OtXDrjgslJoN0S5sxPOswdkQ/ik2WcfzlZoswo/rj8P8AXlEy7teps7aAZnRu8L0nFIV/RuksnYee0YPxB3s9VHmdhHRNH9mchlOAh5zIV2FCjo6C6aXpTLpo+zDUTPzePRuP1bbTwqKidXkSiMRRJvXuTHfjQcmzdKT+9vn8QNxklpFTyrB/qwZS/Xjf/VXpB7Ab/MMBLpq7bR1Ek+1VJR0jpaDzeQp8e5U/sTDUsy2KBc5IKZcQjQWdBK2IT31Mq8hBuV6pbtiNwhTk/dVe6fwHY8jMFmLInJPArtqsopFcI0G2SjyJS2Ph8Jy+YCTkGD6zngs6shDuwGsVHwLp6wgaPYLu13volhdzVTFGhfq+9Mb65ez4UAIKgV03sWcvIBk+v991WdEfGEH847p0DP3Ab8Nje+zc46wJ41Vzm83CLr6jWhoJ+LiVYbG7xicxvi8AHAkz3ELoWisdxhm87g5FogyJhxe7VuRrTCPxRw3e+h9Q68qlb48jyGwLBreiN29lJylQNFAQju66cxRS4r93VPHktHwA2AJmhoPA0ufk+oY9Rik5a8meZ54Qt/Yf64YDcrf62LZUoofAAtS7RVr8WARvFKWEKZFIsX+MdtkzIc7Vtfzur/u2ROTeGzgw9BsthajKk8w0xgVW/nM9ajJSjTwWuvShbzfiJ+0WUn5z8//+v6mUwisj1SXMpPQdHxAsZsWN/NOFVimTI3hnOxAewJ/b62ccuRU6kUGa75roYIcZmLSW9rQZy9AM55w8CPPf5LFZTfr9hjdlJHVO5DGzr5WNTPSRasRmieAGuy0qXxXIDQGS9jKfFIYICSh0 bClZfkjM gNUHJcVsxt/wor7dPE98dPpiMAZ72oU1pcoZnnt/gSaB7+bdg03eHA0FcCdS76e4kHEkE/yl9F7La+uKSiULARgfujZyM64TuflRYjel9/v90o/e5uIm6fGnvVerUM7iRC4KRXqgkn2XNYiW0zojBK1ygFUN8cx6KC1pZ9UqjMrrcLIYAcB03mV+tz9/M8T1qCH4AWcnpKCeTzfz3OOtPfLrZ/VgpTbAxTIhpFSofTov0IXBrznh8LKUhozJGsjYvuFNE8xj/zTh95ki27JafYPRqQRHLSXXXCoSYpUOhbKJNzLMVatoai+Uo9HPDtg2/7EBVxVFubzptmA2RhR6qp8AnFVGb4+QfawV12kr8+dqvlzs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 4 Jun 2025 at 14:17, David Hildenbrand wrote: > > On 27.05.25 20:02, Fuad Tabba wrote: > > Enable mapping guest_memfd backed memory at the host in arm64. For now, > > it applies to all arm64 VM types in arm64 that use guest_memfd. In the > > future, new VM types can restrict this via > > kvm_arch_gmem_supports_shared_mem(). > > > > Signed-off-by: Fuad Tabba > > --- > > arch/arm64/include/asm/kvm_host.h | 5 +++++ > > arch/arm64/kvm/Kconfig | 1 + > > arch/arm64/kvm/mmu.c | 7 +++++++ > > 3 files changed, 13 insertions(+) > > > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > > index 08ba91e6fb03..8add94929711 100644 > > --- a/arch/arm64/include/asm/kvm_host.h > > +++ b/arch/arm64/include/asm/kvm_host.h > > @@ -1593,4 +1593,9 @@ static inline bool kvm_arch_has_irq_bypass(void) > > return true; > > } > > > > +#ifdef CONFIG_KVM_GMEM > > +#define kvm_arch_supports_gmem(kvm) true > > +#define kvm_arch_supports_gmem_shared_mem(kvm) IS_ENABLED(CONFIG_KVM_GMEM_SHARED_MEM) > > +#endif > > + > > #endif /* __ARM64_KVM_HOST_H__ */ > > diff --git a/arch/arm64/kvm/Kconfig b/arch/arm64/kvm/Kconfig > > index 096e45acadb2..8c1e1964b46a 100644 > > --- a/arch/arm64/kvm/Kconfig > > +++ b/arch/arm64/kvm/Kconfig > > @@ -38,6 +38,7 @@ menuconfig KVM > > select HAVE_KVM_VCPU_RUN_PID_CHANGE > > select SCHED_INFO > > select GUEST_PERF_EVENTS if PERF_EVENTS > > + select KVM_GMEM_SHARED_MEM > > help > > Support hosting virtualized guest machines. > > > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > > index 896c56683d88..03da08390bf0 100644 > > --- a/arch/arm64/kvm/mmu.c > > +++ b/arch/arm64/kvm/mmu.c > > @@ -2264,6 +2264,13 @@ int kvm_arch_prepare_memory_region(struct kvm *kvm, > > if ((new->base_gfn + new->npages) > (kvm_phys_size(&kvm->arch.mmu) >> PAGE_SHIFT)) > > return -EFAULT; > > > > + /* > > + * Only support guest_memfd backed memslots with shared memory, since > > + * there aren't any CoCo VMs that support only private memory on arm64. > > + */ > > + if (kvm_slot_has_gmem(new) && !kvm_gmem_memslot_supports_shared(new)) > > + return -EINVAL; > > + > > Right, that can get lifted once we have such VMs. > > Acked-by: David Hildenbrand Thanks! /fuad > -- > Cheers, > > David / dhildenb >