From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB3BEC83F1B for ; Wed, 16 Jul 2025 08:12:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 632BE6B0098; Wed, 16 Jul 2025 04:12:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E3CF6B00A0; Wed, 16 Jul 2025 04:12:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D39E6B009D; Wed, 16 Jul 2025 04:12:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 33AC56B00A0 for ; Wed, 16 Jul 2025 04:12:21 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 04157802B5 for ; Wed, 16 Jul 2025 08:12:20 +0000 (UTC) X-FDA: 83669410482.26.4184A98 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) by imf01.hostedemail.com (Postfix) with ESMTP id 25CD040007 for ; Wed, 16 Jul 2025 08:12:18 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=JDFXRJnV; spf=pass (imf01.hostedemail.com: domain of tabba@google.com designates 209.85.160.173 as permitted sender) smtp.mailfrom=tabba@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752653539; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9lXG3S9BZe4HTILb/Bnao5N33QhAfEHK8ncuEoyNOSE=; b=D4OMXO1ULQJvChC9Fqs/T5Fa7mtcRbxPBsEyghg7PkgyCYojfflAaXESt/+cntNlWoP8JQ Nq8E0RlhgGnCnAI0inVzmFq04O8BHmk9OnXR4fhvoZG68yBdRTWDrRdov3yqnTpcs61KFX WlDKgC53T4Be7Tmrad0BQq4NWIT2yZg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752653539; a=rsa-sha256; cv=none; b=QMUJfYzWr2MmLBjDifEN2GTW43hsIWa4Kenw+8sGvGz5Kb1jgmG1dwBwe+p5KWHLTvomTs 4oOqZV/SjAi3sF3Ehh/a0XWHksCSSGsnpww5A7KFxkmD2wLw5oOPOG5pXihe85N1XsLzla GGZpvbxvpmGO/kDndD5nO0uGbc+Ve48= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=JDFXRJnV; spf=pass (imf01.hostedemail.com: domain of tabba@google.com designates 209.85.160.173 as permitted sender) smtp.mailfrom=tabba@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-4ab3ad4c61fso347711cf.0 for ; Wed, 16 Jul 2025 01:12:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1752653538; x=1753258338; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=9lXG3S9BZe4HTILb/Bnao5N33QhAfEHK8ncuEoyNOSE=; b=JDFXRJnV4/zD/PVH0S2zl7jN6DqyKfR1GVbkxoB+IYiq+JEBK8jlfjNI1z/KFLdYIx xCOoucB3f1u+wmfa0uyHBGsULhTKIKNGoPZTUqVcOWGgX5gAQoHmgOrcA/AqhpqjLN1J fBMdQut72boe3Mu+lThozBw7Bjcdcn/RmQWIzAikozLbgQNdo7EbeJVL9KgNEY1plAeK dsSdQLA5DLfV4qRYSC47M4tRm6zDmHa19aO3E+D6iEJWpKQz5uzE4gpAUIvPy+J5KvIp Y/W3wDjNKWhxAiJZ9D2NhO2lBsZN8S9+LXsZ/pW3gZwsHglFselmVPa2ZTUdeNE7FoIp ANXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752653538; x=1753258338; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9lXG3S9BZe4HTILb/Bnao5N33QhAfEHK8ncuEoyNOSE=; b=wdfFSkbV4/Y5jvj1yeBfsUYesoP1xvKf686V2YwdVTzFoBIG43dQaAsM5KvqHPk2/7 wck/K7u3Bf/ef2yO1NyUKxEEesnrRxNNe9IuSaT0g99gr6XJMy6bah+gZN9HlnmP4L7T gm39/mLumw6w1RWXyAkiBW1NrFreSaGnlFmBFWJYibTxinPG6d6fUiw+DwuhvtBCsaTb Wkv0GvliKlJ3Cg06j+LU9pbi2zahsWLru7Gv6AHkSyKZdFXpkD77ZOWJhhZotUBw77zz UDdbuptn22DaGC+eu68+zjQCclkS/ntFd9La/qJBsv9S4GhAtHXWiua7TakIceRenv9J LK5Q== X-Forwarded-Encrypted: i=1; AJvYcCVikshrPfSaoK8MbD+KjfxXr/mDmDd5WvybTqyZrY5/x+rwfnAyHQS1Q00M5/SOip9M7B73aIL6ew==@kvack.org X-Gm-Message-State: AOJu0YzGHlw69/tUO+oGrvjVQnS4+ovx9za2rCFhIXF5fvYWamDxjqY6 +5Wly1lKqJDmdvakydKI8NNGo93VP2kTuWSjM+HUNQPf+U0JIBQIDd4wHM6fskr9mok7L5utJCe Qh9vRmEOOSpn39fnM+fy3kzObfkPRIAuTTjvMoF4l X-Gm-Gg: ASbGnctHAwhGQOamDdUxCJw0r9FTQT5WYQ10L6iLw49VWwL0DdRKKRNg6CchYZOUfqm cjJ/kEHYhZtaiyWd3vEQ8bQf1nKJkCyoDSR5+ppxghNgMf3A5UpxJp44Gg9Dd/70i/80fA9fZ9L T8Mwc3hdXJvFrjNvF7fuB+CJyLYx/gTDqt2Juje+9q5be7x9iLx7NfvQ45rh6ya2wv12yQmsk+e ZD5jDbxQPQnPX0cQWRkbaou+V7QXIaGJbD6 X-Google-Smtp-Source: AGHT+IGBOCxJ/Qm9HEzyLGT9rdfHPf0UnzAM8lyi0X0Lv1v93DUUc8uHVzmb4HnCFFNKyy0ua3P+EnrBZKtAIViOZ5A= X-Received: by 2002:a05:622a:1a9a:b0:4a5:9b0f:a150 with SMTP id d75a77b69052e-4ab953d76admr1899631cf.16.1752653537471; Wed, 16 Jul 2025 01:12:17 -0700 (PDT) MIME-Version: 1.0 References: <20250715093350.2584932-1-tabba@google.com> <20250715093350.2584932-3-tabba@google.com> In-Reply-To: From: Fuad Tabba Date: Wed, 16 Jul 2025 09:11:40 +0100 X-Gm-Features: Ac12FXywDVFBk8xIRrEGHJ76oUEfDIBGYlNiYZT2NsSZ7eZhzD9_CXX8jGKmVsI Message-ID: Subject: Re: [PATCH v14 02/21] KVM: Rename CONFIG_KVM_GENERIC_PRIVATE_MEM to CONFIG_KVM_GENERIC_GMEM_POPULATE To: Xiaoyao Li Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 25CD040007 X-Rspam-User: X-Rspamd-Server: rspam09 X-Stat-Signature: na9rw8t16ebesya7fwwkzzx6oamdjzqp X-HE-Tag: 1752653538-22817 X-HE-Meta: U2FsdGVkX18rdRKpNwHjprg8agJ6ZOruA0xL9klIlLblfpXigF8F065oK/kiOLVo4uLbC7wM9l6wzMMwhFRV5NY+kcA7BkMd1bKnXa+p/QcEGR1lCxAxumJhiQJnXIbmUpud6a11oznoMGfOC3zRwqs6l1EAzMjMYOFfqnWPYs9onG/4pJSvmJSea1lmLjr42CRs+c/pcb7ycnN9MdsRSdrz0kCTPh2c/ved+OJFYBgapXO/fbhvy4hm9gToUPtyY48A913QXgtQv5RZeb9xhju6ViL8dy6mqNiOYdYj2HRlWmfNUBLyQi0R0DXx+mvYd7HhstE6I7z9qrXwvAmZxJH9nElJYbBwVGc4rtJvbU8/kBBxuS4q2WUesZTmf5ldmhlYmBq/VkTkzt/NEORzoSb7biKtgEClQarsoi3iTs37w5GNVaBQSvxZIHELpxyNseaQ7OT0Yk4zyUVLj80xTn88CFK3HEYUsIL3/27qRJJ73+wkW00JKuOnuX4WeFQAGf26N6Cv0l26iQBi4AJhLkiINjUpwI5/63G+T5fWpZmuaHbgOtOfINvBrxgsMNMxKeBCZSz/ivfBcWbdlVRqiBOKwhflUvOdJx8g87hPtzcO/xvgVglNXBI37JpDzh0EkdcWUU1dkNp9ft5bNFixWU4a9pK1dtvUO4fsFhT1EM2WeM37gMcKu44vOppUTDtoSDYFptc8Q9RmTSxIhJrphdyddjAyqGqoqsOuTd2EsL65mhkTE7D5qs2HTh2dA/uOHs7i8+BeBa3w28u/jhguSTgAZsv49xjWZWHcOzRBQxGGUKezqiWJLdjaEcxHdAJVkgG6Cdth7nAgAqtSrX/HM5wm8Fk1jG2vb5FrNPCQc1N1L1gE3Dlc0LfGp/CLy9m0K8E5x2MU1KE31DVRrQqMPcavaMP9Pd7ztJ9p3S50PwNQK6TnHbf6el9zQkEsazWz1Xhqe9+ZyeWOveuZr6d 3LTLoX0Y 2lAO9u1t+rphWqp1RVbczsPJSoFR29nn3jVtGZ/kF5EWyPrXXsBODBhBB/77/8pN1XdcMDRbkq2T6d8PEiYF5v4A2q5sr6r3mFZdXZDqbWhFxyMBcuMDh+I25tCpnztYVuOAwBuqmxiQkG0h4KFBpxVI1MCXcGnyClMKIATmzzQLTLAoq4rikV/SgV7AnK8niD4efcdTCBZqFdhCZ1XpdydlXH8BI/awdjubjjHSeqsfslINXU0kqqj96DJU2KtGMMn/YVYfT4W3vYSnLB+sMMR4Qhg7KxBGRkhDLf1oxc2MASU2Sn3mwigVnmmCt5ohFlhdatd9pORz/AyjH9OpUuqyYeEy0TK4fu/dGfCJCTWZforiQoTzPHmMbceJSdXWI7MU7McKFZjQf9Y1fVQWxxTZblJrEbSLIPAdYBa/ZZ3tBN5I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Xiaoyao, On Wed, 16 Jul 2025 at 05:09, Xiaoyao Li wrote: > > On 7/15/2025 5:33 PM, Fuad Tabba wrote: > > The original name was vague regarding its functionality. This Kconfig > > option specifically enables and gates the kvm_gmem_populate() function, > > which is responsible for populating a GPA range with guest data. > > Well, I disagree. > > The config KVM_GENERIC_PRIVATE_MEM was introduced by commit 89ea60c2c7b5 > ("KVM: x86: Add support for "protected VMs" that can utilize private > memory"), which is a convenient config for vm types that requires > private memory support, e.g., SNP, TDX, and KVM_X86_SW_PROTECTED_VM. > > It was commit e4ee54479273 ("KVM: guest_memfd: let kvm_gmem_populate() > operate only on private gfns") that started to use > CONFIG_KVM_GENERIC_PRIVATE_MEM gates kvm_gmem_populate() function. But > CONFIG_KVM_GENERIC_PRIVATE_MEM is not for kvm_gmem_populate() only. > > If using CONFIG_KVM_GENERIC_PRIVATE_MEM to gate kvm_gmem_populate() is > vague and confusing, we can introduce KVM_GENERIC_GMEM_POPULATE to gate > kvm_gmem_populate() and select KVM_GENERIC_GMEM_POPULATE under > CONFIG_KVM_GENERIC_PRIVATE_MEM. > > Directly replace CONFIG_KVM_GENERIC_PRIVATE_MEM with > KVM_GENERIC_GMEM_POPULATE doesn't look correct to me. I'll quote David's reply to an earlier version of this patch [*]: > > I'm curious what generic means in this name? > > That an architecture wants to use the generic version and not provide > it's own alternative implementation. > > We frequently use that term in this context, see GENERIC_IOREMAP as one > example. [*] https://lore.kernel.org/all/b6355951-5f9d-4ca9-850f-79e767d8caa2@redhat.com/ Thanks, /fuad > > The new name, KVM_GENERIC_GMEM_POPULATE, describes the purpose of the > > option: to enable generic guest_memfd population mechanisms. This > > improves clarity for developers and ensures the name accurately reflects > > the functionality it controls, especially as guest_memfd support expands > > beyond purely "private" memory scenarios. > > > > Reviewed-by: Ira Weiny > > Reviewed-by: Gavin Shan > > Reviewed-by: Shivank Garg > > Reviewed-by: Vlastimil Babka > > Co-developed-by: David Hildenbrand > > Signed-off-by: David Hildenbrand > > Signed-off-by: Fuad Tabba > > --- > > arch/x86/kvm/Kconfig | 6 +++--- > > include/linux/kvm_host.h | 2 +- > > virt/kvm/Kconfig | 2 +- > > virt/kvm/guest_memfd.c | 2 +- > > 4 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig > > index 2eeffcec5382..df1fdbb4024b 100644 > > --- a/arch/x86/kvm/Kconfig > > +++ b/arch/x86/kvm/Kconfig > > @@ -46,7 +46,7 @@ config KVM_X86 > > select HAVE_KVM_PM_NOTIFIER if PM > > select KVM_GENERIC_HARDWARE_ENABLING > > select KVM_GENERIC_PRE_FAULT_MEMORY > > - select KVM_GENERIC_PRIVATE_MEM if KVM_SW_PROTECTED_VM > > + select KVM_GENERIC_GMEM_POPULATE if KVM_SW_PROTECTED_VM > > select KVM_WERROR if WERROR > > > > config KVM > > @@ -95,7 +95,7 @@ config KVM_SW_PROTECTED_VM > > config KVM_INTEL > > tristate "KVM for Intel (and compatible) processors support" > > depends on KVM && IA32_FEAT_CTL > > - select KVM_GENERIC_PRIVATE_MEM if INTEL_TDX_HOST > > + select KVM_GENERIC_GMEM_POPULATE if INTEL_TDX_HOST > > select KVM_GENERIC_MEMORY_ATTRIBUTES if INTEL_TDX_HOST > > help > > Provides support for KVM on processors equipped with Intel's VT > > @@ -157,7 +157,7 @@ config KVM_AMD_SEV > > depends on KVM_AMD && X86_64 > > depends on CRYPTO_DEV_SP_PSP && !(KVM_AMD=y && CRYPTO_DEV_CCP_DD=m) > > select ARCH_HAS_CC_PLATFORM > > - select KVM_GENERIC_PRIVATE_MEM > > + select KVM_GENERIC_GMEM_POPULATE > > select HAVE_KVM_ARCH_GMEM_PREPARE > > select HAVE_KVM_ARCH_GMEM_INVALIDATE > > help > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > > index 755b09dcafce..359baaae5e9f 100644 > > --- a/include/linux/kvm_host.h > > +++ b/include/linux/kvm_host.h > > @@ -2556,7 +2556,7 @@ static inline int kvm_gmem_get_pfn(struct kvm *kvm, > > int kvm_arch_gmem_prepare(struct kvm *kvm, gfn_t gfn, kvm_pfn_t pfn, int max_order); > > #endif > > > > -#ifdef CONFIG_KVM_GENERIC_PRIVATE_MEM > > +#ifdef CONFIG_KVM_GENERIC_GMEM_POPULATE > > /** > > * kvm_gmem_populate() - Populate/prepare a GPA range with guest data > > * > > diff --git a/virt/kvm/Kconfig b/virt/kvm/Kconfig > > index 49df4e32bff7..559c93ad90be 100644 > > --- a/virt/kvm/Kconfig > > +++ b/virt/kvm/Kconfig > > @@ -116,7 +116,7 @@ config KVM_GMEM > > select XARRAY_MULTI > > bool > > > > -config KVM_GENERIC_PRIVATE_MEM > > +config KVM_GENERIC_GMEM_POPULATE > > select KVM_GENERIC_MEMORY_ATTRIBUTES > > select KVM_GMEM > > bool > > diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c > > index b2aa6bf24d3a..befea51bbc75 100644 > > --- a/virt/kvm/guest_memfd.c > > +++ b/virt/kvm/guest_memfd.c > > @@ -638,7 +638,7 @@ int kvm_gmem_get_pfn(struct kvm *kvm, struct kvm_memory_slot *slot, > > } > > EXPORT_SYMBOL_GPL(kvm_gmem_get_pfn); > > > > -#ifdef CONFIG_KVM_GENERIC_PRIVATE_MEM > > +#ifdef CONFIG_KVM_GENERIC_GMEM_POPULATE > > long kvm_gmem_populate(struct kvm *kvm, gfn_t start_gfn, void __user *src, long npages, > > kvm_gmem_populate_cb post_populate, void *opaque) > > { > >