From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B90DAC83F1A for ; Fri, 11 Jul 2025 11:09:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 45BB76B00A0; Fri, 11 Jul 2025 07:09:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 40CB66B00A1; Fri, 11 Jul 2025 07:09:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2FC576B00A2; Fri, 11 Jul 2025 07:09:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1C5B36B00A0 for ; Fri, 11 Jul 2025 07:09:36 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BD1EC10EC46 for ; Fri, 11 Jul 2025 11:09:35 +0000 (UTC) X-FDA: 83651713110.23.F6E960C Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf09.hostedemail.com (Postfix) with ESMTP id DEB40140012 for ; Fri, 11 Jul 2025 11:09:33 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="Of4QiZ3/"; spf=pass (imf09.hostedemail.com: domain of tabba@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=tabba@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752232173; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YtL2RY30FqQCse8pZRhypsMK1Ug1daCGyP2jBjuiKck=; b=H+vpL/EANjtQuFwSG6ld1syAveTGymY8PYA9rRkpbL27z9jpj+lvpXyRb0V4FiI67iVkyX zfdRunsBkjsqpoHzf63YtT7sUffTcYjfYtEDQ38T1Y4NhGjfie4rCz3kOOsOSCujOn8gou V22WggGgJ/ECPNm7JwStrMEVjKi4OP0= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="Of4QiZ3/"; spf=pass (imf09.hostedemail.com: domain of tabba@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=tabba@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752232173; a=rsa-sha256; cv=none; b=Uz7lTvuXbvRnZOsjDYFKVFh31oHpMbQ14P/tAweGzWXTeXBU7B48BUUrrWCcMbC5FQVsdF +o9H/stSfRK6wzQK7nJNeh/04aaRS1lXKMANrZEY0zKQXtiTVTnWX8N2G+fi1eRtoIgsm/ CfugPGRpR6pwBXMtsC0BOn+mmeCB0gA= Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-4ab3ad4c61fso99871cf.0 for ; Fri, 11 Jul 2025 04:09:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1752232173; x=1752836973; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=YtL2RY30FqQCse8pZRhypsMK1Ug1daCGyP2jBjuiKck=; b=Of4QiZ3/OqGWgFylMNUAliMK6ywAfvyyV0d8iqmqOTNllAjdzO/L5NyJ3zwAbe+QTY hXQ9IoQst3zjHPiVx77SYZx7K97glIMDzc1Ud5De/CHO4+zfSIYeVviVtqt51kH28V3y oTy/cnoCy0KFY9Vli0jw3dPu1IAlYuOq5pTILcBAO26OYpRAnq9t/MqHd4jzLrOWvAqn jXeQiSEUDleQwb1emEiiu+cpBfBjg2NJKavwyyjcQN0EV4dqS2PMOMx0PCJ398joL8OO tAckfxNuMqPcEv5+N6m7AaSj/kgtVLFdLnhodUS3LxhCOwI0r84S4DnIaDXv4/Q/W1dX m5bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752232173; x=1752836973; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YtL2RY30FqQCse8pZRhypsMK1Ug1daCGyP2jBjuiKck=; b=kybcL6pSs/92T/y7RhciRXqeCCYDy3wwMQXkK6+yARw98bbqj2AkB6D2Vj1ShqASPy Z+lNo5jnHd36dYPKlJzBSS9FbzxN1d+vWwTxKwEvAdqD7A+lRYMJo8onyRmPnwdGroLE oHZsLSRLvHtPSyL7bJxSONXlvDIKZgN0AP9rSXqAR4uw3Y7ThvtJ6+UcTxMdeQSER5Tr TF5p75KVbDvotUTcAdJL4HhqUnZ/bcVuRX8qkCKs0/L73iXTfEjsgfGX/qRowZ5rrt/E cy82msuYa0gR80OtYNC9U3nJjLDjbOOnJWK5wAL1nK5O0fSXhPyagVLuura1qPl3TDeN IO+w== X-Forwarded-Encrypted: i=1; AJvYcCUT/J8IssVYMclqNgrewlBkYhVT32+sy9nbjiCYs0WX7yBLI1KVmRmjIqH6r+IAntCPCUcDfMonkQ==@kvack.org X-Gm-Message-State: AOJu0YztH2oNSoRzHdy67rq4ZUk+VH2a357NeJ7jNjn+mnDp3ha7nhgG we3M7Z0rYumFzOTAQMabHkC1CNddnm0xKAUVjDXpO925Ao4fAdXPGROmz5X5kqtXRbYUgOzdSl/ Pitf5bqRVSCHApop3C5MCjeN/nFOR9Ro/UGCTpRn/ X-Gm-Gg: ASbGncuunwNolGELYZxEAwTF/f5Hw7vQsJBh6JWfiU0gT1PNDsOIoSnostq+UTGiQo4 bfSZiR5vJPX/PwaQ7bZmWMddfLelCHhH/hY62TkIJ4ShvLS/7R3/zNur+jPP5uwHR7WM+86EifJ DlAZWzPo/L1rryVcavRrIN+y5Pr6IEXtMQcf8GbfPfwp1mJU9qPxibPPs08DTS1Bp2lVsxr4xah rFWu30QVDjAwMRr+A== X-Google-Smtp-Source: AGHT+IERmXIWH70IswPePcnTHu8w/geAIcWqwjz0lTJocB7rOcnLO6OtVHZyap867obl3kpAHCdb6bS3TpHBmI7izYE= X-Received: by 2002:ac8:7d4e:0:b0:4a5:9af6:8f84 with SMTP id d75a77b69052e-4a9fbe8344fmr3522001cf.14.1752232172426; Fri, 11 Jul 2025 04:09:32 -0700 (PDT) MIME-Version: 1.0 References: <20250709105946.4009897-17-tabba@google.com> <20250711095937.22365-1-roypat@amazon.co.uk> In-Reply-To: <20250711095937.22365-1-roypat@amazon.co.uk> From: Fuad Tabba Date: Fri, 11 Jul 2025 12:08:55 +0100 X-Gm-Features: Ac12FXy7m-zlvbmjUHarQqtRk7cRzn7RmdIcZj367UfAD88hqnMBvOGnU1eJgFc Message-ID: Subject: Re: [PATCH v13 16/20] KVM: arm64: Handle guest_memfd-backed guest page faults To: "Roy, Patrick" Cc: "ackerleytng@google.com" , "akpm@linux-foundation.org" , "amoorthy@google.com" , "anup@brainfault.org" , "aou@eecs.berkeley.edu" , "brauner@kernel.org" , "catalin.marinas@arm.com" , "chao.p.peng@linux.intel.com" , "chenhuacai@kernel.org" , "david@redhat.com" , "dmatlack@google.com" , "fvdl@google.com" , "hch@infradead.org" , "hughd@google.com" , "ira.weiny@intel.com" , "isaku.yamahata@gmail.com" , "isaku.yamahata@intel.com" , "james.morse@arm.com" , "jarkko@kernel.org" , "jgg@nvidia.com" , "jhubbard@nvidia.com" , "jthoughton@google.com" , "keirf@google.com" , "kirill.shutemov@linux.intel.com" , "kvm@vger.kernel.org" , "kvmarm@lists.linux.dev" , "liam.merwick@oracle.com" , "linux-arm-msm@vger.kernel.org" , "linux-mm@kvack.org" , "mail@maciej.szmigiero.name" , "maz@kernel.org" , "mic@digikod.net" , "michael.roth@amd.com" , "mpe@ellerman.id.au" , "oliver.upton@linux.dev" , "palmer@dabbelt.com" , "pankaj.gupta@amd.com" , "paul.walmsley@sifive.com" , "pbonzini@redhat.com" , "peterx@redhat.com" , "qperret@google.com" , "quic_cvanscha@quicinc.com" , "quic_eberman@quicinc.com" , "quic_mnalajal@quicinc.com" , "quic_pderrin@quicinc.com" , "quic_pheragu@quicinc.com" , "quic_svaddagi@quicinc.com" , "quic_tsoni@quicinc.com" , "rientjes@google.com" , "seanjc@google.com" , "shuah@kernel.org" , "steven.price@arm.com" , "suzuki.poulose@arm.com" , "vannapurve@google.com" , "vbabka@suse.cz" , "viro@zeniv.linux.org.uk" , "wei.w.wang@intel.com" , "will@kernel.org" , "willy@infradead.org" , "xiaoyao.li@intel.com" , "yilun.xu@intel.com" , "yuzenghui@huawei.com" Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: DEB40140012 X-Rspamd-Server: rspam09 X-Stat-Signature: tte1ifcesi9oyzknpx3xmkyde3i13w7o X-HE-Tag: 1752232173-31652 X-HE-Meta: U2FsdGVkX18rFLG8MhVtuFOGrBobl+AWWz1oVExL1d6dljQPjtdKsoRiqOmC8WgSZkfOTPkAC9zifU420PyxEP1erY6wGoPqMaLdQvKW9RTGwtgZ3ykagDrHBj4+uXCAkxIIkte3c87t7ePGwE3vgkPGO3jA4RvYwJEExIeo6/+40jY+SyNzbCF3SrPMuYAjqTbW/dUM/m3729dXZIPuCYfnM0/U8ptCti0bnf2svWgII0E/KSISbBJT/6hQRB9WoNOTT/qVr2eqoKNSu/6KA6x5woMqAJXqfWO0JFuchT94OJ4rqZOWKqawZ05ohREgowFrjzaVRI2ARh/2/BbjaUmBlFZ3OoXxDihn3zmHUS4xO+poDFMbHKGIFXrcXt0673Qy5IK+IrirZZKz3aFUs2Qv0lpP7iJcXRrEnqIs2aHS7FW4eSJg+td6U9i+SK+0US4Q03ZQQaozXBuz2avnpkrBIErRIjuDZuzLgBMErArRijJXUszA1pXulbYGXGY3EfdWTFmLp9GdyvH7t3gG4faXsIVsJ+Caq0f30gqAewnwDaon9OQHZMbpSrF390YjG8agiWarSqcMEKFF36cpCEcbwz1gSc8IREQN3TS6Fz0iqWnB7tNfnaf7ShWp6RUuhLiEXxdkJW79P12Eh0Fhod+Xde/BdgklXcJPOmCHbkVqVeKuegtUxKhuF8wh/mXkT0fVSnNvaZ+ZVVVCa0+TuPuFtSAES2qoCHHlZc6QhkfLnT45pKWUGaiOS04ZACU6x67nwPxEhMUgqRCNGp1dHR3b524HsJt1CACSreAyfvsAr21TxUh5y1JTdEkGgZ9fCAm1ZcDuIPKD9np5vOvzh67ErQRqIPAUvL6J2gsOTfjsDrvNLlerjZXOW5bE5+x5bD/9iSOD80m92h0wGMRqC2LW/tDMHbQcQxrt4tUXTNUtjRhuulHrDvZF1bwc35FB8iHPtlQfgegzqRF2ShX K4eDQ3fB gCY9AP77Qjh6V/gKT5mq7UA9XfwDl8edKc+2gUlF0nmjp66FoZBev+ZbWpAOA/e7L7KK+OW95qiLnglN5IG8xNNCnkH6YhLCHffnuY4DixYguG6USPAH0LuRArhu8jtvG1/zmaloFycNcYWdGs7uYy5/uSiItt6JkjZyfBoKL51YdLffRGbUTvMUu0a/AH5nPhGFbs/k9Gwg/sl+Z9Er3WRcS5/fokBxH4EkNQjwVm0c8C7/6liGO858fkyxhzKA65yyKLVFaVuUDVg9O1dD5JUlQxBuw18fwcT6TF/KVuIzrEQyxYP5t4MaFt0y8Y8fFFzI4TmBrRtzRFgKS6idHljGmAXPAJMaSacbh364kFSSEIp5DwzjxMCQYmXVGV07R+Dpn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Patrick, On Fri, 11 Jul 2025 at 10:59, Roy, Patrick wrote: > > > Hi Fuad, > > On Wed, 2025-07-09 at 11:59 +0100, Fuad Tabba wrote:> -snip- > > +#define KVM_PGTABLE_WALK_MEMABORT_FLAGS (KVM_PGTABLE_WALK_HANDLE_FAULT | KVM_PGTABLE_WALK_SHARED) > > + > > +static int gmem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, > > + struct kvm_s2_trans *nested, > > + struct kvm_memory_slot *memslot, bool is_perm) > > +{ > > + bool write_fault, exec_fault, writable; > > + enum kvm_pgtable_walk_flags flags = KVM_PGTABLE_WALK_MEMABORT_FLAGS; > > + enum kvm_pgtable_prot prot = KVM_PGTABLE_PROT_R; > > + struct kvm_pgtable *pgt = vcpu->arch.hw_mmu->pgt; > > + struct page *page; > > + struct kvm *kvm = vcpu->kvm; > > + void *memcache; > > + kvm_pfn_t pfn; > > + gfn_t gfn; > > + int ret; > > + > > + ret = prepare_mmu_memcache(vcpu, true, &memcache); > > + if (ret) > > + return ret; > > + > > + if (nested) > > + gfn = kvm_s2_trans_output(nested) >> PAGE_SHIFT; > > + else > > + gfn = fault_ipa >> PAGE_SHIFT; > > + > > + write_fault = kvm_is_write_fault(vcpu); > > + exec_fault = kvm_vcpu_trap_is_exec_fault(vcpu); > > + > > + if (write_fault && exec_fault) { > > + kvm_err("Simultaneous write and execution fault\n"); > > + return -EFAULT; > > + } > > + > > + if (is_perm && !write_fault && !exec_fault) { > > + kvm_err("Unexpected L2 read permission error\n"); > > + return -EFAULT; > > + } > > + > > + ret = kvm_gmem_get_pfn(kvm, memslot, gfn, &pfn, &page, NULL); > > + if (ret) { > > + kvm_prepare_memory_fault_exit(vcpu, fault_ipa, PAGE_SIZE, > > + write_fault, exec_fault, false); > > + return ret; > > + } > > + > > + writable = !(memslot->flags & KVM_MEM_READONLY); > > + > > + if (nested) > > + adjust_nested_fault_perms(nested, &prot, &writable); > > + > > + if (writable) > > + prot |= KVM_PGTABLE_PROT_W; > > + > > + if (exec_fault || > > + (cpus_have_final_cap(ARM64_HAS_CACHE_DIC) && > > + (!nested || kvm_s2_trans_executable(nested)))) > > + prot |= KVM_PGTABLE_PROT_X; > > + > > + kvm_fault_lock(kvm); > > Doesn't this race with gmem invalidations (e.g. fallocate(PUNCH_HOLE))? > E.g. if between kvm_gmem_get_pfn() above and this kvm_fault_lock() a > gmem invalidation occurs, don't we end up with stage-2 page tables > refering to a stale host page? In user_mem_abort() there's the "grab > mmu_invalidate_seq before dropping mmap_lock and check it hasnt changed > after grabbing mmu_lock" which prevents this, but I don't really see an > equivalent here. You're right. I'll add a check for this. Thanks for pointing this out, /fuad > > + ret = KVM_PGT_FN(kvm_pgtable_stage2_map)(pgt, fault_ipa, PAGE_SIZE, > > + __pfn_to_phys(pfn), prot, > > + memcache, flags); > > + kvm_release_faultin_page(kvm, page, !!ret, writable); > > + kvm_fault_unlock(kvm); > > + > > + if (writable && !ret) > > + mark_page_dirty_in_slot(kvm, memslot, gfn); > > + > > + return ret != -EAGAIN ? ret : 0; > > +} > > + > > -snip- > > Best, > Patrick > >