From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46E14C4167B for ; Mon, 6 Nov 2023 16:17:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B03D78E000C; Mon, 6 Nov 2023 11:17:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AB4298E0001; Mon, 6 Nov 2023 11:17:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97B528E000C; Mon, 6 Nov 2023 11:17:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 88DE08E0001 for ; Mon, 6 Nov 2023 11:17:48 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6C011C07F3 for ; Mon, 6 Nov 2023 16:17:48 +0000 (UTC) X-FDA: 81428035416.27.B23128D Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) by imf25.hostedemail.com (Postfix) with ESMTP id 9D4F9A0004 for ; Mon, 6 Nov 2023 16:17:46 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=W8h1VrKj; spf=pass (imf25.hostedemail.com: domain of tabba@google.com designates 209.85.219.46 as permitted sender) smtp.mailfrom=tabba@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699287466; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lUV8zKIdpTV0f8ZMhx633GQ2l+XRSBNMcsvYJoEfTx4=; b=DzP+Jnri34hK3biLHLnAEO4nS0yE2lQ6Ku59rziwG4QA3n46SzHuN33BlTWG8mIfUyYZca ex4Zbr3sIpqrrVNkwj8Y75VwRMD73myYeCK8BHDHsZSXEkXPgsW1EHDbJ1Frj0LQK6XUef wKuM02phJGK6dCody48+MAOfFQT+w5g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699287466; a=rsa-sha256; cv=none; b=aeWSyZ/qwr4JnEiCHLmonT2RTBL+/5Be/f/ppQ4c+np883saficKxvKIdnzmPzEnH8d3DK 3PXMXMRndP65mueVPhocxsD/wnz1PgSg3u3lM7yLZJwYh2w0p9g+GupKklNlb4AYGC+Eqg OWn0qdW8cLM9W2UihV6BXWMKyWEydH8= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=W8h1VrKj; spf=pass (imf25.hostedemail.com: domain of tabba@google.com designates 209.85.219.46 as permitted sender) smtp.mailfrom=tabba@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-66d190a8f87so30187296d6.0 for ; Mon, 06 Nov 2023 08:17:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1699287466; x=1699892266; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lUV8zKIdpTV0f8ZMhx633GQ2l+XRSBNMcsvYJoEfTx4=; b=W8h1VrKjUL6ax8OaBof8zsh5Qccp2SNdjb4IMAEXIIEHyQUybzu+kB/uqIA8ypTzYQ yHvTElAQnWDV4InYoLpViGUOR4rwQfROizy08aUFG+qayvyi2t4WxAUe7vK7tL/t/32J KydKi5HC/tApHM8ka9v1Ed2zKlItE2+yzd1rLK5Bt63mtGi5sZj9QLqZnBQuI2+gdMYl t6CDI1jlIKpDCRnitmgOsHjXVysxRBY2trAlHAm8zsclCgU3+J0vt35l3p8ipN5PXWbG LBuyS4nZIgDUDaofDIjbYBMb+p/H/YuHKstg6R/VF59vyy5fqF8WsYjVrfZAzwTDc+ae /BSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699287466; x=1699892266; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lUV8zKIdpTV0f8ZMhx633GQ2l+XRSBNMcsvYJoEfTx4=; b=gEybUBjSPz2Vr53/iZofT10O/U69aTwQYTRsxSZVizXKL7FoUmETThjejBm8hrZ2NM UXSZLS0S1i8G3TyCq+ibjA6V3bb4ZXomQADq0w8jIw6KZpUCPxDc9tfUfY3r4My/z5FZ dPJ6pYlUndpjwugQgIrCERmqUwXIzLtSvjoTGbvDEI1o3vN/gEMm6GoLPkXravAAg1ja QcNAKJvyrkgaBpICq/dvbmxT3yzVfRM08bu+9pLW8a1booK8SMEBxcTyXaolPAkX2RjW lF0ibBzMAoH0sO8iZIchTKCJpHMeFgTAzKHikcrlN86yeOkDIPcQRVc0TmMf/pRf8uVR TYlg== X-Gm-Message-State: AOJu0Yw55SiwAeE5Azc5C5iYtmnzOQOIv+/LPgboKhGcqHt2cmC6ZuEh 8/nSf8vcifZRlm2m8rZsdFy3n4wWHr+Miy52DFU66A== X-Google-Smtp-Source: AGHT+IFFqaeUa+zb1fqYMH2SBG8qERPcG1V2EKOvlLONFWJF+9JT7SC3ACnaIHdf6fX4zUtKFZJjWCRYHGHhXFDqHvM= X-Received: by 2002:ad4:5c83:0:b0:670:9f8d:f7be with SMTP id o3-20020ad45c83000000b006709f8df7bemr44676404qvh.13.1699287465633; Mon, 06 Nov 2023 08:17:45 -0800 (PST) MIME-Version: 1.0 References: <20231105163040.14904-1-pbonzini@redhat.com> <20231105163040.14904-28-pbonzini@redhat.com> In-Reply-To: From: Fuad Tabba Date: Mon, 6 Nov 2023 16:17:09 +0000 Message-ID: Subject: Re: [PATCH 27/34] KVM: selftests: Introduce VM "shape" to allow tests to specify the VM type To: Sean Christopherson Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A. Shutemov" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 9D4F9A0004 X-Rspam-User: X-Stat-Signature: zpei867zguioiz48xdhxjnspuc8oio73 X-Rspamd-Server: rspam03 X-HE-Tag: 1699287466-998640 X-HE-Meta: U2FsdGVkX1/1gZUMiwa3mv2mVDkb7f//vAm1WQfV48Ojv9K+ThOfxcZfIH0jvnApAmwgcVzTuuEGYul23sV5JW/SOPL1vDA9obWBh0zkSWoj8klG2ZVXWpChbtgPEpi20hPrTSBfhwAM7BG3gnKMzwOu0Rqg5+/J2x1NQ7k+CRZUpZHgFK4SwWc3Lc9YMG3ciatVQDilvByMYxET4DaZTDzY6nggguCG0CuVH66g1A5nw+mDOounkUb42IIdCETnra/Kf/h/H/jhAEWhKmJcGHWt+fGZpbF8wfVqHgBHqeVEkjogNKtGK6WkTNajVmvdy7dawmrGljo23pY2jkWnNn+9GtjtTTPk1WiaSKBNABA0vMf7xEua2h3paU/48uuNanqktbBjf5e71QvSd0cjU3QDK7mgJMDqC/ocRbYXtG+1zvpVAJUD8jVtp+k6p3MaCb/NPwLxwFGG4aKM0bGuV5MJw2msDwLGXVURzoUwhmt9Z2Zvj8xRXk51T2V48npfyMElRRg6OhwKEqbe9A5EU5FNtOkO0o72PZhvVJeTVnqU49S4FbX7GVir48ax3xe1h7Jz1eIWYm4HGGZduWY8op2NGaGIoHmgkBmeRAJFvKXPtK6PT9bWtGzhOBKRmkISRSV2yXVqChO+KlMQiSB8PNIzWurwFtq2XhEp+NpLVfMMn9x8k+Hm50A5r7U8dei/jAidbCZoVKLqqLcVuXXHN43hLhuMwRfBEf4VXXMwWLxipn1UWEECj+GQHrzcXPHsih+sJcWcbMhUldubCKRy0FFaL81vJsQnjIJ0NSRvaLKUl4lxYQxBqsm84BJf/AzuU+TqatV0316EbZnfX7Z8IUpa1NhWT7nQ4NpHXapMheq1JYxAxeMY1xB6BJeeTwKLIKBfi1R59cuh5R9g9mZUWg4m9qqFqOHr6CAnwFK+48GE638ctbEhs8x2borxJvoNWDW3+xMH/8NX80n5qiw W/UXxevQ 7lxWC912tvKsojZOwRBCQLUAreXOaXYznUTgkvY7zEx8gjSG3I3I5O//xDWBHpLHwgt1RqBuzG6yTyDMCCah5dpveUxSeO4tEx0VC4iUjLjb8ULVUPIN2UAvXTT4NA2y1cP4Xwz2kZ9OBjFfHT0LIyzwFemtJ1+bGCqNVnwZLxonG1Ipyn16SriulfBw1uaH7dlmc539Gpiq2XVocOmyQRFMIOc1iuRcnduel93NQd66tWCVGOekTgl25DMDZ0OvvZhmzkqgXTj6/KezJblAZgeIuv2KKKAonJq4vVlbJgE+50EddAeShfqSCFsDYS0AvpWcu+HUL779j7P0E0ZSKnlOSIg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000029, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 6, 2023 at 4:04=E2=80=AFPM Sean Christopherson wrote: > > On Mon, Nov 06, 2023, Fuad Tabba wrote: > > On Sun, Nov 5, 2023 at 4:34=E2=80=AFPM Paolo Bonzini wrote: > > > > > > From: Sean Christopherson > > > > > > Add a "vm_shape" structure to encapsulate the selftests-defined "mode= ", > > > along with the KVM-defined "type" for use when creating a new VM. "m= ode" > > > tracks physical and virtual address properties, as well as the prefer= red > > > backing memory type, while "type" corresponds to the VM type. > > > > > > Taking the VM type will allow adding tests for KVM_CREATE_GUEST_MEMFD= , > > > a.k.a. guest private memory, without needing an entirely separate set= of > > > helpers. Guest private memory is effectively usable only by confiden= tial > > > VM types, and it's expected that x86 will double down and require uni= que > > > VM types for TDX and SNP guests. > > > > > > Signed-off-by: Sean Christopherson > > > Message-Id: <20231027182217.3615211-30-seanjc@google.com> > > > Signed-off-by: Paolo Bonzini > > > --- > > > > nit: as in a prior selftest commit messages, references in the commit > > message to guest _private_ memory. Should these be changed to just > > guest memory? > > Hmm, no, "private" is mostly appropriate here. At this point in time, on= ly x86 > supports KVM_CREATE_GUEST_MEMFD, and x86 only supports it for private mem= ory. > And the purpose of letting x86 selftests specify KVM_X86_SW_PROTECTED_VM,= i.e. > the reason this patch exists, is purely to get private memory. > > Maybe tweak the second paragraph to this? > > Taking the VM type will allow adding tests for KVM_CREATE_GUEST_MEMFD > without needing an entirely separate set of helpers. At this time, > guest_memfd is effectively usable only by confidential VM types in the > form of guest private memory, and it's expected that x86 will double down > and require unique VM types for TDX and SNP guests. sgtm /fuad