From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1D39C52D6F for ; Wed, 21 Aug 2024 13:59:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 662CD6B011C; Wed, 21 Aug 2024 09:59:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E8F26B0124; Wed, 21 Aug 2024 09:59:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43E2F6B0125; Wed, 21 Aug 2024 09:59:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 217CA6B011C for ; Wed, 21 Aug 2024 09:59:28 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C8968A59B7 for ; Wed, 21 Aug 2024 13:59:27 +0000 (UTC) X-FDA: 82476409974.29.4871870 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by imf14.hostedemail.com (Postfix) with ESMTP id 123F610002F for ; Wed, 21 Aug 2024 13:59:25 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=lxRlqxNs; spf=pass (imf14.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724248659; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nxst5TEEm5z8iUl+TEBEPrc5FH7ZeLnW1hV84NEgvl0=; b=AzbU6qXaXYJnBZ6QCbsHKz+2G+y3gCjSt5LGrjEv327kVmlZ7SzgSnAuySt0oeQr8YUUcd BPA6uq2z7ZRULp//RRAiK2ocl9dvyvPfutfIHojJz0r4o8V567o3YMyhzn8bxRmfKWBDfm BWMJzn0n3mTUb/2rkUtUh8MBjC/vuKY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=lxRlqxNs; spf=pass (imf14.hostedemail.com: domain of jackmanb@google.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=jackmanb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724248659; a=rsa-sha256; cv=none; b=RgbvG5Qpw1UQ2y//ax37HeuD4HeUcAn4d8OV0qNMSu8Bmaa4RkKX3KpGS8P5gpRWtKes4o rWA/9WnodgKmQfUAZ6ZwdaMIYOs4jPi4qYMtuurMMv0isPsPJk8YwRfsBeWxP3Ou2DAU8A Pjy1lxFuSPjHlDweIPhWPL9HDK5ACUk= Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-45029af1408so241321cf.1 for ; Wed, 21 Aug 2024 06:59:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1724248765; x=1724853565; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Nxst5TEEm5z8iUl+TEBEPrc5FH7ZeLnW1hV84NEgvl0=; b=lxRlqxNs9XXyBGEL/U+zwzy14XGNvGE89W13ax6lg6RRBbTe4yB4o2BNSeiNFLYTab lAkRSZZ+L3Vm1FrGieZYfOaWnckP6LEd/zP+wugUbZo22HHh4aUBm95DMpgAmsmABwOQ fhilcQBh3KC4ilnZArj9Rh9jTo/gRrEcdctYTs3Gc0lPb4fbCipfHIy0a3/iZrkmctUV XhDDp4wMT4l9vrm6N3FEdptNXd+rS/L9RZOHz8JEe66qr4US1eXlvJMV9GAypis26ZFY YXdn2IQw0rlaggKAeI3mwHC4p6H2vWxTAhj4HYi9DbOukhzteNwTcZ0x8q3ypMw6Rnhq zmJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724248765; x=1724853565; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Nxst5TEEm5z8iUl+TEBEPrc5FH7ZeLnW1hV84NEgvl0=; b=UE1lVcv8cZvKDzHoUZPuHv6S1Ot0Pejir2xgYEH+rOYm6fFOIiHPPaxmUQRiVjR49E AdIWWt/q98QxjF/1ShGeBMjwPWtW3D4AUazOXIdWt9Z1Ubf/al7tJbGFxeUbAGKoYT8D 4uFYwyfq28ZWnYwZA4eGEeR324QarB9N8TmgASgz0aaWwTlSpmvQm9ZZPUwgP8beifIH pkzcskfltHBv957WaJr+3uq93M9OoWGZaCG33nLY+ly0XuIR77NZh2rhXgvRrH9WbtEa jeMo/1EPxF6/EFb8oDb/xUWrWK6eFb7SLfhtCkeNJGsfc5ysgFBsjhyjZ384Q2gpREIE MHfQ== X-Forwarded-Encrypted: i=1; AJvYcCWjGqfWIZ/aakUj2eepLuhUpMb+Br2UW+9QXdjAU34k0+uVUJN5gre4+JaV/G0uaUdRIehqOPJa7A==@kvack.org X-Gm-Message-State: AOJu0YwXorpwLNA4pzcOJd1CTsyluMHTaFrgIaZGLCqCUJNCzTmSfkEC hkcnW9i0C7Fs8qiskhY/OuM6ZLI4/3l6ILTlLv3vUGXZfW/CuYmePycUUel/nYO39vg52i8py9B e44pf5kLQZ/HbehusQHlxpvbi9DR5nYP6L37F X-Google-Smtp-Source: AGHT+IHaKAKAmTQrt0rYQ98cgg8gxXsJZuuysW+sK0/lYbbTiqQOpt7PedEDzP9OP5rgPDX4GKwW7os42UuaOOU5wak= X-Received: by 2002:a05:622a:5b8b:b0:447:e8bd:2fbe with SMTP id d75a77b69052e-454e8530e2bmr6047001cf.1.1724248764541; Wed, 21 Aug 2024 06:59:24 -0700 (PDT) MIME-Version: 1.0 References: <20240712-asi-rfc-24-v1-0-144b319a40d8@google.com> <20240712-asi-rfc-24-v1-16-144b319a40d8@google.com> In-Reply-To: <20240712-asi-rfc-24-v1-16-144b319a40d8@google.com> From: Brendan Jackman Date: Wed, 21 Aug 2024 15:59:11 +0200 Message-ID: Subject: Re: [PATCH 16/26] mm: asi: Map non-user buddy allocations as nonsensitive To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Sean Christopherson , Paolo Bonzini , Alexandre Chartre , Jan Setje-Eilers , Catalin Marinas , Will Deacon , Mark Rutland , Andrew Morton , Mel Gorman , Lorenzo Stoakes , David Hildenbrand , Vlastimil Babka , Michal Hocko , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Valentin Schneider , Paul Turner , Reiji Watanabe , Junaid Shahid , Ofir Weisse , Yosry Ahmed , Patrick Bellasi , KP Singh , Alexandra Sandulescu , Matteo Rizzo , Jann Horn Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 123F610002F X-Stat-Signature: q4y3abmqkz7e3hgndk3h5q8n1fhjdwzf X-Rspam-User: X-HE-Tag: 1724248765-746759 X-HE-Meta: U2FsdGVkX1+RsMqR6YRJffAsgfjMGpgDGNt6piRptZDaS449wX6CI172X+00mB+vC1qdLiPF4YIs6SJ/iqhB4fJmz4gqp9bouU7QWsdvvpKTg6gM/RlMt4xvg0naBTQFykLQW+7C0BqMReVZgnDg0shJezeHfTjcalEQ7+ww8pgsrdFVedO2ArsR+ZxHygEQmXbdR8s48C5CC6fC9QGDte1Pvq1p76lEQHjIrc+USnNg6nD4FEQfVDqYuLwdTfjRGnnZDvMzBAYBbEbU/yssR+RsaTnbbVkyeEwbadfKBxL7RzBXDuD7Hx8M+VDHbNEpgxct3aC3hxcW1vZp+OnnRXm4Sl+0iWpjJa62JoTM//zaf9KKDoomMECLKx1/bcDUaWK7zaVtlW5IEgMbuJLEZY/8zbfBP9u4KSO5XSTGki0QlkHtEBzSZtGcFk5zWKQZPiVpmtKLq+3xaoXrAqedwrd+NJL4t9fuvrVQKQ9Dr7RL6noPH5rHDoenUPR4IL4vxGjK2grNpfXIcLkX+vcgtfDdMRoh1V3K/JEIa8F4seXkK3pBbiBKkUpID7RUHmTEzCR335TjBOukgdv62+2e1YS2tshifAS4InORkcsgk4Tfnlv5ZEo4VMRufkoH2B5MRbiGkoufmMUeUXelJewGu7isxdZxZcGPpwDXGvWbygd2p/sfwYZ3CQT9cdH8yY+5KG0CPEDwNgHwNzjxtxQerIkpeYXO/gtcNCihcWaocxcpi3zqd0+T7fU//vw+n1lccu2o7MVZGzXg0SUkPh5LbEREdV8FnfPV5osQPB66ZL8gSvm1zii64nKqcQs2IkiCimIZ2es8mtzEPRiHnGmH3iHMfVFDoAuhKM4E4/vhlhkpXfuFfVBQ9nZ6ET52zVAngC9I8ONCwJZA5zX4tfPmyrHRGJ67FCxL2Syr5t35NZW8nWblABruOOew7UbT61xr+WBKDUkzM+xs1dMK+wB ElsWsEUK Wj/dhYaKl9tDH0onXdaAmehPAp4vKzglAl1YO91JwKLrsnVEC0aDqYR+DzN5i5r9niusw/ULkdyx7tYC7hH+sHwVX5Z04Y8b9F1RErPaF0vMWC1HXsTyB6RFLzNJ7IPxhOClYVlCEtMdZTWz869a9YMf1XpIbK9F5onChzgxqv07kHzw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > This solution is silly for at least the following reasons: > > - If the async queue gets long, we'll run out of allocatable memory. > - We don't batch the TLB flushing or worker wakeups at all. > - We drop FPI flags and skip the pcplists. While fiddling with this code I just noticed that, in my enthusiasm for stripping the logic to the bare functional minimum, I went overboard and totally removed the logic to wake up the kworker. Anyway, this patch is stupid regardless for the reasons above, but just noting this down in case anyone does read it and wonder how it can possibly work. It just leaks memory. If anyone wants to try out this RFC and needs their system to stay alive for a while, let me know and I'll prepare a branch with this issue fixed.