From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BA8CC8303C for ; Fri, 11 Jul 2025 05:19:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AD2E6B0093; Fri, 11 Jul 2025 01:19:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 485436B0095; Fri, 11 Jul 2025 01:19:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39B096B0098; Fri, 11 Jul 2025 01:19:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 29EE06B0093 for ; Fri, 11 Jul 2025 01:19:54 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3E46712F727 for ; Fri, 11 Jul 2025 05:19:52 +0000 (UTC) X-FDA: 83650831824.27.240C831 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id EFAEC180009 for ; Fri, 11 Jul 2025 05:19:49 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PxVf1y+H; spf=pass (imf06.hostedemail.com: domain of npache@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=npache@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752211190; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r6vIHjG+X+ooer0kPEbKBb824B/b+sl4l3mrZB9ZZto=; b=X3w8ofzQQkMZo/GFdTQoE1b8qCdta8CtiMEld23ijetc50TmfFKOVaFIeGIYzhNucFMvfQ ZIglbE/qddqjTHvzPD4y57qQkXLP3tewNxuwVlNA86oEVjIfoYvSILwQGMOq8iLsQPWM4G ogfJkaDP0o6Rde5rBFIfiNMV4nYgyes= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PxVf1y+H; spf=pass (imf06.hostedemail.com: domain of npache@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=npache@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752211190; a=rsa-sha256; cv=none; b=NA/w+ABhADZBoo7Bn5zS8d6z/crcSavAURnhWVEi+s1JIv5JRSznmfpuX6YURc2XWL2o0t dysWeGfhCwfK55IOUyFW8+u2e2vH5zwjRXh0aWwtjG3t3FoWd+EH1ijkyxXdeNDR9VQwa3 oxzUZ7k/FM+HrdTv5JvmPT+YKIxUoxs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752211189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r6vIHjG+X+ooer0kPEbKBb824B/b+sl4l3mrZB9ZZto=; b=PxVf1y+H08LxavdEGBnr1ko0JGGCrIqYS1sjYN4vcTCvpbQWtveGZAsY36CEIY5DHwDAVF ifnwP9YQNqyZXvUWdhYUCZkK+WuiLqPK+xbrfNcZTADjJZvoJUWJpBMKsxtrkEU04wzyXJ ld4MjEfmryGA7XUu5r3HF5031SW2rsA= Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-66-r60aHnyxO7emtnibl3x_mg-1; Fri, 11 Jul 2025 01:19:47 -0400 X-MC-Unique: r60aHnyxO7emtnibl3x_mg-1 X-Mimecast-MFC-AGG-ID: r60aHnyxO7emtnibl3x_mg_1752211187 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-711136ed77fso25502137b3.0 for ; Thu, 10 Jul 2025 22:19:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752211187; x=1752815987; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r6vIHjG+X+ooer0kPEbKBb824B/b+sl4l3mrZB9ZZto=; b=FIUuP3yDDccusOmjq+cqZRH1XEzcf+3yPGyFan4IsMNfx3k1eJSwG15MZsE8wra5qS GQfuEmGTY7PQVxMC7wNZXzQmp3MNJ/TjPcf8flKXgtWZj8WHxgIdK0bWMR0iAfWqmJJa mHAOhfpRwF3Mf9IcjSdbIFp9cJUvEvMS9iOAvKzzNoYAgmXBbl/XpcnuUAT1sbvSVtK4 qcCn71v/lFC056w4udNJ+u07a9onRD0Xwb9hpnm2OhDs2tgXIMrGYS5dRdTMvNH9/aWb G8M9Fw5hI+nNQqTuykZhDODgyiERUm/4ZUygcUhN7FgaV5VihLxDpsYvkYIMafDzY+y+ 5SLg== X-Gm-Message-State: AOJu0YwwrK17IKX0u9dnZJ3oa9afw4zv9iDOkussXXmT0UGGSHKQX1jM DtsNFWyy6yvOe0aljxmQMdZKKVECIh2rFhEUnVbGXfjbQq4gIE4ctif3o1nI8Um/L/Ecdr3oO+f hx1Jd2O989xjBUP/1HwqiUlYKPcH2HVXUtaLnyHlVYiXZDgGpAf4KiXdap+LQsXvlk8MbygBmpK Mks4BL8+iUYyl9MFB1rH8SOErr1IY= X-Gm-Gg: ASbGnctzsVdOt7m0U9Ti8OVKZLhh0oXyYsUz7rqgPUtf9qTRJWXZ1ZVNfWi0WcWAbZ9 U5EXC8nJo3ZFP94DKEJSociZgXenAt9xL5d7BXqIJosZPPEaZxnaW6hmRaRH7kfiyPa0x5+I5MQ y2QTAnuOCtU5ZK11y1V/Dg8XY= X-Received: by 2002:a05:690c:3708:b0:6fb:9280:5bf4 with SMTP id 00721157ae682-717d7a60360mr30287237b3.30.1752211187016; Thu, 10 Jul 2025 22:19:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGcWVC3GcSeJkTDnF3C9rnrmpzpkOrmkTr88hOUgI4ozfXlLJUBFIOZ+k63jCty+yYVBl88zRUE6c3Ln7c+0to= X-Received: by 2002:a05:690c:3708:b0:6fb:9280:5bf4 with SMTP id 00721157ae682-717d7a60360mr30286697b3.30.1752211186572; Thu, 10 Jul 2025 22:19:46 -0700 (PDT) MIME-Version: 1.0 References: <20250702055742.102808-1-npache@redhat.com> <20250702055742.102808-15-npache@redhat.com> <342d5fe1-cd39-462c-b2a4-b5d6979a8a21@linux.alibaba.com> In-Reply-To: <342d5fe1-cd39-462c-b2a4-b5d6979a8a21@linux.alibaba.com> From: Nico Pache Date: Thu, 10 Jul 2025 23:19:20 -0600 X-Gm-Features: Ac12FXyWnkdFgO0eSnxKkRQ5LAIk8ZEY6SDq1ck6We4zFjeQk_isSPFYEbCbMbo Message-ID: Subject: Re: [PATCH v8 14/15] khugepaged: add per-order mTHP khugepaged stats To: Baolin Wang Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, david@redhat.com, ziy@nvidia.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, ryan.roberts@arm.com, dev.jain@arm.com, corbet@lwn.net, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, akpm@linux-foundation.org, baohua@kernel.org, willy@infradead.org, peterx@redhat.com, wangkefeng.wang@huawei.com, usamaarif642@gmail.com, sunnanyong@huawei.com, vishal.moola@gmail.com, thomas.hellstrom@linux.intel.com, yang@os.amperecomputing.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, raquini@redhat.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, tiwai@suse.de, will@kernel.org, dave.hansen@linux.intel.com, jack@suse.cz, cl@gentwo.org, jglisse@google.com, surenb@google.com, zokeefe@google.com, hannes@cmpxchg.org, rientjes@google.com, mhocko@suse.com, rdunlap@infradead.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Yin1t_TGjwMWo8DSdcTaq0iGRSETaV37mjbqDFmj5ZU_1752211187 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: EFAEC180009 X-Rspamd-Server: rspam09 X-Stat-Signature: 5ba9u9cjudey4r8mimez8gs6ygwwpbdo X-HE-Tag: 1752211189-249098 X-HE-Meta: U2FsdGVkX18wen+eN5HPjExP+rHLr0FsCSiDqSUEKPsJITMM+u055uT0aI1rD4lvnh8dnxTvqDyLF8a5HKK0I6btFKGp+R5JA5fR4mUpAn7YtW5Vso1YIgiVJRALjJ/K3Hy1pfyVZjTlg8OFgZ1iD7nHDsIWO2e50K17XBJkgWUaGt5ioDj5zG7GiSf9vb4vEN4OsNx7tjd2YiXs3oUnISGtSC6gLjWx5N3B5iuKElIaCkEo7oJNV8DWzZEWlRU9P/WG9QkXSQ+CMmPf5nPyAL8r8zzTMJc4ynaKJO0AGrvKt4zdXGXASfaFJuMhoMBzMqvQ/yMdrYn0tqcoKzGqvaC5JpyQ8EOT8Pk5lqYZXQMqAlRDMh4J2f28nuH7JvuXTJUT8RGuagaIundtIUorhhzseGIoiOF2jGq9+VW0QgXqI90njwBCrIwFFwPeWRDshcHaeXyA530rbgy/Ku+AmK1BSJp7AEmLU03VVdPZvNUXvphRCCEiXuzBHIcKF9X6G+uoslzyeZJCRXhsE1iHR2EEQGPjoS9y0TESAJ7Y0a9QX0FloPoquYMGZTsv5FK+EL/0bNCi5vNMHM+S4qd5THR7uLZs13VONnvUIiM76VktXbcpAvwVtFv/Wsm+N7I8lrlqlO/EREZHDZNJSy6amP60f1VfbBpJJBe4XwWGyWM+tAJsdCtVWgIWnWclRtxMje4nH+7Ta82ko3n53j89Tn7cA3QSZHN/DpE5BbcpEIO/7M8d5feOlBvvnbsIvrlsrFazgX0WvF6KGwfuh3y2w5NWh+oL9L4tBOAwHVUlKGCOr9Pm7tBKvz+1SXkEOQFQMictleZRHNz1FBW6Ej8B/vs5ci6GnzBvCBHHMfBm5ADGf6JoIL5ptt/RHC/++HS5z7WLyNtbqyxiZuhIxpl3e/P7y5pLKcPqGKYqDUDGC2Ixucq0PjjVlHUT/y1nvPqhRt07gNgQm8KLEOptpET Um44vmil flQZWflLyargNdFkjGu2LduV7id768mHrm9lfqnqQHuLXjCqvVtPfE3wH3KmZyE4Biq77toKj/px3ijVblxxkjhDceMaRq8wAkUY6EvMHqqOoVuBTMvi9L8YMDKipXnZEThPlhuPcTAS8Ii6IatI6H4lCq04/vSYQDYL2OGUqrL6duPn3McuxD9dgUrZP9vW4AvMYwG9Ye3LlwlCCWcueZaZcWmKnx3AuBW9mLQXxwfgHLS4DuH+3Pw/98w0/AmfRGgsX1GH2mGwzGepslgX5bQoZ4hBqGCbUsGq56Y0ad9nDO+IARbKuCU0Q6QYDKLXSRx9oedbDioE8YFjwXkICSf05JbehF2qv32nSQwkVseZUJzWjUbY19lN1mDHuhsiHH7k3gMmrJi1+InzUADUWjbis3w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 8, 2025 at 12:10=E2=80=AFAM Baolin Wang wrote: > > > > On 2025/7/2 13:57, Nico Pache wrote: > > With mTHP support inplace, let add the per-order mTHP stats for > > exceeding NONE, SWAP, and SHARED. > > > > Signed-off-by: Nico Pache > > --- > > include/linux/huge_mm.h | 3 +++ > > mm/huge_memory.c | 7 +++++++ > > mm/khugepaged.c | 15 ++++++++++++--- > > 3 files changed, 22 insertions(+), 3 deletions(-) > > > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > > index a6ea89fdaee6..6034b4c9dae5 100644 > > --- a/include/linux/huge_mm.h > > +++ b/include/linux/huge_mm.h > > @@ -141,6 +141,9 @@ enum mthp_stat_item { > > MTHP_STAT_SPLIT_DEFERRED, > > MTHP_STAT_NR_ANON, > > MTHP_STAT_NR_ANON_PARTIALLY_MAPPED, > > + MTHP_STAT_COLLAPSE_EXCEED_SWAP, > > This stat seems never used. Ah good catch, I somehow dropped that piece on the V5->v6/7 > > > + MTHP_STAT_COLLAPSE_EXCEED_NONE, > > + MTHP_STAT_COLLAPSE_EXCEED_SHARED, > > __MTHP_STAT_COUNT > > }; > > Please also update the 'Documentation/admin-guide/mm/transhuge.rst' for > these new statistics. Will do thanks :) > > > > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > > index 69777a35e722..3eb1c34be601 100644 > > --- a/mm/huge_memory.c > > +++ b/mm/huge_memory.c > > @@ -632,6 +632,10 @@ DEFINE_MTHP_STAT_ATTR(split_failed, MTHP_STAT_SPLI= T_FAILED); > > DEFINE_MTHP_STAT_ATTR(split_deferred, MTHP_STAT_SPLIT_DEFERRED); > > DEFINE_MTHP_STAT_ATTR(nr_anon, MTHP_STAT_NR_ANON); > > DEFINE_MTHP_STAT_ATTR(nr_anon_partially_mapped, MTHP_STAT_NR_ANON_PAR= TIALLY_MAPPED); > > +DEFINE_MTHP_STAT_ATTR(collapse_exceed_swap_pte, MTHP_STAT_COLLAPSE_EXC= EED_SWAP); > > +DEFINE_MTHP_STAT_ATTR(collapse_exceed_none_pte, MTHP_STAT_COLLAPSE_EXC= EED_NONE); > > +DEFINE_MTHP_STAT_ATTR(collapse_exceed_shared_pte, MTHP_STAT_COLLAPSE_E= XCEED_SHARED); > > + > > > > static struct attribute *anon_stats_attrs[] =3D { > > &anon_fault_alloc_attr.attr, > > @@ -648,6 +652,9 @@ static struct attribute *anon_stats_attrs[] =3D { > > &split_deferred_attr.attr, > > &nr_anon_attr.attr, > > &nr_anon_partially_mapped_attr.attr, > > + &collapse_exceed_swap_pte_attr.attr, > > + &collapse_exceed_none_pte_attr.attr, > > + &collapse_exceed_shared_pte_attr.attr, > > NULL, > > }; > > > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > > index 2c0962637c34..636b84bf1ca1 100644 > > --- a/mm/khugepaged.c > > +++ b/mm/khugepaged.c > > @@ -594,7 +594,10 @@ static int __collapse_huge_page_isolate(struct vm_= area_struct *vma, > > continue; > > } else { > > result =3D SCAN_EXCEED_NONE_PTE; > > - count_vm_event(THP_SCAN_EXCEED_NONE_PTE); > > + if (order =3D=3D HPAGE_PMD_ORDER) > > + count_vm_event(THP_SCAN_EXCEED_NO= NE_PTE); > > + else > > + count_mthp_stat(order, MTHP_STAT_= COLLAPSE_EXCEED_NONE); > > goto out; > > } > > } > > @@ -623,8 +626,14 @@ static int __collapse_huge_page_isolate(struct vm_= area_struct *vma, > > /* See khugepaged_scan_pmd(). */ > > if (folio_maybe_mapped_shared(folio)) { > > ++shared; > > - if (order !=3D HPAGE_PMD_ORDER || (cc->is_khugepa= ged && > > - shared > khugepaged_max_ptes_shared)) { > > + if (order !=3D HPAGE_PMD_ORDER) { > > + result =3D SCAN_EXCEED_SHARED_PTE; > > + count_mthp_stat(order, MTHP_STAT_COLLAPSE= _EXCEED_SHARED); > > + goto out; > > + } > > + > > + if (cc->is_khugepaged && > > + shared > khugepaged_max_ptes_shared) { > > result =3D SCAN_EXCEED_SHARED_PTE; > > count_vm_event(THP_SCAN_EXCEED_SHARED_PTE= ); > > goto out; >