From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14EA8C83F1A for ; Thu, 17 Jul 2025 07:26:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8EBD46B008C; Thu, 17 Jul 2025 03:26:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 89C2F6B00A9; Thu, 17 Jul 2025 03:26:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B2A66B00AE; Thu, 17 Jul 2025 03:26:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 689FF6B008C for ; Thu, 17 Jul 2025 03:26:09 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AF71580639 for ; Thu, 17 Jul 2025 07:26:08 +0000 (UTC) X-FDA: 83672922816.22.235B997 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 8D0F340006 for ; Thu, 17 Jul 2025 07:26:06 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ByLpXDJS; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of npache@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=npache@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752737166; a=rsa-sha256; cv=none; b=6t1KYvJmV1hCaciipHcx3OBh6jx0lrBoMvOStFsq+3Za307KkKsOgKgchS1mEkIdeCgtQK C61K+eObjv5MaCwf9Iz5jwm2BjpCrEKxPU5X4SgPsX6RHIQ/nSjs8viiCgzBuydCsX4+8F F7UcDuvd87r1TK++y0G86w4FKb+fggM= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ByLpXDJS; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of npache@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=npache@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752737166; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vo8FQNXlen0UXALTqIXl1cj0LOauGoMS19U6EAESdmQ=; b=Z7aMP61bzSXPpGWTbNfQx6A3Xf+lNOIqlj6ERHbSZou7WrFQRFNikhc4Sx0a6uH8MQHdsv zLDjtrL3WgHOdgtTDlb0WFVP6VRMK6dFJ2UfaB1+JjMGkLsor+ICnOFVJ338J8xeXWKvCG Uo8fT95xO/UF4S+31fa1i9K819uwVRY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752737165; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vo8FQNXlen0UXALTqIXl1cj0LOauGoMS19U6EAESdmQ=; b=ByLpXDJSmDn5XmlWc6h6F0jsDX8VPHK/BBwl6Zf3Uky6Eomlt+v8E5D0139qFplvV38+Qj mWNbr0vVKsmZuEF0yBLrj6C358ZYydVnwLF6MHk0bYJLB9GhOFjrmTovpOALwxyUpC6OR+ cFVg7v/3qR51yFCqjIGegQ3oa1AVLIk= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-v3JvqP0aOXmN4p3MXTCLrA-1; Thu, 17 Jul 2025 03:26:04 -0400 X-MC-Unique: v3JvqP0aOXmN4p3MXTCLrA-1 X-Mimecast-MFC-AGG-ID: v3JvqP0aOXmN4p3MXTCLrA_1752737164 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-70e4269de4fso8530407b3.0 for ; Thu, 17 Jul 2025 00:26:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752737164; x=1753341964; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vo8FQNXlen0UXALTqIXl1cj0LOauGoMS19U6EAESdmQ=; b=b3FE5j+zpTbfVvf2qXZAry1w+fNk6+E7FD1DekdUSS+wcLOaQZcxD2l8KYIhA87GrQ fKvjbBUo8QNrc40FiwliC14SVToUvH3eQ1j7+OUu8eQcj7zdimDbQHVwjIfuEK6v+O8A 3XIK6nCxSV1LDD3uxUmF9fehT1798VeexdMP/CHPKrPthGJrcarvldD+k1bjxKX9eGTy MvDaQX8sqZ+1Uouowjn1y0jYs5bxOZAoVubGow22d4zX2WwGCjx5Otuq5BPq/1HHP7Jr Lu77uxrfG/1jtCAKSmhjQRDY2qn9mRh1XmAcT7cVjt1jVcV0dRQN47DCbN+Vgr3RzIbj g6kQ== X-Gm-Message-State: AOJu0YwITtIQ/ZJHRX1+lfceDwoPrxK6razwyn48sGOXcioUGJaf68Og pwr/OZ0VTyJSMWnbW7om54L32WX2fk/rAT+iuzxwr1/zK4YoDHIZnIrAFiobuN9ixkdKq2I9Flx Yr+sP0DOvVxraZ/WV1Ku3zn8+dWhSB5k2dz+0NfcNaNhL5U5fWqXbSslybJxn2WQibmm0l92VyO h/E3d/uiBUX7NqgV/Wy7pJMV3fcXA= X-Gm-Gg: ASbGncuhLEDfqWIxFYHjZtw9MjaCh1HaSrcwpL1N79XmtYK1W0AJfoXK7eF2avlitIc h85ZE2NK4EiRrSWrgXl1fcBFlgzNAzMmnurXmY5AN4xSANam2d4t9KVnIM6mNjbE50HudxJRNJn o5Oj3IqBaSFaGkNzoo9msX0Cw= X-Received: by 2002:a05:690c:6993:b0:70a:192d:122 with SMTP id 00721157ae682-71835178d52mr82694407b3.30.1752737164056; Thu, 17 Jul 2025 00:26:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEMubBvQQAjL8j5OHlbNU/B1QBy1oxiKdyesMx8UucD2RpbZUXxzqn8VGYgbNvQhuy4s6xzfb4MYtoJBUi03NM= X-Received: by 2002:a05:690c:6993:b0:70a:192d:122 with SMTP id 00721157ae682-71835178d52mr82693867b3.30.1752737163491; Thu, 17 Jul 2025 00:26:03 -0700 (PDT) MIME-Version: 1.0 References: <20250714003207.113275-1-npache@redhat.com> <20250714003207.113275-11-npache@redhat.com> <3b8d32dd-9d40-44b1-a0ab-8185073b9072@redhat.com> In-Reply-To: <3b8d32dd-9d40-44b1-a0ab-8185073b9072@redhat.com> From: Nico Pache Date: Thu, 17 Jul 2025 01:25:37 -0600 X-Gm-Features: Ac12FXzO2MpdN8Y0fWlVobBSI1-4HfFow54FOutJLg2yUFGIlRLNPwUMo-JRrD0 Message-ID: Subject: Re: [PATCH v9 10/14] khugepaged: allow khugepaged to check all anonymous mTHP orders To: David Hildenbrand Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, ryan.roberts@arm.com, dev.jain@arm.com, corbet@lwn.net, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, akpm@linux-foundation.org, baohua@kernel.org, willy@infradead.org, peterx@redhat.com, wangkefeng.wang@huawei.com, usamaarif642@gmail.com, sunnanyong@huawei.com, vishal.moola@gmail.com, thomas.hellstrom@linux.intel.com, yang@os.amperecomputing.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, raquini@redhat.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, tiwai@suse.de, will@kernel.org, dave.hansen@linux.intel.com, jack@suse.cz, cl@gentwo.org, jglisse@google.com, surenb@google.com, zokeefe@google.com, hannes@cmpxchg.org, rientjes@google.com, mhocko@suse.com, rdunlap@infradead.org, hughd@google.com X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: U2cElYRkknJawGX0v-eGYFf8q7PhfsNmFNhkIu0YWmo_1752737164 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8D0F340006 X-Stat-Signature: x94bomketkqz49m4qq3xddadmb83pffc X-HE-Tag: 1752737166-282334 X-HE-Meta: U2FsdGVkX19B3D+OYFcvIm4h85eW+lj6vRuXyGAi3Vrn8zPvpy28F1S4sZHd1kdEHAMCsYrV6b0l/m7g4yAwcIqtSv8ziHTex+9RUbcYEbOdbuCugwa+A13AKMHqtnhyTbbCLdDMYUad15OcdgYDIOemvHX0qBIp6qXKHzwzs2KHgxJEkCEQ+U+cdl7bHjLrcR97zyk0jr42q1QN+kbCi/lZW6VndoyAhMJgsn6ENxDhJ8iOH+NJ1X5rn1VWffNe+tDO4EQla6sWkCLb0DoSQjcXHj5j54Z2TcH/DOVWWv+5JoOGBRe7KNi6gGmsOlLzuQevK5ZXmupm3Ok5t0s48cEoUUW/DwmAMdd2K/TFy8GyH4u+YUenai6ZMkyM9UptHb518ziM4n0KQHfYrT8CxByBmnJBw+NuJkLyTHDpKOnT6vxg7fFlr8WhAg+i86lKOOuPms7imf0T3u0JmKuyBu3VC+RAtwlC3pjflb0SZUass51uHmyKGSWYL/6mn+LBaVG3MbNxLAzxgJXn6hO5L+b3/ZNk4zl9o1IuS7H2BNlTfNuvnkntPR8ZfVr9gvtl05a4a0kNKl8P2Ny75ORTsGIAr2xmCZwnBeAwLxQg+3gNakQ0rei2jU5LByh95NUiyS3h/Sm6dKMOJDk4WTFfwCmZR2rx2XFQV8Qkv3rRj5wqoiUVSrtEkiamtpMKW8Po3rSRRnXeb/ZVroHRXfIlnHeiqbnluiQfx4BK7Xp/0FuFMbbcPhKxtrwLC7wB27fpwDeQrXVElgkjciSmIurUL3MFrixJZapm3jN7pNLiE07KOtJJPx2ToNJSRPYE1P7XNe6f74goMAfUY3jFuuJE58nYARNpPI78s5aFTYepuFCNdtMjh2UTPHlbvL60rtHt3TIHER63UoZZ9ES8Da0zHDX7U4J4VIPCzL7D3Hf3U3JiBRfdIMVnk6sS4sU3GlT8Yh9Q7Tj2RHXmVNLMXh+ WW2LB4EQ LExMgda0pW5gTQiEh5FJHeip5jjvBbJMfyE2HxgDOSVZ0wzDQUNjFrWWFyNddefEEagyOiGgFeRuhOXy3cJS8OfJo+1cW4oZ0KCybtma7FkfILAEuqznyEWfZTg3Ms7LGOE5vNRRa+TjwhKuQGBvCyhrvKG0WHWKGNE0MVhPeslI4i7/wdSNTfGf1y6JkDTB+NHUWBzTmrLUNm+yCcAo20rrOYQJS3O+4tHfTzyGFf+xvoEILbwj8VJO38+2fpDLVeNZ6NObFjxfHH/EM4xdtJjAto2ARZjF4ARPOttr679408lpo/SbU3Cyd1KmO7BEu6gFCZYl6NCbyj8p7VuwdVs+qfNIpX9SotLagbk/qiPPdP5phkAvtHvv6E2SlTNv/ZPYRLayRvbTofUutWopfGR/G4A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 16, 2025 at 9:28=E2=80=AFAM David Hildenbrand wrote: > > On 14.07.25 02:32, Nico Pache wrote: > > From: Baolin Wang > > Should the subject better be > > "mm/khugepaged: enable collapsing mTHPs even when PMD THPs are disabled" Thank does read better. > > (in general, I assume all subjects should be prefixed by "mm/khugepaged:"= ) ehhh, seems like there's a mix of "mm/khugepaged", "khugepaged", and "mm: khugepaged:" being used in other commits. I prefer using khugepaged as it leaves me more space for the commit title > > > > > We have now allowed mTHP collapse, but thp_vma_allowable_order() still = only > > checks if the PMD-sized mTHP is allowed to collapse. This prevents scan= ning > > and collapsing of 64K mTHP when only 64K mTHP is enabled. Thus, we shou= ld > > modify the checks to allow all large orders of anonymous mTHP. > > > > Signed-off-by: Baolin Wang > > Signed-off-by: Nico Pache > > --- > > mm/khugepaged.c | 13 +++++++++---- > > 1 file changed, 9 insertions(+), 4 deletions(-) > > > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > > index 7a9c4edf0e23..3772dc0d78ea 100644 > > --- a/mm/khugepaged.c > > +++ b/mm/khugepaged.c > > @@ -491,8 +491,11 @@ void khugepaged_enter_vma(struct vm_area_struct *v= ma, > > { > > if (!test_bit(MMF_VM_HUGEPAGE, &vma->vm_mm->flags) && > > hugepage_pmd_enabled()) { > > - if (thp_vma_allowable_order(vma, vm_flags, TVA_ENFORCE_SY= SFS, > > - PMD_ORDER)) > > + unsigned long orders =3D vma_is_anonymous(vma) ? > > + THP_ORDERS_ALL_ANON : BIT(PMD_ORD= ER); > > + > > + if (thp_vma_allowable_orders(vma, vm_flags, TVA_ENFORCE_S= YSFS, > > + orders)) > > __khugepaged_enter(vma->vm_mm); > > } > > } > > @@ -2624,6 +2627,8 @@ static unsigned int collapse_scan_mm_slot(unsigne= d int pages, int *result, > > > > vma_iter_init(&vmi, mm, khugepaged_scan.address); > > for_each_vma(vmi, vma) { > > + unsigned long orders =3D vma_is_anonymous(vma) ? > > + THP_ORDERS_ALL_ANON : BIT(PMD_ORD= ER); > > unsigned long hstart, hend; > > > > cond_resched(); > > @@ -2631,8 +2636,8 @@ static unsigned int collapse_scan_mm_slot(unsigne= d int pages, int *result, > > progress++; > > break; > > } > > - if (!thp_vma_allowable_order(vma, vma->vm_flags, > > - TVA_ENFORCE_SYSFS, PMD_ORDER)) { > > + if (!thp_vma_allowable_orders(vma, vma->vm_flags, > > + TVA_ENFORCE_SYSFS, orders)) { > > skip: > > progress++; > > continue; > > Acked-by: David Hildenbrand Thank you for your review :) > > -- > Cheers, > > David / dhildenb >