From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE1F2C83F09 for ; Tue, 8 Jul 2025 04:36:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 341206B00BA; Tue, 8 Jul 2025 00:36:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F1FB6B00BB; Tue, 8 Jul 2025 00:36:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 207866B00BE; Tue, 8 Jul 2025 00:36:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0FE656B00BA for ; Tue, 8 Jul 2025 00:36:23 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8DC3259244 for ; Tue, 8 Jul 2025 04:36:21 +0000 (UTC) X-FDA: 83639835762.21.C428864 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 6020B4000B for ; Tue, 8 Jul 2025 04:36:19 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SBdC3zxy; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of npache@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=npache@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751949379; a=rsa-sha256; cv=none; b=dbb30CIwOwpHLEDYf4w5ow62TNSR5GaHA+xUHoTBJdL7HfPj+xjZjmZzIqQDtUOKk2hOrL HRBVkTlSGgIhf0sohDvrDlsPqLwh/jmeCCgPSlZUoKFL6ZQGjKlw+NER27ill5Cc++PZOb N/RBaFv9hDC1PsQz82H/HI4GphvpLco= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SBdC3zxy; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of npache@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=npache@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751949379; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qTGDTcV1p5tJ6HcYmAwz71WaZ4eMKofozyVLBQsC9D0=; b=ow7Axwr3Z/sw5XQx8eWM+dYLzO/RUWfWh7STPBgh2V7N4Be1KQmM3Wh/5Za5gSMXinMzCG DgjKJAv9V0OP+J6qV/4C0OosZT9jr7ixq/3QdK+XlaQEyr9wBqPviCunP43NCbRPtgJW6l bsp0x7exDlb+rbEavPOwRCvd1BNG/3Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751949378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qTGDTcV1p5tJ6HcYmAwz71WaZ4eMKofozyVLBQsC9D0=; b=SBdC3zxycP/dX697v6+4rdWEGWkoxGc9cGXOXqyqULyCxiqwlnQKdC6iNVGIy4KIAr7vdm d0bA2Pn2hTlq6Ig0A3tjIgOXqT5Jpszw0dzXYCiFHx76IX+w5Z8PLNZakK6QRnjyWqTp9O 88Q0radNrZVpJCfsmKWocOd1Uem7qXs= Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-2lLINHxrPrqKWbJaAqZUyw-1; Tue, 08 Jul 2025 00:36:15 -0400 X-MC-Unique: 2lLINHxrPrqKWbJaAqZUyw-1 X-Mimecast-MFC-AGG-ID: 2lLINHxrPrqKWbJaAqZUyw_1751949375 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-70e73d3c474so56662007b3.3 for ; Mon, 07 Jul 2025 21:36:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751949375; x=1752554175; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qTGDTcV1p5tJ6HcYmAwz71WaZ4eMKofozyVLBQsC9D0=; b=vhLc4+vA3HAxAUtsZQiDp4xld+u97KT3ZM+qjH3K5ldiA0KUggXwo2w2+/PYxkNIPK EY8VD3W8/ewuNrQr906gc/+VEP528GolcshSQVhfVRanv1B9jYMmC7yQMeWdAJ3lnbuW xyhyh01PArsBOh3DwqwHUkGoN3Okv0R7KJyRradG2wJIxqg8FoN7FzT/sT78zY8vSN15 gG2MtZN4e/vG1O47VHZJtKQjCeYCYOF/kCkJ6mC/ckDm1jpq/lQfvVT5Nu8sMmWxvhr8 J+SitAhJNvw1lDx58j1SqBHZiOi3g90Xpxeb+GHFBS5F6Hk65vg9pU8xOa3twrVOxd+w PmuA== X-Gm-Message-State: AOJu0YyN7vlo7tBqLcwbpB4CqrQHvRviXmErBuUCrx1ir82Wem20ESvU km8vIwuQztim4EX4cplEENz/I4E5tTofLLRNvxIxt6IrzpN8KhUl3MUiSM+0h4C7JOWzdL2BKhN ewD1pbXqxVlPjtmayAk9wKe6VqXB9BlG7Z1V7y8ElEKJZvWMTxyFRUQfqx2x1QYm02x7cg9HawZ K9fgcjoIPVPdFEx+ag1YN90y2iY/Q= X-Gm-Gg: ASbGncvM43vXOzVsV3omNoa7NVy78Xj+KBSfaEHICD7N4r0QEf+QNPEIAyKBjUeZbJf 52Gm+OipRnahlH4+K+8beImPedkIT/Q4RzNOX0P4oDxerzFtiD30tg1udXQxOMdaGn5EpqLft1o umlzL4ww== X-Received: by 2002:a05:690c:30d:b0:709:197d:5d3c with SMTP id 00721157ae682-7166b5f6bcfmr211917637b3.11.1751949374981; Mon, 07 Jul 2025 21:36:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEKjtH9W0tf3+AELmduA3IzT90z5Tmph6a1WdgnqS7MTd4DhLb5IlYzFbZ5iH11uL+3BnBYuaaRvKhebjyrKfY= X-Received: by 2002:a05:690c:30d:b0:709:197d:5d3c with SMTP id 00721157ae682-7166b5f6bcfmr211917397b3.11.1751949374622; Mon, 07 Jul 2025 21:36:14 -0700 (PDT) MIME-Version: 1.0 References: <20250702055742.102808-1-npache@redhat.com> <20250702055742.102808-2-npache@redhat.com> <9076b4be-8b1d-4434-a72f-d7a829a1a30a@arm.com> In-Reply-To: <9076b4be-8b1d-4434-a72f-d7a829a1a30a@arm.com> From: Nico Pache Date: Mon, 7 Jul 2025 22:35:48 -0600 X-Gm-Features: Ac12FXyKLeWcmAZn58XkB9-ZGx40IFZEQjeJRnPXwLLAOKV8sSiI_4SNmYsKQgM Message-ID: Subject: Re: [PATCH v8 01/15] khugepaged: rename hpage_collapse_* to khugepaged_* To: Dev Jain Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, david@redhat.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, ryan.roberts@arm.com, corbet@lwn.net, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, akpm@linux-foundation.org, baohua@kernel.org, willy@infradead.org, peterx@redhat.com, wangkefeng.wang@huawei.com, usamaarif642@gmail.com, sunnanyong@huawei.com, vishal.moola@gmail.com, thomas.hellstrom@linux.intel.com, yang@os.amperecomputing.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, raquini@redhat.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, tiwai@suse.de, will@kernel.org, dave.hansen@linux.intel.com, jack@suse.cz, cl@gentwo.org, jglisse@google.com, surenb@google.com, zokeefe@google.com, hannes@cmpxchg.org, rientjes@google.com, mhocko@suse.com, rdunlap@infradead.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hLMwyR4qaKrpt9OGi5RoJneinzsfD6jvoIlCisIhms0_1751949375 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6020B4000B X-Stat-Signature: 6engs3aemkg9y4h554cwsuykexxnt8rz X-Rspam-User: X-HE-Tag: 1751949379-996438 X-HE-Meta: U2FsdGVkX1+RzWZOZfeUKQDWytE4HdAmsX49OGGmB2b86lIKTaIrsUxbsFFN7WSf7CjMCJDPY8Z70NWgYxErkETxxJmRpj8DScJKEhQUwVO6aQtPaGz5vCkrNeae9adO7OEmJm3gLCeFXrrHDj9mpLNHPvLXAumqmqDCmYMFYJdq04NMjG0YYDHQf6sxnfX+bKZqtijJ9bS4yIklJLbL8Pfu13mp2qZVC4Z3VLgiT4Avkj/mQB5CDapFy101RWx1YMjHUt59iEegrHPHXmM5nuffbM5ynaos3Nf88J8phORwccnJFyy44wGdxdV29JR1k2GUsNjDQvWnHpjUjAkGXTakftt+yEoNTZxq231mJyknn2L6nazddrLl2vUh1i4MGSIb2CX93SYNKaLlbZq9ZVA2TA/iQmruidbnLKOwnYhYM/njWOhSmnxnYaP6L0iNMfg5rxyuCyvevAcPmVuDButKOknUYOJcQv37kUei21wSUPMraSVMFARupeFI678srWqULpP2mkoTGawQpjXXkDAT9nU6skG/Bo3M+JUn80G/vIaMYVSW1gb5oDA7RCxlSbzsn8d3SW/7uzgTPPWa5I+Lo6EZ7ZF9gJ/zZfL9axHBqEPDwhtUEu6VxLbjCrubtxWebz66TIfbbaM6v76pNfUU0EIGjCoNYTwjrJpld9bGXf1zqRQ9hjAkRNYRMfWPfV+iZo4wyvtPM/7RBIjFINvJBS/sdMegODkw64ezOp4m7M1np11W37DWOjKO7FS+BryJ1ITeEOE6DI6zByx/VhFtWnwJt5TjgyYMAABOF9kDPSErR5jgYSM9MP1Zzw8A3JeiN85dJW5kVemhcLgbQ4wkUvYzZBQo78TOCt++g8shG2zLAvpdarWVOYzpdbHNDCWVB4eZvj3eBCp3YLDFUm4ymujIa9nPm3t3bqbm2UBGF4v5xYf+Ki8JyeoQX0cGGzYH+8MFe94BhOunJEM qWrpAr/g NAcidUeVwo2+DqMUvpNZ71mj0yeacxh6yRTGtJY5A59bSqLHRy7CLaITnkxMFirLJQRWNClrRTi5yZdhjnaUW57cLUxB15gnrdPIudyMf3MFmQXzei33nHdkvCU7m0AQP81u0iSAg1TAq6c7OEDF+FavsdGz2dxYRSduVTfuz8fozRZvaWjoNF223INh0kc1k/jVp9wGvfQIqS8FiPFXvgWKJyVudJHmR0ImscVobjmrowBG8t1D2LXxigbNUxe2AOYiL9xINTbCOmdQT05aVVsBWjEUec0GzxnTyYrWiEYNLkS/cMYCAc5MtyawzMO8kNXfdlXIRWdAHo/RYmHzOwPX2TSZ15v57ZEmmCjxU1tmAJ/9N5gC/yO00jpC5aR5MRJkFy2H1BCtrFk1CMWdt4piqelBPnVWZC3sOp6ICXzMmByFD+dvbTARX+nRisAE3y/7PimkianZ+HYVpm9pyULGq6XqzZIFQTqseYLmz2dKlmnQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 3, 2025 at 11:14=E2=80=AFPM Dev Jain wrote: > > > On 02/07/25 11:27 am, Nico Pache wrote: > > functions in khugepaged.c use a mix of hpage_collapse and khugepaged > > as the function prefix. > > > > rename all of them to khugepaged to keep things consistent and slightly > > shorten the function names. > > > > Reviewed-by: Zi Yan > > Reviewed-by: Baolin Wang > > Signed-off-by: Nico Pache > > --- > > > > You are essentially reverting commit 7d8faaf15545 which adds the > hpage_collapse_ prefix. Since in the next patch you also unify > madvise and khugepaged, removing hpage_collapse prefix would > make sense, but then I tend to agree with Liam that dropping > the prefix altogether is better. Having all the functions in > khugepaged.c prefixed with khugepaged_ seems unnecessary work. Ah thanks for pointing that out, I didn't realize they were already once named khugepaged. Makes sense, since there is opposition, and a good reason to have them as hpage_collapse (or collapse) I'll consider either dropping this patch, or changing it to "collapse_". tbh I didn't realize that was what Liam was suggesting, I thought he was suggesting dropping the hpage_collapse entirely. > > @David, I forgot where you replied but I remember you saying > that we should not introduce MADV_COLLAPSE mTHP support for > now? Yeah Baolin pointed me to that thread (https://lore.kernel.org/all/23b8ad10-cd1f-45df-a25c-78d01c8af44f@redhat.co= m/) I read most of that discussion as it was happening but missed that point. I'll add the small change I need to drop the MADV_COLLAPSE support and send a V9 in a few days (to gather more review). Adding MADV_COLLAPSE support should be easy once/if we come to a consensus on what the proper approach is. Thanks, -- Nico >