From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CA5FC83F17 for ; Wed, 9 Jul 2025 22:54:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D71666B009F; Wed, 9 Jul 2025 18:54:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D21CC6B00A0; Wed, 9 Jul 2025 18:54:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE9D56B00A4; Wed, 9 Jul 2025 18:54:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A444D6B009F for ; Wed, 9 Jul 2025 18:54:02 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 457248036D for ; Wed, 9 Jul 2025 22:54:02 +0000 (UTC) X-FDA: 83646230724.18.05DA540 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by imf21.hostedemail.com (Postfix) with ESMTP id 6A6901C0002 for ; Wed, 9 Jul 2025 22:54:00 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=cl+ue2z0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752101640; a=rsa-sha256; cv=none; b=scjfTL657MHQHDBAHGS9O+7Tgu+E5zwnN+7hw+HltEYXAgQldaJBoDsC8xBePDvxQMfTZr KrydpTxWyF1vdh6oI8a9MzuzvQ7VPs5LcOJWasm3TdNevvVRl4ublKs5+rVe0hBPghLrXc HAecWHz4r2DCzUg95GAzO7n8IHAngA4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=cl+ue2z0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752101640; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N9iJnt4WkpfToovTZMYNbYtyMvKSLn0aTix0qiRAhhs=; b=408W95twCb+Sl2U9qHXOZplhKS/kpBqL718QSYicAbx0i8G+CWN3IlsgZX52LYQVtTc1KJ pZWT1CFZEQBCmWMg2/uoQx4qaWPIGUNl3DPEecZuocdXwtnK09TCpcY0iYpM0haTdbihm2 +kx/vDnbID2BoBjVKwGNp/vY30IJggc= Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3a53359dea5so272338f8f.0 for ; Wed, 09 Jul 2025 15:54:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752101639; x=1752706439; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=N9iJnt4WkpfToovTZMYNbYtyMvKSLn0aTix0qiRAhhs=; b=cl+ue2z0MAjmJsBDMZuzc2/tMHvFiIKR9tGCePkyOx4Zl5yvrhF2x3VWpTgquragwO qXKuYrQZdIBoC0hoNIi0hPMFHwHn718O3ZjkUBM9myeMhw7Cl7LZX+AVLYVxch5DiqMD nAXucc/VOYj9ehpVuRFUINKqNAAIdVgF9PlR3Eq0kqUtfaE2nLB036YN5gp3wnwgEwIL cY8/LPi2ZRcZlwbtB5SFS83RXekg3wL0hcKN5YBVKWiCbpIdovItR15p82FaUSKihTT5 G6PSM0SDlah1tddF8gLRAccpXtD7IJ4DxL/Jv5YF2d7VKezHBNvBfX9xg8m5aoRpavlz +/QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752101639; x=1752706439; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N9iJnt4WkpfToovTZMYNbYtyMvKSLn0aTix0qiRAhhs=; b=w0Q3ctoBPMnbaVr/A9ymMTLiQVMD0NHBHY9CZRC464okr6NW7zErj9bgWZqHKFUW86 o/8Ei8+dTKuSzsy9iji9DitioNKjSyzMwzHQClsfD4KnTn9YPPsNM5FNRGr87G55Kj6T wp8qNfJmFO9WFEmTFV+aXPbpMYUdHes5o9o+4t+iiE+BTK6IBAw0niMuVkmvarieOSBK jzyey7x8do67lyx6KGawFuHtBiI4NBdyfRWb+ZGMUcNeRLqKL328ML+dgdSGMo4iv1wi mDfQ7Q/owuQkw5ryQz5wkzqgDyE3Gr2E1BobnTS8+PDTPPQu9zJf+CsnCGx98exgeDz+ 2CZg== X-Gm-Message-State: AOJu0Yw+0bWXVTLLKCMuq/mQ/zXguBAzhaQiErWxhfzNjOu+bj3x4hue r1R+f1FYw74gBODuGm2UxQKiazFSe0tn7uLoEthK0k+0a9gx4bNXEPDJlhzlbf5ubkIgupmJBxK xBB3i5uEIiENjF/GmSRgm/5SHLlcgWD8= X-Gm-Gg: ASbGnctQCEQtH7N+O46XUiOipgZN2mleKutV4RDuLeP1xOy0AePNqEkTnYzyT904pxu JtQKba+pkJSL/+lLHOwX+nrsHZnQYMUMMt8ngvKHuBweHcOTc9E0f5Q1yVIXn3hqzpTbkSc5hYe bd6CXMrNLrdUbTGGk3tZZSCgph8MFYIr2eabi9wKpLE3xXefer24SzGwy93pc6KLF8n3JTpBorv XR2U3IIKDI= X-Google-Smtp-Source: AGHT+IHDoCCRbQwoVIBCKCBT14ZzPnGvut13NQFhw59jUbLavByhjz0wHOG/UJnidp46oUKDyQonZwNPRHpvQmXcL5Q= X-Received: by 2002:a05:6000:991:b0:3a4:e609:dc63 with SMTP id ffacd0b85a97d-3b5e867f6e4mr389008f8f.20.1752101638580; Wed, 09 Jul 2025 15:53:58 -0700 (PDT) MIME-Version: 1.0 References: <20250709172345.1031907-1-vitaly.wool@konsulko.se> <20250709172416.1031970-1-vitaly.wool@konsulko.se> In-Reply-To: <20250709172416.1031970-1-vitaly.wool@konsulko.se> From: Alexei Starovoitov Date: Wed, 9 Jul 2025 15:53:47 -0700 X-Gm-Features: Ac12FXyuwwXk41iu49XWkmvEY5dPL8zCHicyZww6svC_W6iI9a-7d53GSWyAAdg Message-ID: Subject: Re: [PATCH v12 1/4] mm/vmalloc: allow to set node and align in vrealloc To: Vitaly Wool Cc: linux-mm , Andrew Morton , LKML , Uladzislau Rezki , Danilo Krummrich , Alice Ryhl , Vlastimil Babka , rust-for-linux , Lorenzo Stoakes , "Liam R . Howlett" , Kent Overstreet , linux-bcachefs@vger.kernel.org, bpf , Herbert Xu , Jann Horn , Pedro Falcato Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 6A6901C0002 X-Stat-Signature: 33gayh45mor6r8e1gcjesoondwhz3zoc X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1752101640-399160 X-HE-Meta: U2FsdGVkX1+JCCrU9ubcuMy7n2aGuwM+D20lygdQDVj+1LKVRzFMEGrsarn8aTcKhtUjUTdn9JOJccRQrs9myI3JpNlvSGcuvBx3LBSS3f8H8uWBRbelL0SzH96/VC+PaOsrBYDnFp+O7V5Vx/5l8AjBXvL/KrrZQnqBrsaUZmYkQ2stlJ1VSPbLabfSdRew36McK0YNiCXeG79mayb6Qu+8Xu5KqD2TfqlZZ0WCa2xJYepP0Fmo6jeD8IBJ+HIFALgGjNgMFP2SKQcmLZKZrhpbg9Lv3GhkXPPg7ZMOPWJUchyQ3MTOAWurmnqXyUuu1ASfjvkYjpXjU6x7y2Z/4Zo+9rtXTnsN5sI/MbfymcH9FNHli+2Yvk3Rzc9Np8YSSsgnkFRKTfRsB79i/FK3ImFVkCUrPK1AsWxwS3DWwERb7BL8wAVTBdAa6FP5avhvWWXnYV1aWcsNJs4I4kaR3P7dFZAXePJjkVRdJpgopfjOh0qQRy5SbdU1ai7Tz1DfSGnfIjiPwNkGj9iaRGXcna2Zdry+7/WGcVSOQYWYUlKVrOlATwa5wvH4RlGlgouz4bZ/bRqMcK+2w8YK1hDb3tT5OiHzhwP3/mrVFu+oHZG6V3OKD3j+pOd1MdrZHCBabzEydiUTLoErMPOxbufoJp5UKtohtrtcpwoJWo95H7+N9LDjfumJ2unYKLvdKCzaJ6vTu07hnMJo2/TWHmnfGsXRtZsO9EQJnvkT1AJCOTcLfIR1q3jr6phMmGG4SicpKc+2OX4H9Mb6XD7HdY1PRf5X/0taoviDL6GoTINwRKDB7Evir1QHZwH0hAOyPpEXppjDDvD5Ros/jWLVZOCjabEvRJdYB5RVyr/BXAQsY6pzFkF+usGfGPjqLltp6IXxwJCpinoS+zHc5CA3pTxPZxrC3en89r/S5UUDoQ2rol9wziZvtHajvlyTAkDCkLH4qNktneAwgZFWNH82sLu gDiSt1wQ +CiJ6ev+NClJAvhQiAIIAtjJkT8YSKNHuNjxTl/6QMgmoERqJ/wEVXJuR78eAZkEaarNcnxjr820mejZFvB4zi3Ek7cZwRr5yOBe+JeTbUxw+vGZ91/r1oE0YlrbYYOoEdvQPTZv9OcZ/wMW7mDmNbfAjvRhtsEiJhpAdMmjmJRMrhvThRKB5JfuGniskK3uSNK+7y3428hogAbx6qxb4p6UVjbpqWK6xwuVtsCVcKi9XORwjJP/VS9yVG38VZIUhcsVlfJjz43gzVMont97opzQZL8Q/Xgofv5+gNN9hxXRLM6xBLsVpe+0bak77szuEF8F9K71nxQPOzlWUtdvSZ++fHniFci1gdJG41ZHm7j0E1D99x7aam+i9yrdmHmliLhryxK7yIh4l1z8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 9, 2025 at 10:25=E2=80=AFAM Vitaly Wool wrote: > > > -void *vrealloc_noprof(const void *p, size_t size, gfp_t flags) > +void *vrealloc_node_align_noprof(const void *p, size_t size, unsigned lo= ng align, > + gfp_t flags, int node) > { imo this is a silly pattern to rename functions because they got new arguments. The names of the args are clear enough "align" and "node". I see no point in adding the same suffixes to a function name. In the future this function will receive another argument and the function would be renamed again?! "_noprof" suffix makes sense, since it's there for alloc_hooks, but "_node_align_" is unnecessary.