From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4166C433EF for ; Sun, 5 Dec 2021 03:13:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03BC46B007D; Sat, 4 Dec 2021 22:13:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F2D6A6B0080; Sat, 4 Dec 2021 22:13:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF3F86B0081; Sat, 4 Dec 2021 22:13:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id D047B6B007D for ; Sat, 4 Dec 2021 22:13:46 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8E6748249980 for ; Sun, 5 Dec 2021 03:13:36 +0000 (UTC) X-FDA: 78882270432.26.B81F948 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf14.hostedemail.com (Postfix) with ESMTP id 388B96001983 for ; Sun, 5 Dec 2021 03:13:36 +0000 (UTC) Received: by mail-pj1-f44.google.com with SMTP id p18-20020a17090ad31200b001a78bb52876so8169248pju.3 for ; Sat, 04 Dec 2021 19:13:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=K0undT0YJyHWH56ofdmr45Mkquy1Ol6IKr8TfIm45MQ=; b=alh+KS7FZNqGSxV+8P/PVttRyAnFMPPkSjin/9bJMU8hS7JmzzhS8j8eLur35oi55H A75i8/kfuqCKHqAVU5laxdL6wLaUq9RFf+1HxT2OK0u5WU1oI4adsc9mtBfKTcNG/ocq o86QB2wduzEsB9KSp8j8RhqWqzE6wRFttV7EPX6vbHqstHWUwotYmaBfBPjgjH4J601X KvQYgjXLDxu8TTDp1PHm4vvx0INBpZQBzIRvDsB4Ld4NXwSa3xEr1Pl36oQwhIqFDIIl UGUExDQQz18m2wdtcxNUzCWWm3cEn7ulnLmMTfruOlqsHWItjbH6f4xujPhKH0hCP2ym 2aBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K0undT0YJyHWH56ofdmr45Mkquy1Ol6IKr8TfIm45MQ=; b=mEmDTvj/RN/6oaWOvyZPL7d17bKDfNyxQu+6rMcHqynyVO7tQWYO8lZbXGVyQr6jsv fY/NSLg+Tpg/ueyVnt8FLQvhES9nfXaMG5ylvWjijZb2OLtfZEYPhAv4ek/a9aDSM/A7 pZhZIRx522w57QTORhNKMwcFoEdrko+TQgXWajD1RSLRGtiBjNUV+aCVnVdQ4M/d2175 7RulsHbpc/KWWS+XN/rczJJhSX1zNs7I1/8HiKYn/HTF3uWJdrCwFyY7cN6OjAlJo4fK zRHXcGWpq8Kg/4tT0jsoQcsTaJaEHQhc1YDOLUvgS4CDSlr4FGXEDlE2E2RG9gSByDdP jFEg== X-Gm-Message-State: AOAM5326SLQHjYWWVbz5qpSQMpRw/vZNYJ0wOHwHmtC9UV4JEnovzYZG 7GA/uWOVSmQPSV8JMvLKuWezxjkgBfp0yYEB8jw= X-Google-Smtp-Source: ABdhPJzEGDaefqbNDy2qcJS5gL32CblBVcy3B0f9LoefTt56iGEQdx3xk6vDHLa2iGvTaoQIEcoFiVGvqdiAb5BmAfg= X-Received: by 2002:a17:90b:4c03:: with SMTP id na3mr26426374pjb.62.1638674015106; Sat, 04 Dec 2021 19:13:35 -0800 (PST) MIME-Version: 1.0 References: <20211204095256.78042-1-laoar.shao@gmail.com> <20211204095256.78042-6-laoar.shao@gmail.com> In-Reply-To: From: Alexei Starovoitov Date: Sat, 4 Dec 2021 19:13:24 -0800 Message-ID: Subject: Re: [PATCH -mm 5/5] bpf/progs: replace hard-coded 16 with TASK_COMM_LEN To: Yafang Shao Cc: Andrew Morton , Steven Rostedt , Kees Cook , Petr Mladek , David Hildenbrand , Arnaldo Carvalho de Melo , Andrii Nakryiko , linux-mm , bpf , "linux-perf-use." , Linux-Fsdevel , LKML , Mathieu Desnoyers , Michal Miroslaw , Peter Zijlstra , Matthew Wilcox , Al Viro Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 388B96001983 X-Stat-Signature: 94bgkddkkp6g1e83rgnh9wkodgcpdnju Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=alh+KS7F; spf=pass (imf14.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1638674016-450853 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000020, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Dec 4, 2021 at 6:45 PM Yafang Shao wrote: > > On Sun, Dec 5, 2021 at 12:44 AM Alexei Starovoitov > wrote: > > > > On Sat, Dec 4, 2021 at 1:53 AM Yafang Shao wrote: > > > > > > static int process_sample(void *ctx, void *data, size_t len) > > > { > > > - struct sample *s = data; > > > + struct sample_ringbuf *s = data; > > > > This is becoming pointless churn. > > Nack. > > > > > index 145028b52ad8..7b1bb73c3501 100644 > > > --- a/tools/testing/selftests/bpf/progs/test_core_reloc_kernel.c > > > +++ b/tools/testing/selftests/bpf/progs/test_core_reloc_kernel.c > > > @@ -1,8 +1,7 @@ > > > // SPDX-License-Identifier: GPL-2.0 > > > // Copyright (c) 2019 Facebook > > > > > > -#include > > > -#include > > > +#include > > > #include > > > #include > > > #include > > > @@ -23,11 +22,11 @@ struct core_reloc_kernel_output { > > > int comm_len; > > > }; > > > > > > -struct task_struct { > > > +struct task_struct_reloc { > > > > Churn that is not even compile tested. > > It is strange that I have successfully compiled it.... > Below is the compile log, > > $ cat make.log | grep test_core_reloc_kernel > CLNG-BPF [test_maps] test_core_reloc_kernel.o > GEN-SKEL [test_progs] test_core_reloc_kernel.skel.h > CLNG-BPF [test_maps] test_core_reloc_kernel.o > GEN-SKEL [test_progs-no_alu32] test_core_reloc_kernel.skel.h > > Also there's no error in the compile log. and ran the tests too?