From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DCCEC433B4 for ; Wed, 7 Apr 2021 18:40:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B76B761245 for ; Wed, 7 Apr 2021 18:40:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B76B761245 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4C8D66B0073; Wed, 7 Apr 2021 14:40:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 49E4A6B0078; Wed, 7 Apr 2021 14:40:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 365EC6B007D; Wed, 7 Apr 2021 14:40:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0055.hostedemail.com [216.40.44.55]) by kanga.kvack.org (Postfix) with ESMTP id 1C0276B0073 for ; Wed, 7 Apr 2021 14:40:26 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C3B8A18182895 for ; Wed, 7 Apr 2021 18:40:25 +0000 (UTC) X-FDA: 78006436410.01.7C6EAFA Received: from mail-il1-f178.google.com (mail-il1-f178.google.com [209.85.166.178]) by imf11.hostedemail.com (Postfix) with ESMTP id 3A5DB2000255 for ; Wed, 7 Apr 2021 18:40:20 +0000 (UTC) Received: by mail-il1-f178.google.com with SMTP id p8so12736550ilm.13 for ; Wed, 07 Apr 2021 11:40:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m1C32+Ws/D/BXd+DIGZBmNk7jd19N3wmSzcAq3Dfs+w=; b=mHnRP/cYm6AvebvssXcW8Y5WB637Pdq6YQItx1eIHoLvW2sqh1sTzxZY5lNRS3DScd 70RAIaDFbuDUyDab9m4sdx8nuPkME0ykMMGMTy7p/u7kFVNybCIVO2g1OuQ2v6rcsR5t 8m+xhS2GBMprE5PkJ6RrGyjSSj2gDc/My9l7sVVKtNOOpWjNp4T9vBraj3XyzO10Wx16 InUqxzzs6+ywZGX/aVn66gYoHXSZvY7oEWmSRT+LMHE8nSt/om6zdZtGs/LxbpwRCEi8 Soc8dpGPGTIkGvygZj3Hw6+oT9lOEn5vUGD++kx3yK2tZ6VyyvMdnlMmG0/YwqRvL6T4 PVug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m1C32+Ws/D/BXd+DIGZBmNk7jd19N3wmSzcAq3Dfs+w=; b=gOv8AmuA2M8OBDK5hSvCcMseRLHlTeh6xFzAwHpN1nXmOmXwxv29Z8ruOT6fg68nBX 18Bbhsm+fP6hfX7xoirjt20KGaCG3RBa7z+JFIjTbwZ+f+K58djC62wEMv3QBPOPJO01 vnwp+dbEgsM8t3dIVMuNP4ZKKVo+ElzyXYqusifZQyTes6Uxu1xSFbrfolkbdjwYOVJ3 f642tUbBmvNTXoGQ+oVxFaQsWsCG8FkaKqL9U/tRyom/A8hG4CDZBujB1bfGVTE3jMOA nWpLSqjME/7W8hO5QYtwZ5dGekhbza4UU4KMl9Xw3yXB/Xj1NYd8RM4nFSmzvQUGWEcH bFbA== X-Gm-Message-State: AOAM533RheTk2CcANBDDX/LSvSZk9WJM2ZRnJ3MJQtr/ZoZJf5/RE7W/ W27NqzRGOcWn/dgjdEl61GYYR1+anev4Z9AWrlZr8w== X-Google-Smtp-Source: ABdhPJxrOr8UlQInHmCI5WOtRKkP7DU5pbsad3aM8CI9NjQc322ZHlK1Y0YkZVSp1YHXwfJCn17oBbL7EtzZlF6KFYc= X-Received: by 2002:a05:6e02:1ca2:: with SMTP id x2mr1011087ill.128.1617820824429; Wed, 07 Apr 2021 11:40:24 -0700 (PDT) MIME-Version: 1.0 References: <20210401183216.443C4443@viggo.jf.intel.com> <20210401183229.B2360AEA@viggo.jf.intel.com> In-Reply-To: <20210401183229.B2360AEA@viggo.jf.intel.com> From: Wei Xu Date: Wed, 7 Apr 2021 11:40:13 -0700 Message-ID: Subject: Re: [PATCH 07/10] mm/vmscan: add helper for querying ability to age anonymous pages To: Dave Hansen Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, shy828301@gmail.com, Greg Thelen , David Rientjes , ying.huang@intel.com, Dan Williams , david@redhat.com, osalvador@suse.de Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 3A5DB2000255 X-Stat-Signature: 3kr77dyw3zikk114s7rx3y7pc1sc5anp Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf11; identity=mailfrom; envelope-from=""; helo=mail-il1-f178.google.com; client-ip=209.85.166.178 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617820820-257590 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000108, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > +/* > + * Anonymous LRU management is a waste if there is > + * ultimately no way to reclaim the memory. > + */ > +bool anon_should_be_aged(struct lruvec *lruvec) > +{ > + struct pglist_data *pgdat = lruvec_pgdat(lruvec); > + > + /* Aging the anon LRU is valuable if swap is present: */ > + if (total_swap_pages > 0) > + return true; > + > + /* Also valuable if anon pages can be demoted: */ > + if (next_demotion_node(pgdat->node_id) >= 0) > + return true; > + > + /* No way to reclaim anon pages. Should not age anon LRUs: */ > + return false; > +} anon_should_be_aged() doesn't really need "lruvec". It essentially answers whether the pages of the given node can be swapped or demoted. So it would be clearer and less confusing if anon_should_be_aged() takes "pgdat" instead of "lruvec" as the argument. The call to mem_cgroup_lruvec(NULL, pgdat) in age_active_anon() can then be removed as well.