From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 722E4C433F5 for ; Fri, 22 Apr 2022 20:39:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E633F6B0073; Fri, 22 Apr 2022 16:39:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E131B6B0074; Fri, 22 Apr 2022 16:39:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB43B6B0075; Fri, 22 Apr 2022 16:39:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id BDACA6B0073 for ; Fri, 22 Apr 2022 16:39:20 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8A2C220524 for ; Fri, 22 Apr 2022 20:39:20 +0000 (UTC) X-FDA: 79385680080.13.17EE6C7 Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com [209.85.217.41]) by imf06.hostedemail.com (Postfix) with ESMTP id 1EECF18002B for ; Fri, 22 Apr 2022 20:39:18 +0000 (UTC) Received: by mail-vs1-f41.google.com with SMTP id d2so1513559vsd.12 for ; Fri, 22 Apr 2022 13:39:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=636ibPgFBEDCNtk4r1DwpQyk0v+PRhTEdZcUsDYNVIg=; b=sRjkhgqjYM8j6vS5P/KtvB1pENWCXp5ERJZm0ptJnuSLh35evlHXLcp2tHFtyPbkvu n42ZGBRzHqTVCF5h7nOsRSQivHEYu24Z8bpDJKu+5Bf4qHpwObEh04fsXTy0PqZbTfgb D0zytecyNVQct/JUcnFrDFSutilFOVSJi5M8dUnBg+BjTld6UmgYRArYp5eetd5S2F0/ ejSrW5DBpXXB1Mh9tTVHom21F71XPL0YzXUjYQr7S6fzNVwyrDsv8ekiQ0LSSkKgy9k8 Hg7SW5Gtoai9vlWGQq8mkD2bm7ey6gs9+pCLLA9Kt8/Wqo6Q684Oni8eBvVXwDz63grl DWHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=636ibPgFBEDCNtk4r1DwpQyk0v+PRhTEdZcUsDYNVIg=; b=IbjFe1yqZujDA8vtJsO5RNYT+NK2my5d1mP8Vf+/PUdTYWsz9xWjmDuaGpJYXZr3i4 gKs6XiN7iBryOqt8uDk6BXFFURnfZo7hVAbNHSr8hDHFNlEsvtbKA1f1VpdCeljF8uBo jbHZfBruN8DjcebglXPAV6KdCdqKztQEnxpn45b7iTR9BlRrgEcS8TVK0LnBkgaesZ3P 44NfU4nWLc9shQp6jIZOxOlLAtsl6o+JbBF6Rd6onxxopHzRQ1ers/EiQxKA5jhGT+Vh GrghzefIF0L1NDsY5HScN7SgxL/I5qO1ZemsDG5j2j82Im45lmiNl9I4kyC22M403/GB 2t7g== X-Gm-Message-State: AOAM531yDAf+xXioSHW1v+p2V1d+HFxyG3FOfQRxtNTEdU9Bkk+QAdTi Pb1qmUljt+Ze14xdBc5O4RrdVE18TKgDEVJV1Lpx26siWSoAsA== X-Google-Smtp-Source: ABdhPJwbPGbnoKceZbheoWAfNjsWNKYJ91xGxsuWJOybpvBayAMeD9nFHp9ALQapbpy/NtsnN8F2ogXlrYWPuRlqWkA= X-Received: by 2002:a05:6102:3106:b0:32a:18c8:1633 with SMTP id e6-20020a056102310600b0032a18c81633mr2082151vsh.51.1650659958845; Fri, 22 Apr 2022 13:39:18 -0700 (PDT) MIME-Version: 1.0 References: <20220422195516.10769-1-jvgediya@linux.ibm.com> <20220422195516.10769-6-jvgediya@linux.ibm.com> In-Reply-To: <20220422195516.10769-6-jvgediya@linux.ibm.com> From: Wei Xu Date: Fri, 22 Apr 2022 13:39:07 -0700 Message-ID: Subject: Re: [PATCH v3 5/7] mm: demotion: Build demotion list based on N_DEMOTION_TARGETS To: Jagdish Gediya Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, dave.hansen@linux.intel.com, ying.huang@intel.com, aneesh.kumar@linux.ibm.com, shy828301@gmail.com, gthelen@google.com, dan.j.williams@intel.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1EECF18002B X-Stat-Signature: axj5oka5shbzt49yg1ha5krureks17gj X-Rspam-User: Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=sRjkhgqj; spf=pass (imf06.hostedemail.com: domain of weixugc@google.com designates 209.85.217.41 as permitted sender) smtp.mailfrom=weixugc@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1650659958-174159 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 22, 2022 at 12:55 PM Jagdish Gediya wrote: > > Only nodes which has state N_DEMOTION_TARGETS should be > used as demotion targets, make nodes which are not in demotion > targets as source nodes while building demotion target list > so that demotion targets are only chosen from N_DEMOTION_TARGETS. > > Signed-off-by: Aneesh Kumar K.V > Signed-off-by: Jagdish Gediya > --- Acked-by: Wei Xu > mm/migrate.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 8bbe1e478122..5b92a09fbe4a 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -2366,10 +2366,10 @@ static void __set_migration_target_nodes(void) > disable_all_migrate_targets(); > > /* > - * Allocations go close to CPUs, first. Assume that > - * the migration path starts at the nodes with CPUs. > + * Some systems can have DRAM(fast memory) only NUMA nodes, demotion targets > + * need to be found for them as well. > */ > - next_pass = node_states[N_CPU]; > + nodes_andnot(next_pass, node_states[N_ONLINE], node_states[N_DEMOTION_TARGETS]); > again: > this_pass = next_pass; > next_pass = NODE_MASK_NONE; > -- > 2.35.1 >