From: Bob Liu <lliubbo@gmail.com>
To: David Rientjes <rientjes@google.com>
Cc: akpm@linux-foundation.org, aarcange@redhat.com,
xiaoguangrong@linux.vnet.ibm.com, hughd@google.com,
kirill.shutemov@linux.intel.com, Linux-MM <linux-mm@kvack.org>
Subject: Re: [PATCH 2/4] thp: introduce hugepage_get_pmd()
Date: Fri, 19 Oct 2012 11:00:36 +0800 [thread overview]
Message-ID: <CAA_GA1djHQ1QRO9oi+NOdJo58VNGn=woz8mpvwzpdv5HqeLOkQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1210181314380.26994@chino.kir.corp.google.com>
On Fri, Oct 19, 2012 at 4:15 AM, David Rientjes <rientjes@google.com> wrote:
> On Thu, 18 Oct 2012, Bob Liu wrote:
>
>> Introduce hugepage_get_pmd() to simple code.
>>
>
> I don't see this as simple just because you're removing more lines, I find
> pagetable walks to be harder to read when split up like this and the "get"
> part implies you're grabbing a reference on the pmd, which you're not.
There are really too much place(at least four) do pagetable walks in thp.
My original idea was putting them into one pagewalk fucntion together,
that would be
clearer and more readable.
But there are several different pmd checks, no better way found to
collect them currently.
i'll keep on working on that.
Thanks.
--
Regards,
--Bob
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-10-19 3:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1350555140-11030-1-git-send-email-lliubbo@gmail.com>
2012-10-18 10:20 ` [PATCH 1/4] thp: clean up __collapse_huge_page_isolate Bob Liu
2012-10-19 1:07 ` Ni zhan Chen
[not found] ` <1350555140-11030-2-git-send-email-lliubbo@gmail.com>
2012-10-18 10:20 ` [PATCH 2/4] thp: introduce hugepage_get_pmd() Bob Liu
[not found] ` <alpine.DEB.2.00.1210181314380.26994@chino.kir.corp.google.com>
2012-10-19 3:00 ` Bob Liu [this message]
[not found] ` <1350555140-11030-3-git-send-email-lliubbo@gmail.com>
2012-10-18 10:21 ` [PATCH 3/4] thp: introduce hugepage_vma_check() Bob Liu
[not found] ` <1350555140-11030-4-git-send-email-lliubbo@gmail.com>
2012-10-18 10:21 ` [PATCH 4/4] thp: cleanup: introduce mk_huge_pmd() Bob Liu
[not found] ` <alpine.DEB.2.00.1210181311390.26994@chino.kir.corp.google.com>
2012-10-19 2:51 ` [PATCH 1/4] thp: clean up __collapse_huge_page_isolate Bob Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA_GA1djHQ1QRO9oi+NOdJo58VNGn=woz8mpvwzpdv5HqeLOkQ@mail.gmail.com' \
--to=lliubbo@gmail.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).