linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Bob Liu <lliubbo@gmail.com>
To: Ric Mason <ric.masonn@gmail.com>
Cc: linux-mm@kvack.org, dan.magenheimer@oracle.com,
	konrad.wilk@oracle.com, sjenning@linux.vnet.ibm.com,
	gregkh@linuxfoundation.org, akpm@linux-foundation.org,
	rcj@linux.vnet.ibm.com, ngupta@vflare.org, minchan@kernel.org,
	Stefan Hengelein <ilendir@googlemail.com>,
	Florian Schmaus <fschmaus@gmail.com>,
	Andor Daam <andor.daam@googlemail.com>
Subject: Re: [PATCH V2 01/11] mm: frontswap: lazy initialization to allow tmem backends to build/run as modules
Date: Thu, 7 Mar 2013 18:10:29 +0800	[thread overview]
Message-ID: <CAA_GA1e8xNDDe4qjVHUpt6Ep7xdo-KBKEKbtrQ8v2GhOF+8HNA@mail.gmail.com> (raw)
In-Reply-To: <51373853.4010402@gmail.com>

Hi Ric,

On Wed, Mar 6, 2013 at 8:36 PM, Ric Mason <ric.masonn@gmail.com> wrote:
> On 03/06/2013 04:51 PM, Bob Liu wrote:
>>
>> From: Dan Magenheimer <dan.magenheimer@oracle.com>
>>
>> With the goal of allowing tmem backends (zcache, ramster, Xen tmem) to be
>> built/loaded as modules rather than built-in and enabled by a boot
>> parameter,
>> this patch provides "lazy initialization", allowing backends to register
>> to
>> frontswap even after swapon was run. Before a backend registers all calls
>> to init are recorded and the creation of tmem_pools delayed until a
>> backend
>> registers or until a frontswap store is attempted.
>
>
> You drop patch 0/11, why? Where is the changelog?
>

Sorry for my mistake,  i forgot to generate patch 0/11.
Since Andrew has already merge this series, i just add some comment here.

Below four patches in V1 will cause compile error if not define
CONFIG_FRONTSWAP/CLEANCACHE
frontswap: Use static_key instead of frontswap_enabled and frontswap_ops
frontswap: Remove the check for frontswap_enabled.
cleancache: Use static_key instead of cleancache_ops and cleancache_enabled.
cleancache: Remove the check for cleancache_enabled.

In V2
[PATCH V2 03/11] mm: frontswap: cleanup code
[PATCH V2 07/11] mm: cleancache: clean up cleancache_enabled
will fix the compile error and cleanup the code.

Now static_key was dropped which may cause some race in future if
module unload was supported.
I'll continue to update it base on -mm tree, so other not related
patches in this series don't need to be resend again.

V2 also fix some checkpatch error.

-- 
Regards,
--Bob

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2013-03-07 10:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-06  8:51 [PATCH V2 01/11] mm: frontswap: lazy initialization to allow tmem backends to build/run as modules Bob Liu
2013-03-06  8:51 ` [PATCH V2 02/11] frontswap: Make frontswap_init use a pointer for the ops Bob Liu
2013-03-06  8:51 ` [PATCH V2 03/11] mm: frontswap: cleanup code Bob Liu
2013-03-06 14:55   ` Konrad Rzeszutek Wilk
2013-03-06  8:51 ` [PATCH V2 04/11] frontswap: Get rid of swap_lock dependency Bob Liu
2013-03-06  8:51 ` [PATCH V2 05/11] mm: cleancache: lazy initialization to allow tmem backends to build/run as modules Bob Liu
2013-03-06  8:51 ` [PATCH V2 06/11] cleancache: Make cleancache_init use a pointer for the ops Bob Liu
2013-03-06  8:51 ` [PATCH V2 07/11] mm: cleancache: clean up cleancache_enabled Bob Liu
2013-03-06  8:51 ` [PATCH V2 08/11] xen: tmem: enable Xen tmem shim to be built/loaded as a module Bob Liu
2013-03-06  8:51 ` [PATCH V2 09/11] zcache/tmem: Better error checking on frontswap_register_ops return value Bob Liu
2013-03-06  8:51 ` [PATCH V2 10/11] staging: zcache: enable ramster to be built/loaded as a module Bob Liu
2013-03-06  8:51 ` [PATCH V2 11/11] staging: zcache: enable zcache " Bob Liu
2013-03-06 12:36 ` [PATCH V2 01/11] mm: frontswap: lazy initialization to allow tmem backends to build/run as modules Ric Mason
2013-03-07 10:10   ` Bob Liu [this message]
2013-03-27 21:09 ` Andrew Morton
2013-03-28  2:09   ` Bob Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA_GA1e8xNDDe4qjVHUpt6Ep7xdo-KBKEKbtrQ8v2GhOF+8HNA@mail.gmail.com \
    --to=lliubbo@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=andor.daam@googlemail.com \
    --cc=dan.magenheimer@oracle.com \
    --cc=fschmaus@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ilendir@googlemail.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=ngupta@vflare.org \
    --cc=rcj@linux.vnet.ibm.com \
    --cc=ric.masonn@gmail.com \
    --cc=sjenning@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).