From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3770C433EF for ; Mon, 11 Apr 2022 17:19:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FF656B0072; Mon, 11 Apr 2022 13:19:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AFA16B0073; Mon, 11 Apr 2022 13:19:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44F556B0074; Mon, 11 Apr 2022 13:19:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 325246B0072 for ; Mon, 11 Apr 2022 13:19:37 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id D8CB9121A88 for ; Mon, 11 Apr 2022 17:19:36 +0000 (UTC) X-FDA: 79345259952.04.690FDEA Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by imf21.hostedemail.com (Postfix) with ESMTP id 6ADEF1C0008 for ; Mon, 11 Apr 2022 17:19:36 +0000 (UTC) Received: by mail-lf1-f42.google.com with SMTP id u7so10772015lfs.8 for ; Mon, 11 Apr 2022 10:19:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sZJ+MNwAciw6Za81vh0kJtEffYGodA8iLGsoa2KZf08=; b=LzcU0aZv/6CDhFiflC924+Jc7H2aim9M6dUW6jucnwaxEubJLgwAdAmCTGeYZ9skSY y8RmWRedLJl0I0Nl8/0tZCollZRF5rebiuu0CXC0YwwhSyGIL4Ty5VkIqs4mHEBllQl/ hVFZ0i5MhkrAEoZLSr9w5DVxdzKVy4PtHtFI0AZHxtlL/doaEV7/Bc/rChocZlSfFWq6 R8SUbN+PB21+JQI0DvhgzrpZBgen8qjFo99e8I+Xy3/FsP23my0D/g9PKjLwKsBN7ZZt AHhU7yJP62sFnJ2ypYzcZJcgKiCEEmiGhBMjfIG+rSYQdJpiGquEbcnXFa2x0a3iACrO ai/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sZJ+MNwAciw6Za81vh0kJtEffYGodA8iLGsoa2KZf08=; b=ojLnGAybbg3duSNpHgOvOvfaKVFqyBjmniMNQ2MCPZSg7T4uArLUX7wc5+IqscT0Td JmZcyPUFgDmbswLe1SZbRV6iecbV0qsW9arcFbCV3kxVsDXyeVF9pnhPj6nEdyGM4XkO h66S216C7jew+wKtuxVMu5JnDZjEt7agIUk9pCNvwGfbhtZH979kTSKNyHpmBCD7TNZG B8ms90PLAbliL6LS483kfclKO9XeK1IXmlxU5+28q0jhFr3sLCA02lJikIFvpYqdcGax oxV+LtWBvPkdp64/b8ZsyhoTMtBuSHCFzr9LB9D3uaeMsKtpx8N1NlwyQm+/OQUDsNei fz8g== X-Gm-Message-State: AOAM530SzSME7GLqzRM75yaHbk95kBjaeG6tUGOTfzdIM5QV+bze/Rja /H1iPhAvl+XbMnGAwZcJyCpBTsxYEuN1xo6VoHOdtA== X-Google-Smtp-Source: ABdhPJwNLkuKfff3xs6R27TRX6B0kuh9UF9QoMlqqC0hFOjeTCYS2TPGwxbEtngHsIvPyBnWOZlR3/62WxOj9E84QhE= X-Received: by 2002:a19:6d1b:0:b0:46b:94a8:da55 with SMTP id i27-20020a196d1b000000b0046b94a8da55mr8067188lfc.354.1649697574293; Mon, 11 Apr 2022 10:19:34 -0700 (PDT) MIME-Version: 1.0 References: <20220410135445.3897054-6-zokeefe@google.com> <202204110059.a0PLTrVC-lkp@intel.com> In-Reply-To: <202204110059.a0PLTrVC-lkp@intel.com> From: "Zach O'Keefe" Date: Mon, 11 Apr 2022 12:18:56 -0500 Message-ID: Subject: Re: [PATCH 05/12] mm/madvise: introduce MADV_COLLAPSE sync hugepage collapse To: kernel test robot Cc: Alex Shi , David Hildenbrand , David Rientjes , Matthew Wilcox , Michal Hocko , Pasha Tatashin , SeongJae Park , Song Liu , Vlastimil Babka , Yang Shi , Zi Yan , linux-mm@kvack.org, llvm@lists.linux.dev, kbuild-all@lists.01.org, Andrea Arcangeli , Andrew Morton , Arnd Bergmann , Axel Rasmussen , Chris Kennelly , Chris Zankel , Helge Deller , Hugh Dickins , Ivan Kokshaysky , "James E.J. Bottomley" , Jens Axboe , "Kirill A. Shutemov" , Matt Turner , Max Filippov , Miaohe Lin , Minchan Kim , Patrick Xia Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Stat-Signature: 856a7gffkaqc75o5zw4tb4oxgbtyx8db Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=LzcU0aZv; spf=pass (imf21.hostedemail.com: domain of zokeefe@google.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=zokeefe@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 6ADEF1C0008 X-HE-Tag: 1649697576-246981 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Sorry about this. Will add support for: alpha mips parisc xtensa in respective arch/$ARCH/include/uapi/asm/mman.h files On Sun, Apr 10, 2022 at 11:15 AM kernel test robot wrote: > > Hi Zach, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on hnaz-mm/master] > > url: https://github.com/intel-lab-lkp/linux/commits/Zach-O-Keefe/mm-userspace-hugepage-collapse/20220410-215722 > base: https://github.com/hnaz/linux-mm master > config: mips-randconfig-r002-20220410 (https://download.01.org/0day-ci/archive/20220411/202204110059.a0PLTrVC-lkp@intel.com/config) > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 256c6b0ba14e8a7ab6373b61b7193ea8c0a3651c) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install mips cross compiling tool for clang build > # apt-get install binutils-mips-linux-gnu > # https://github.com/intel-lab-lkp/linux/commit/4f4775a3e4a722525787b2c309032810356473c2 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Zach-O-Keefe/mm-userspace-hugepage-collapse/20220410-215722 > git checkout 4f4775a3e4a722525787b2c309032810356473c2 > # save the config file to linux build tree > mkdir build_dir > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > >> mm/madvise.c:62:7: error: use of undeclared identifier 'MADV_COLLAPSE' > case MADV_COLLAPSE: > ^ > mm/madvise.c:1055:7: error: use of undeclared identifier 'MADV_COLLAPSE' > case MADV_COLLAPSE: > ^ > 2 errors generated. > > > vim +/MADV_COLLAPSE +62 mm/madvise.c > > 44 > 45 /* > 46 * Any behaviour which results in changes to the vma->vm_flags needs to > 47 * take mmap_lock for writing. Others, which simply traverse vmas, need > 48 * to only take it for reading. > 49 */ > 50 static int madvise_need_mmap_write(int behavior) > 51 { > 52 switch (behavior) { > 53 case MADV_REMOVE: > 54 case MADV_WILLNEED: > 55 case MADV_DONTNEED: > 56 case MADV_DONTNEED_LOCKED: > 57 case MADV_COLD: > 58 case MADV_PAGEOUT: > 59 case MADV_FREE: > 60 case MADV_POPULATE_READ: > 61 case MADV_POPULATE_WRITE: > > 62 case MADV_COLLAPSE: > 63 return 0; > 64 default: > 65 /* be safe, default to 1. list exceptions explicitly */ > 66 return 1; > 67 } > 68 } > 69 > > -- > 0-DAY CI Kernel Test Service > https://01.org/lkp >