From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8886AC433EF for ; Thu, 9 Jun 2022 23:32:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF5378D0065; Thu, 9 Jun 2022 19:32:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA4BE8D0064; Thu, 9 Jun 2022 19:32:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C45268D0065; Thu, 9 Jun 2022 19:32:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B169E8D0064 for ; Thu, 9 Jun 2022 19:32:49 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 851F480B3D for ; Thu, 9 Jun 2022 23:32:49 +0000 (UTC) X-FDA: 79560299658.02.5FB714A Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by imf13.hostedemail.com (Postfix) with ESMTP id 10A1720071 for ; Thu, 9 Jun 2022 23:32:48 +0000 (UTC) Received: by mail-lf1-f43.google.com with SMTP id 20so798820lfz.8 for ; Thu, 09 Jun 2022 16:32:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zZvfHuA/INP0bzqhy6JO1XuTrxVTvY/yQkrfFhyb6RY=; b=AO9UirfXTW2usQSjxu5mnE63GJVln7CwTvt984QMHHlVtQ+thTYoPhGoxy2vNlGaTW 5JlRQRR3o9ghci3LGlhcXfCKmZZBeImW/j9RH3JyGwU6NgrlXTJb7Pd5kqSkAPpeEGvq fpFzPg9HvuZZavvXLtjJqucCteVRar2VGekVCknBjxxqxh0OEarqcIWYNOeHdmUWafFK SVIv6Byh+3AEtT5bqGoAcgK+zq6KYHvAJYjiMmkrkewvQAasOB60UC4ov7JvFsezBE74 +Bzkyj6mF1ZkmTGEMCWKKodFQFDUjS04oF4cLOKZHagmzoDoy2b6sy7C4qVjd3zpL8B3 o5Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zZvfHuA/INP0bzqhy6JO1XuTrxVTvY/yQkrfFhyb6RY=; b=1poXQHvQSzGL9Ib8zX46V7vBLeglpAyIvw/gOtp5u9/4HT3qs+3pZG6cFpKG4h/7s9 TsBmcGvRRvl1vGghEfZkw/6J7erHTIycrhmt3UhGwBWyfl/4wh7UB6mYdCJLyOQfatzs mk/ok0P1/C5PMBmgHetN9nfHRNuPVfoFdwKAMy/5KCaWiAgj8qzzYNdx1g9QKB493lMz c7T8bh4XxCROenRE9vn6sYCNwetnbMbcQy2f2jSb5iMTGAfibs5YsOcOzwYog7voPDKY YPMLvYuhIuve2k9PNxBrPutCBOjbv2AkMV+x6z4uvjlqsq+UYriJUDYpAPF9QupTxA51 /DAA== X-Gm-Message-State: AOAM5301+ZLODBjG8nwypESw4w2FtG65bQi3Yg8t5Hx3roOW1nAnVu9m 8niXe/VFCeWU2KEkkXwLuoT95kqAU2oGtp4pyjALGw== X-Google-Smtp-Source: ABdhPJw6HqwRaxvlvHRov+lDQ9sHRbUp445FudsXOBatCxCFe8iOBOODDCxKFv28Gdt0LEzRCIjhyBzekDv4qYM1uwQ= X-Received: by 2002:a05:6512:11e4:b0:479:5d64:f3a0 with SMTP id p4-20020a05651211e400b004795d64f3a0mr10959909lfs.354.1654817567136; Thu, 09 Jun 2022 16:32:47 -0700 (PDT) MIME-Version: 1.0 References: <20220606214414.736109-1-shy828301@gmail.com> In-Reply-To: <20220606214414.736109-1-shy828301@gmail.com> From: "Zach O'Keefe" Date: Thu, 9 Jun 2022 16:32:10 -0700 Message-ID: Subject: Re: [mm-unstable v3 PATCH 0/7] Cleanup transhuge_xxx helpers To: Yang Shi Cc: vbabka@suse.cz, kirill.shutemov@linux.intel.com, willy@infradead.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654817569; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zZvfHuA/INP0bzqhy6JO1XuTrxVTvY/yQkrfFhyb6RY=; b=z3cdWX8f6Mdre9I16JVLbrjEc2lrkznOCCREhIPQ+HAnsAphpgNxNbGFsqkNBWbpnd9k4r ZdgXziZraNnQKX+ET1aIFi4ug0fQXV90DKOs9KJ4FzxiCs03PBGb03JMqP8qRb4q2RFdrB 8Kpm+R9HCIN6IATorR7wBFsVlL6mG7w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654817569; a=rsa-sha256; cv=none; b=fhHWFsSfhMx7IiWxHGK6HGzS02BeS1M63DvAts6Tb2xDGbaZ7koR6ZHBiq6QgkjcYbTVsw +1z286pZ4zIOpr8HQzQSBSbpNFxqtxiet4zULyN2j26ecXv2V7lzQMF6JxS4Zk9NQIgt71 uUvcC0gcAmPn58c6qyJabg6SwHyRiQg= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=AO9UirfX; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of zokeefe@google.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=zokeefe@google.com X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=AO9UirfX; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of zokeefe@google.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=zokeefe@google.com X-Rspamd-Server: rspam03 X-Stat-Signature: m8ppc5m7citikmp3pwp8umkhwddjarf9 X-Rspamd-Queue-Id: 10A1720071 X-HE-Tag: 1654817568-799967 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 6, 2022 at 2:44 PM Yang Shi wrote: > > > v3: * Fixed the comment from Willy > v2: * Rebased to the latest mm-unstable > * Fixed potential regression for smaps's THPeligible > > This series is the follow-up of the discussion about cleaning up transhuge_xxx > helpers at https://lore.kernel.org/linux-mm/627a71f8-e879-69a5-ceb3-fc8d29d2f7f1@suse.cz/. > > THP has a bunch of helpers that do VMA sanity check for different paths, they > do the similar checks for the most callsites and have a lot duplicate codes. > And it is confusing what helpers should be used at what conditions. > > This series reorganized and cleaned up the code so that we could consolidate > all the checks into hugepage_vma_check(). By the way, thanks for doing this work. I know I personally was quite confused about which vma checking function does what / which I should be using. I briefly tried sketching out how to do something like this as well - but the various corner cases where e.g. hugepage_vma_check() and transparent_hugepage_active() differed got confusing. Thanks for figuring this all out. > The transhuge_vma_enabled(), transparent_hugepage_active() and > __transparent_hugepage_enabled() are killed by this series. > > Added transhuge_vma_size_ok() helper to remove some duplicate code. > > > Yang Shi (7): > mm: khugepaged: check THP flag in hugepage_vma_check() > mm: thp: introduce transhuge_vma_size_ok() helper > mm: khugepaged: remove the redundant anon vma check > mm: khugepaged: use transhuge_vma_suitable replace open-code > mm: thp: kill transparent_hugepage_active() > mm: thp: kill __transhuge_page_enabled() > mm: khugepaged: reorg some khugepaged helpers > > fs/proc/task_mmu.c | 2 +- > include/linux/huge_mm.h | 84 ++++++++++++++++++++++++++++------------------------------------------ > include/linux/khugepaged.h | 21 ++---------------- > mm/huge_memory.c | 64 +++++++++++++++++++++++++++++++++++++++++++++-------- > mm/khugepaged.c | 78 +++++++++++++++-------------------------------------------------- > mm/memory.c | 7 ++++-- > 6 files changed, 114 insertions(+), 142 deletions(-) > > >