From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32DB6C388F7 for ; Thu, 5 Nov 2020 12:14:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 919342078E for ; Thu, 5 Nov 2020 12:14:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="UcB9WgQU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 919342078E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BF3866B00F6; Thu, 5 Nov 2020 07:14:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BA2486B00FA; Thu, 5 Nov 2020 07:14:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A43066B00FD; Thu, 5 Nov 2020 07:14:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0253.hostedemail.com [216.40.44.253]) by kanga.kvack.org (Postfix) with ESMTP id 77D5B6B00F6 for ; Thu, 5 Nov 2020 07:14:46 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 17D73180AD806 for ; Thu, 5 Nov 2020 12:14:46 +0000 (UTC) X-FDA: 77450258172.25.shelf18_21014f1272c9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id E5B631804E3A1 for ; Thu, 5 Nov 2020 12:14:45 +0000 (UTC) X-HE-Tag: shelf18_21014f1272c9 X-Filterd-Recvd-Size: 4346 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Thu, 5 Nov 2020 12:14:45 +0000 (UTC) Received: by mail-pl1-f194.google.com with SMTP id t22so693956plr.9 for ; Thu, 05 Nov 2020 04:14:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ef2UKiaY0UPMW9RqmrlSoTPjHgSZ5RMf4W5kfRO/DMA=; b=UcB9WgQUdrPev+x+sdbFmlmQPdbxkywEAlI6FpkjKoRRDsCjeQCbVIe5L6jWzSsy7s V8piICbdYe7nXj24a6wAuohsjGwPrsQdHj0Z7juolpUSf5tm2Z/RVjeQFS+iWoPmIDbZ B5nO1iBMJAYqTQXjZ2Bliieudt3lCFiEe7FFI3vZZCkf2VwPFXMNubg5j7Qd8IFd5Pgi TeAAQMe5UmhHpgtEaWREBWsQG4hYwNJfMgHagOFyu28OlcjbFsAGrsEt9NIMOo4HTSY9 y9KoFD3NbOr3GPT0FemlQchbZLBl8fvOgjFIPm098/N7wT4pFxt4UCoxGMqecQ6gxaIQ Sa+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ef2UKiaY0UPMW9RqmrlSoTPjHgSZ5RMf4W5kfRO/DMA=; b=ZTBmeBbSQPyDoelFTrBerWiLJ4b2mQgGaBN1SXULBozLxRo6f6M5kmtDY+WQYrb8ea SwHTIWD/KOEbLHjwAlwguccEYcvVrXc4vkqbPJvE7wQ4tP3UGE2xVhIBLhq1jLO3B6Vh OB9/Lw2Eh7955iudln7U/uDQJZIv5vXjEvjrPyo1oPl7khJw7mZYaGtsnhKXmf+/SdoX OLY+oAlgwO0632CnJ4A2IUuZbABIeuTpzfCps7WYCmqofcTEeIeqY/AFXeLygXhOsdVi sG1n9KLuLQTex1uDyFfPG500aznaBFNjRL9Aojxf6Adh85iI9wzz+yupIwapYjgV+/KT uodw== X-Gm-Message-State: AOAM531NTOOVgQvg5HQg8Q2xsz1Y8PZwLt4kCnN6r9yTntFCc6eDcF/i iW4Wnfmn+EmeISW1yKGfX6rMcMc8Pa/teKFZUaByxQ== X-Google-Smtp-Source: ABdhPJw8QpPqW7lkuoMpPysT9VHxZsCMlkpgbleXXoFwD4YW2Sti7UeZhKoCgBI0w2vuVeh7y7iTsnwIgMFr1imWxFk= X-Received: by 2002:a17:902:e993:b029:d6:41d8:9ca3 with SMTP id f19-20020a170902e993b02900d641d89ca3mr2100463plb.57.1604578484325; Thu, 05 Nov 2020 04:14:44 -0800 (PST) MIME-Version: 1.0 References: <5e3c76cac4b161fe39e3fc8ace614400bc2fb5b1.1604531793.git.andreyknvl@google.com> <58aae616-f1be-d626-de16-af48cc2512b0@arm.com> <1ef3f645-8b91-cfcf-811e-85123fea90fa@arm.com> In-Reply-To: <1ef3f645-8b91-cfcf-811e-85123fea90fa@arm.com> From: Andrey Konovalov Date: Thu, 5 Nov 2020 13:14:33 +0100 Message-ID: Subject: Re: [PATCH v8 30/43] arm64: kasan: Allow enabling in-kernel MTE To: Vincenzo Frascino Cc: Catalin Marinas , Will Deacon , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 5, 2020 at 12:39 PM Vincenzo Frascino wrote: > > On 11/5/20 11:35 AM, Andrey Konovalov wrote: > > This will work. Any preference on the name of this function? > > > > I called it in my current iteration mte_enable(), and calling it from > cpu_enable_mte(). > > > Alternatively we can rename mte_init_tags() to something else and let > > it handle both RRND and sync/async. > > This is an option but then you need to change the name of kasan_init_tags and > the init_tags indirection name as well. I would go for the simpler and just > splitting the function as per above. > > What do you think? OK, let's split. mte_enable() as a name sounds good to me. Both functions will still be called one right after another from kasan_init_hw_tags (as it's now called) though. I think the name works, as it means initializing the hw_tags mode, not just the tags. Will do in v9.