From: Joonsoo Kim <js1304@gmail.com>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
kasan-dev@googlegroups.com,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH] kasan/quarantine: fix NULL pointer dereference bug
Date: Fri, 1 Jul 2016 22:57:55 +0900 [thread overview]
Message-ID: <CAAmzW4P7+L9F7nx4zJKan6ytJ-55iCSaa7v1KC-h05N6VtmH8Q@mail.gmail.com> (raw)
In-Reply-To: <577625CC.8080907@virtuozzo.com>
2016-07-01 17:11 GMT+09:00 Andrey Ryabinin <aryabinin@virtuozzo.com>:
>
>
> On 07/01/2016 10:53 AM, js1304@gmail.com wrote:
>> From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>>
>> If we move an item on qlist's tail, we need to update qlist's tail
>> properly. curr->next can be NULL since it is singly linked list
>> so it is invalid for tail. curr is scheduled to be moved so
>> using prev would be correct.
>
> Hmm.. prev may be the element that moved in 'to' list. We need to assign the last element
> from which is in ther 'from' list.
You're right. Also, I find another bug on this function.
I manage them on v2 and sent.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-07-01 13:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 7:53 [PATCH] kasan/quarantine: fix NULL pointer dereference bug js1304
2016-07-01 8:11 ` Andrey Ryabinin
2016-07-01 10:55 ` Kuthonuzo Luruo
2016-07-01 11:17 ` Andrey Ryabinin
2016-07-01 13:55 ` [PATCH v2] kasan/quarantine: fix bugs on qlist_move_cache() js1304
2016-07-01 14:03 ` Joonsoo Kim
2016-07-02 8:43 ` kbuild test robot
2016-07-01 13:57 ` Joonsoo Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAmzW4P7+L9F7nx4zJKan6ytJ-55iCSaa7v1KC-h05N6VtmH8Q@mail.gmail.com \
--to=js1304@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).