From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx173.postini.com [74.125.245.173]) by kanga.kvack.org (Postfix) with SMTP id 0F1696B006E for ; Fri, 7 Dec 2012 08:40:10 -0500 (EST) Received: by mail-ob0-f169.google.com with SMTP id v19so44422obq.14 for ; Fri, 07 Dec 2012 05:40:10 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <1354810175-4338-1-git-send-email-js1304@gmail.com> <1354810175-4338-2-git-send-email-js1304@gmail.com> Date: Fri, 7 Dec 2012 22:40:10 +0900 Message-ID: Subject: Re: [RFC PATCH 1/8] mm, vmalloc: change iterating a vmlist to find_vm_area() From: JoonSoo Kim Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Pekka Enberg Cc: Andrew Morton , Russell King , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kexec@lists.infradead.org, Chris Metcalf , Guan Xuetao , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" Hello, Pekka. 2012/12/7 Pekka Enberg : > On Thu, Dec 6, 2012 at 6:09 PM, Joonsoo Kim wrote: >> The purpose of iterating a vmlist is finding vm area with specific >> virtual address. find_vm_area() is provided for this purpose >> and more efficient, because it uses a rbtree. >> So change it. > > You no longer take the 'vmlist_lock'. This is safe, because...? As Bob mentioned, find_vm_area() hold a 'vmap_area_lock' during searching a area. When we hold a 'vmap_area_lock', area can't be removed. So this change is safe. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org