From: "Ryan C. England" <ryan.england@corvidtec.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Christoph Hellwig <hch@infradead.org>,
linux-mm@kvack.org, xfs@oss.sgi.com
Subject: Re: XFS causing stack overflow
Date: Mon, 12 Dec 2011 08:43:57 -0500 [thread overview]
Message-ID: <CAAnfqPC0Ed=PDUOowGTEZyfqHFjB3Jj2YNAaxuYqA2+wVb6tSA@mail.gmail.com> (raw)
In-Reply-To: <20111212090033.GQ14273@dastard>
[-- Attachment #1: Type: text/plain, Size: 2133 bytes --]
Is it possible to apply this patch to my current installation? We use this
box in production and the reboots that we're experiencing are an
inconvenience.
Is there is a walkthrough on how to apply this patch? If not, could your
provide the steps necessary to apply successfully? I would greatly
appreciate it.
Thank you
On Mon, Dec 12, 2011 at 4:00 AM, Dave Chinner <david@fromorbit.com> wrote:
> On Mon, Dec 12, 2011 at 06:13:11AM +0100, Andi Kleen wrote:
> > > It's ~180 bytes, so it's not really that small.
> >
> > Quite small compared to what real code uses. And also fixed
> > size.
> >
> > >
> > > > is on the new stack. ISTs are not used for interrupts, only for
> > > > some special exceptions.
> > >
> > > IST = ???
> >
> > That's a hardware mechanism on x86-64 to switch stacks
> > (Interrupt Stack Table or somesuch)
> >
> > With ISTs it would have been possible to move the the pt_regs too,
> > but the software mechanism is somewhat simpler.
> >
> > > at the top of the stack frame? Is the stack unwinder walking back
> > > across the interrupt stack to the previous task stack?
> >
> > Yes, the unwinder knows about all the extra stacks (interrupt
> > and exception stacks) and crosses them as needed.
> >
> > BTW I suppose it wouldn't be all that hard to add more stacks and
> > switch to them too, similar to what the 32bit do_IRQ does.
> > Perhaps XFS could just allocate its own stack per thread
> > (or maybe only if it detects some specific configuration that
> > is known to need much stack)
>
> That's possible, but rather complex, I think.
> > It would need to be per thread if you could sleep inside them.
>
> Yes, we'd need to sleep, do IO, possibly operate within a
> transaction context, etc, and a workqueue handles all these cases
> without having to do anything special. Splitting the stack at a
> logical point is probably better, such as this patch:
>
> http://oss.sgi.com/archives/xfs/2011-07/msg00443.html
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com
>
--
Ryan C. England
Corvid Technologies <http://www.corvidtec.com/>
office: 704-799-6944 x158
cell: 980-521-2297
[-- Attachment #2: Type: text/html, Size: 3033 bytes --]
next prev parent reply other threads:[~2011-12-12 13:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAAnfqPAm559m-Bv8LkHARm7iBW5Kfs7NmjTFidmg-idhcOq4sQ@mail.gmail.com>
2011-12-09 11:55 ` XFS causing stack overflow Christoph Hellwig
2011-12-09 15:56 ` Ryan C. England
2011-12-09 22:19 ` Dave Chinner
[not found] ` <20111209221956.GE14273__25752.826271537$1323469420$gmane$org@dastard>
2011-12-10 19:52 ` Andi Kleen
2011-12-10 22:13 ` Dave Chinner
2011-12-11 0:00 ` Andi Kleen
2011-12-11 23:05 ` Dave Chinner
2011-12-12 2:31 ` Andi Kleen
2011-12-12 4:36 ` Dave Chinner
2011-12-12 5:13 ` Andi Kleen
2011-12-12 9:00 ` Dave Chinner
2011-12-12 13:43 ` Ryan C. England [this message]
2011-12-12 22:47 ` Dave Chinner
[not found] ` <20111209115513.GA19994__23079.9863501035$1323435203$gmane$org@infradead.org>
2011-12-09 19:53 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAnfqPC0Ed=PDUOowGTEZyfqHFjB3Jj2YNAaxuYqA2+wVb6tSA@mail.gmail.com' \
--to=ryan.england@corvidtec.com \
--cc=andi@firstfloor.org \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-mm@kvack.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).