From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66403EB64DD for ; Thu, 20 Jul 2023 14:15:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF8AE28011B; Thu, 20 Jul 2023 10:15:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA86C28004C; Thu, 20 Jul 2023 10:15:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C976B28011B; Thu, 20 Jul 2023 10:15:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B9D5A28004C for ; Thu, 20 Jul 2023 10:15:19 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7ECA980153 for ; Thu, 20 Jul 2023 14:15:19 +0000 (UTC) X-FDA: 81032187558.13.E39CFB6 Received: from mail-vk1-f174.google.com (mail-vk1-f174.google.com [209.85.221.174]) by imf08.hostedemail.com (Postfix) with ESMTP id 726CE160022 for ; Thu, 20 Jul 2023 14:15:17 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=XF0nOrc2; spf=pass (imf08.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.221.174 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689862517; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MQERya795CGhv2Pz7u9zEer8KNwsTeILm3cP6LQ0mAA=; b=umd1tBAMzJYIIfIL/jaiwLjPs5lMCLMif+2SY7p2bDKB5ptQuxzJpMaQDS38j4uULPjTCZ nkMaXKRzjGeeGItv7yP44/OG1Hd69u1pXtOc6DOVrLVyvZt9aT64j0/vXfS/X8evV/uCD5 hyRUTSgwuvrWzDSHpOQkA6luc4EiNes= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689862517; a=rsa-sha256; cv=none; b=jrjh8m1IdZZmnAE6hqURWiVnJOhHQQFaOvIBPAm4mXwLc2uwNDHXrPMvlnP4cHm10Gbuan rXnw4hy/2xnhEMR7/lpbgf8570nbhCB90i/Mv4OGMNJONwqSEX4kO37i4z975T/aHVmhba y6d53sE+SFr9lePKnbLh9mzcVYCzjGg= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=XF0nOrc2; spf=pass (imf08.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.221.174 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-vk1-f174.google.com with SMTP id 71dfb90a1353d-48133dc9820so294901e0c.3 for ; Thu, 20 Jul 2023 07:15:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689862516; x=1690467316; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=MQERya795CGhv2Pz7u9zEer8KNwsTeILm3cP6LQ0mAA=; b=XF0nOrc2JRgMC5HqpzzW/O+Vhrq7QQFop5Z/sZdQvGVOE+avykqZjwGwVH9UOZ+I+n sq7NDBcfXqy55BIq3BGqvOtIdL0zabi9f6zyXVj7Un8i7+P44XC53jP7DJ2T/ZZQiq08 plItC6x4zDkFhfVb8ES+YUYWc4BKu6sDp8XOfgOmqzbsKy9s7LCeanI/Oz3VsBGagxSY CXK1vN+p9bRSrWIyzXUaaRq6KzSTUQg/6IiYHmgAwNb9ksnhXUk1HlP1AVz9F2l1iJV/ dboiUWYmv/u7Xypc+D3pz8v/hDANW4r0PlwktvMiN0krWAoK69oD3QU0GwDVHjnWymW0 +zIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689862516; x=1690467316; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MQERya795CGhv2Pz7u9zEer8KNwsTeILm3cP6LQ0mAA=; b=Fpgvb+jnYKcmRq/ecG0bfXpHeqQzQFjRWDv+szWCSlNy9VYg42FA1rSTkQg04SFaKB RkUCbvNj7ZccoBUyJm9ixs4mcQiR06KqM2d0F2HSljjbmdz7RnYuKvsJsGyixRoB79T1 sh1m5CEy8hyn9uMXMlGNMf6CWhwnc2SP30xr6pNur3N1Mu2KTXYVgrxRJMPJcbkuQCEk vnOHC27AHloQ+BBcAjXTET6fK9lKOrGt+OLMgKK4EA2WYznH05rre5Lfqfy9IbRx5C83 d33vy54XjFJhKS6OrMJ7VAt+EmwkUWA2hdDU/zhKUNomARlU58Iv4MmbjQlQnI8O+T77 qmpg== X-Gm-Message-State: ABy/qLY76CbGbsSodmxyrlOkMrsiDNI22hQirUhq6W+IpST46acSPJAt Zq4q1g/Zy9ANHtnerx/KixhqP1Bgu9OyGw71sRI= X-Google-Smtp-Source: APBJJlGhIz3jQRcLUTAXK1GegRixCfFrANLszRKfQk2JQmoZyGSE/hQOZXCEJGjpAvqnk+5QJVDXBiJswIAzmFjK9iE= X-Received: by 2002:a1f:5ccb:0:b0:481:4cd1:d61e with SMTP id q194-20020a1f5ccb000000b004814cd1d61emr2577984vkb.13.1689862516145; Thu, 20 Jul 2023 07:15:16 -0700 (PDT) MIME-Version: 1.0 References: <20230628095740.589893-1-jaypatel@linux.ibm.com> <202307172140.3b34825a-oliver.sang@intel.com> In-Reply-To: From: Hyeonggon Yoo <42.hyeyoo@gmail.com> Date: Thu, 20 Jul 2023 23:15:04 +0900 Message-ID: Subject: Re: [PATCH] [RFC PATCH v2]mm/slub: Optimize slub memory usage To: Oliver Sang Cc: Jay Patel , oe-lkp@lists.linux.dev, lkp@intel.com, linux-mm@kvack.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, aneesh.kumar@linux.ibm.com, tsahu@linux.ibm.com, piyushs@linux.ibm.com Content-Type: multipart/mixed; boundary="000000000000fe94e70600ebc60a" X-Rspamd-Queue-Id: 726CE160022 X-Rspam-User: X-Stat-Signature: xxoqk8nuahas79kynj4kxm9kbsni698a X-Rspamd-Server: rspam03 X-HE-Tag: 1689862517-335886 X-HE-Meta: U2FsdGVkX1/mCXNPpONCcz/Mx5Sc+EbkCf5Dgw5DAr0CyNTBKXnLXuyksgpaBWCfjmsCZOJUhXgFEzl0SDndh6ULSWFmbqV+xYLC4iF+FyhZQ45EXT1rYcZOWgz/Ew9s8LKMU2Ql2cnR3jgl6/QZsx5alXfnuQjJgz5c5QclETgn5ASMdw7majPG5/AzIHuVt5FcJyG9RkLgEpCLBuuZE0ocCOHPR0apyzP8hn8h0M+aEMQ602YwkYY74pWt+JO0guGPQ1e0Fn/WRz+UeXswjhAjSVZDViSdcrAg26yQ71yM86IVYlOk7L04kGmSIR0DPK21JN5GGIC6Ir0cKPO1h1sqWkYpyGwbGqFbKSI30WqvTiz2wAxtM5YMH5/eatC45zuVJtUNVHms/0PIfUgeloVTWn3BwNQq7OZf2zC9EY8RhF5b5pMnkvd+RrYMcYIhE8yGyApOtX4LJ+WuQpQx8nz7FbOoM9c7okjgQMl952lv+7A9P45CTMqnIawScL5Lode2259n+bbj1AvEvxqu1y/Iemb/J3QUUtYF5s2NTtqD7Slb2oHDq1UmIWftNlyubnINzbJN56t2YEoAzwgxid0zaXkz6uMHV/5cYsxJ6WQTMiyM50OOjFABxmlnas6GXDnIhvXvn5kcBK1R3M9Vqhpv4Yi6c8tPA5OfxrjU6DeS6UVnlRmq+50gHC2H4UfnjB+4SFxiughzWrXZ+IBaXH+oELDBxGt9tupGon/JiWpOokmonFgxxatcecmpIN3JXSCFT/qrDr10cW52195svrxYRd6+NzbHF1nAhNbJa544Ktk2H79/y7UBmu2I06mkgQIbFD5kOfVmDE4aZO0e+HIxg1eEb1eyXHXBSb+q7WrJzKmPK//FgUVVNCN1gZAeM0rmoZM30y/s3NaFsYqaoMbSHePnvmPeR/jFsnWXj4iMDN6F1Q2tFqt4WtmBNinBeJHt7y9pejwXBgfmqY+ dharMZWx VsSV0HKb+iWmaJB+l335gwDSqS3wvmlDWH4LNqEQKFb3TAGwiPD7qvtTJ36ru9N5uo41AH3ZEADoJBnHk3d06K2mEuSMHhRvoOlciJEI58lmu54t9nrq4G4S4gb744yRsBl/9A33OjInAyjwUgXTQG21L1nVfMhos1iP3wCuWX6bxFMSiEofKVTgyk5LU4D/wdd1q9neuW7/KHkfx7HqgWjpLNemmLG5lQfObwnrFS8KM13RgzdpdrA8mmKHCKqvAyKIUvT7O6eykUIZ/RbGGA7WBkG5lczQBk9VtkjLQ1pRUImGJmWgNLIU7w7XUEet03sw/o+GlB2PkpCA7qvaT5WI8ISuWC7iPiJNmlYoHjnWcBxjZ5FkAawcQzhr15Qk3ddodaPXVls3JiJov4g0xzhcO9b4BmY5BtUQqV8y3EER0YId7ECe2YWVJxJU71kKtF9wsD7HskDhF/7uKloNFTeTRNqGqAVKPWpeRKL2OTOU2mQrKmbe0bdhzmUftcyRLJjBvPDBB66RpQN/CHaQv4F7Jgws+RxZhoS9Ev9ii/OWmnQ5cp1F8vCkKgIMjj3rtGrxp0Rp8VtWi+hPipV2N+XfgBDcfGRJY6EKzNJK2B2VkEk6FGF+Wovp/uJJuR7m+tUHc7Nu34yTI9osa9XGkEDkGBg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --000000000000fe94e70600ebc60a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jul 20, 2023 at 10:46=E2=80=AFPM Hyeonggon Yoo <42.hyeyoo@gmail.com= > wrote: > > On Thu, Jul 20, 2023 at 9:59=E2=80=AFPM Hyeonggon Yoo <42.hyeyoo@gmail.co= m> wrote: > > On Thu, Jul 20, 2023 at 12:01=E2=80=AFPM Oliver Sang wrote: > > > > > commit: > > > > > 7bc162d5cc ("Merge branches 'slab/for-6.5/prandom', 'slab/for-6= .5/slab_no_merge' and 'slab/for-6.5/slab-deprecate' into slab/for-next") > > > > > a0fd217e6d ("mm/slub: Optimize slub memory usage") > > > > > > > > > > 7bc162d5cc4de5c3 a0fd217e6d6fbd23e91f8796787 > > > > > ---------------- --------------------------- > > > > > %stddev %change %stddev > > > > > \ | \ > > > > > 222503 =C4=85 86% +108.7% 464342 =C4=85 58% numa-memi= nfo.node1.Active > > > > > 222459 =C4=85 86% +108.7% 464294 =C4=85 58% numa-memi= nfo.node1.Active(anon) > > > > > 55573 =C4=85 85% +108.0% 115619 =C4=85 58% numa-vmst= at.node1.nr_active_anon > > > > > 55573 =C4=85 85% +108.0% 115618 =C4=85 58% numa-vmst= at.node1.nr_zone_active_anon > > > > > > > > I'm quite baffled while reading this. > > > > How did changing slab order calculation double the number of active= anon pages? > > > > I doubt two experiments were performed on the same settings. > > > > > > let me introduce our test process. > > > > > > we make sure the tests upon commit and its parent have exact same env= ironment > > > except the kernel difference, and we also make sure the config to bui= ld the > > > commit and its parent are identical. > > > > > > we run tests for one commit at least 6 times to make sure the data is= stable. > > > > > > such like for this case, we rebuild the commit and its parent's kerne= l, the > > > config is attached FYI. > > Oh I missed the attachments. > I need more time to look more into that, but could you please test > this patch (attached)? Oh, my mistake. It has nothing to do with reclamation modifiers. The correct patch should be this. Sorry for the noise. --000000000000fe94e70600ebc60a Content-Type: text/x-patch; charset="US-ASCII"; name="0001-mm-slub-do-not-allocate-from-remote-node-to-allocate.patch" Content-Disposition: attachment; filename="0001-mm-slub-do-not-allocate-from-remote-node-to-allocate.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lkb8eg9g0 RnJvbSA3NDE0MmI1MTMxZTczMWY2NjI3NDBkMzQ2MjNkOTNmZDMyNGY5YjY1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIeWVvbmdnb24gWW9vIDw0Mi5oeWV5b29AZ21haWwuY29tPgpE YXRlOiBUaHUsIDIwIEp1bCAyMDIzIDIyOjI5OjE2ICswOTAwClN1YmplY3Q6IFtQQVRDSF0gbW0v c2x1YjogZG8gbm90IGFsbG9jYXRlIGZyb20gcmVtb3RlIG5vZGUgdG8gYWxsb2NhdGUgaGlnaAog b3JkZXIgc2xhYgoKU2lnbmVkLW9mZi1ieTogSHllb25nZ29uIFlvbyA8NDIuaHlleW9vQGdtYWls LmNvbT4KLS0tCiBtbS9zbHViLmMgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24o KyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9tbS9zbHViLmMgYi9tbS9zbHViLmMKaW5k ZXggZjc5NDAwNDgxMzhjLi5jNTg0MjM3ZDZhMGQgMTAwNjQ0Ci0tLSBhL21tL3NsdWIuYworKysg Yi9tbS9zbHViLmMKQEAgLTIwMTAsNyArMjAxMCw3IEBAIHN0YXRpYyBzdHJ1Y3Qgc2xhYiAqYWxs b2NhdGVfc2xhYihzdHJ1Y3Qga21lbV9jYWNoZSAqcywgZ2ZwX3QgZmxhZ3MsIGludCBub2RlKQog CSAqIExldCB0aGUgaW5pdGlhbCBoaWdoZXItb3JkZXIgYWxsb2NhdGlvbiBmYWlsIHVuZGVyIG1l bW9yeSBwcmVzc3VyZQogCSAqIHNvIHdlIGZhbGwtYmFjayB0byB0aGUgbWluaW11bSBvcmRlciBh bGxvY2F0aW9uLgogCSAqLwotCWFsbG9jX2dmcCA9IChmbGFncyB8IF9fR0ZQX05PV0FSTiB8IF9f R0ZQX05PUkVUUlkpICYgfl9fR0ZQX05PRkFJTDsKKwlhbGxvY19nZnAgPSAoZmxhZ3MgfCBfX0dG UF9USElTTk9ERSB8IF9fR0ZQX05PV0FSTiB8IF9fR0ZQX05PUkVUUlkpICYgfl9fR0ZQX05PRkFJ TDsKIAlpZiAoKGFsbG9jX2dmcCAmIF9fR0ZQX0RJUkVDVF9SRUNMQUlNKSAmJiBvb19vcmRlcihv bykgPiBvb19vcmRlcihzLT5taW4pKQogCQlhbGxvY19nZnAgPSAoYWxsb2NfZ2ZwIHwgX19HRlBf Tk9NRU1BTExPQykgJiB+X19HRlBfUkVDTEFJTTsKIAotLSAKMi40MS4wCgo= --000000000000fe94e70600ebc60a--