Re: [PATCH] selftests/damon: fix selftests by installing drgn related script

[Sang-Heon Jeon <ekffu200098@gmail.com>]

Hi SeongJae

On Wed, Aug 13, 2025 at 2:59 AM SeongJae Park <sj@kernel.org> wrote:
>
> On Tue, 12 Aug 2025 23:00:46 +0900 Sang-Heon Jeon <ekffu200098@gmail.com> wrote:
>
> > drgn_dump_damon_status is not installed while kselftest setup.
> > It can breaks other tests which depend on drgn_dump_damon_status.
> > Install drgn_dump_damon_status files to fix broken test.
>
> This patch conflicts with the similar one from Alexandre Ghiti.  Could you
> please rebase yours on top of Alexandre's one (and mention the dependency on
> the comment section under '---' line), unless Andrew resolves the conflict on
> his own?

Oh, I didn't know that I can use the baseline with an unmerged patch.
As your solution, I can avoid conflict (This time Andrew already did
it) Thanks for letting me know. I'll keep that in my mind as well.

> >
> > Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
> > Cc: Alexandre Ghiti <alexghiti@rivosinc.com>
>
> Reviewed-by: SeongJae Park <sj@kernel.org>
>
> > ---
> > While setup kselftest executable environment and test this patch [1],
> > I found similiar issue. Honestly, I don't know exact solution for this
> > situation. So I just make a new patch. Sorry if it is wrong direction,
> > then please let me know how to do next.
> >
> > [1] https://lore.kernel.org/damon/20250812-alex-fixes_manual-v1-1-c4e99b1f80e4@rivosinc.com/
>
> For patches that you are not really confident about and hence not insisting to
> merge as-is, but wanna ask other's opinions first, you can ask questions via
> plain text mails, or post patches with RFC tag on the subject.

My meaning of "don't know exact solution" was about conflict patch
(Now I read again, I think other people might be confused. That's you,
sob) I will use the method mentioned above from now on. Anyway, thanks
for reminding me about RFC.

> I think this is the right patch, though.
>
> You could refer to the TEST_FILES part of documentation[1] and "Install
> selftests" section on the document for more details.

Thank you for this comment too, and for your always kindness.

> [1] https://origin.kernel.org/doc/html/latest/dev-tools/kselftest.html#contributing-new-tests-details
>
>
> Thanks,
> SJ
>
> [...]

Best Regards.
Sang-Heon Jeon