From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58CD0C3DA64 for ; Thu, 1 Aug 2024 18:15:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA52D6B007B; Thu, 1 Aug 2024 14:15:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A2ECD6B0082; Thu, 1 Aug 2024 14:15:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A71C6B0083; Thu, 1 Aug 2024 14:15:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6C1D96B007B for ; Thu, 1 Aug 2024 14:15:42 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D57FD160F67 for ; Thu, 1 Aug 2024 18:15:41 +0000 (UTC) X-FDA: 82404479682.23.2C268CE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id B42341C0030 for ; Thu, 1 Aug 2024 18:15:38 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FRyqCXED; spf=pass (imf20.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722536063; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UaZOROEvjpdbqu1dopLC2Lkrj6Dr9/VPZUA+DhTI8M4=; b=K2kEMR5sPPO2G9IlpbcE2e55+nYxk+H0PDO2abTtAUTjgSKQbAZDCRf1ssmRd0PDm/U7xU UNzMh78EOem6JQmfot97pYBPigrVIgJDioIKdrVWkI1HHJ11n7Xcf8C1wBFHdG3aB86Zo+ OttnzV9mypESck11yBM9ZUXBu/dFPBU= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FRyqCXED; spf=pass (imf20.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722536063; a=rsa-sha256; cv=none; b=6Mkw7Lhs0wyDOzMvCkUicop2XcNVNPxSh4mZ1SBdARKZjkagu3y1bgcmt3o49TOUIV1xef x2VD6kluGqr1OayJsJfp/0fd2PLZ3y0twFobB0ZWwB4Ln0f6L5kOFIcgD6T6ufzsgilsla nHEpr5j9kB2i66ovofLH59vlXmKzmuQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722536138; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UaZOROEvjpdbqu1dopLC2Lkrj6Dr9/VPZUA+DhTI8M4=; b=FRyqCXED3g4TlgEg3hUZE1QCOsfddKzdRZ04Ep79zo/pCyYmE9wTgI7PWu14lEW5pg/UDi ixuZf+6Hr0M620wPFZJU71WV5oF92ZG3aYStlPIgQsGIbsh+fus10adx7npG8K5RCrVgHZ nU2W1I4tZzscMe86gun58HCikRsENAM= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-686-gTXx7Mh-O9mqAsMSRtN4kQ-1; Thu, 01 Aug 2024 14:15:36 -0400 X-MC-Unique: gTXx7Mh-O9mqAsMSRtN4kQ-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-52f0258b020so8068162e87.0 for ; Thu, 01 Aug 2024 11:15:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722536135; x=1723140935; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UaZOROEvjpdbqu1dopLC2Lkrj6Dr9/VPZUA+DhTI8M4=; b=WlP1XcRXgDaYPSvROeJptPYzeAQK2WX/QUCgU0X9AD47dS4O3OITnydiaGJvAKuwRu du0Diq31yf45a4uT45uxKzyWiJwMFaD96Wc/KDf4fhX6aUXUPdrOQLBjtWAg6eRsxRcx GoKDGNqOhaKlJHB6U7jmpfXjszRpFx7qvmr283gXY/Uq2OCeCYcZrf9uzHhUeg6AS8K0 kjfCe+pex47S0lr2xJa25QaZjdHNnVRmgkQApRMQihW5pd9cK2hvXsv7fcxI+kR1w6vB wh4S0XyQ0IwzjWAeSu80vNe8A8WEXpsmPeUQiNTaX/Ovsr/GUF5noMh9vGPNBla1Imx7 fe4Q== X-Forwarded-Encrypted: i=1; AJvYcCV+mjc0xnsM6cMLfDLjk012d19w2gS7ejiZenrJJ5oRDM9KkgOqLKN+m2QIAefIrlH74vxOcUg4QeHPawnRROTE1oM= X-Gm-Message-State: AOJu0Yy9jSjc1zQ12Lqk6eSdj3waZKH2YhOrQHZRs0mMhu//vpp3N7V3 OdwFNxGrmKehOasqQrNVaHIv3YUa//R0ZT/hDVWe2HS95cZqiVtymqKXJuMws5SKbIdXId18hOH s3t26hkiSdr7OeFxAaonpMCxmXDxzKGmmQ1CzZ8uY/P7iCPuvo9r6CGv6qtFAWB3f4jgjFqk/5g Y9EvBNfW7jnBCIDeYqrlTgw4w= X-Received: by 2002:a2e:874b:0:b0:2ef:29b7:18a7 with SMTP id 38308e7fff4ca-2f15ab0c224mr8026871fa.37.1722536134882; Thu, 01 Aug 2024 11:15:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEW/QthBnS2n2JpnEiBTz7UDN3Rn0ZpSHt4zKv0qUnmJfmwCaik8m91bLxVWR1bJoJl2RmwJ89dnkiDtZdyq7c= X-Received: by 2002:a2e:874b:0:b0:2ef:29b7:18a7 with SMTP id 38308e7fff4ca-2f15ab0c224mr8026601fa.37.1722536134319; Thu, 01 Aug 2024 11:15:34 -0700 (PDT) MIME-Version: 1.0 References: <20240501085210.2213060-3-michael.roth@amd.com> <20240801173955.1975034-1-ackerleytng@google.com> In-Reply-To: <20240801173955.1975034-1-ackerleytng@google.com> From: Paolo Bonzini Date: Thu, 1 Aug 2024 20:15:22 +0200 Message-ID: Subject: Re: [PATCH] Fixes: f32fb32820b1 ("KVM: x86: Add hook for determining max NPT mapping level") To: Ackerley Tng Cc: michael.roth@amd.com, ak@linux.intel.com, alpergun@google.com, ardb@kernel.org, ashish.kalra@amd.com, bp@alien8.de, dave.hansen@linux.intel.com, dovmurik@linux.ibm.com, hpa@zytor.com, jarkko@kernel.org, jmattson@google.com, vannapurve@google.com, erdemaktas@google.com, jroedel@suse.de, kirill@shutemov.name, kvm@vger.kernel.org, liam.merwick@oracle.com, linux-coco@lists.linux.dev, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, luto@kernel.org, mingo@redhat.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, peterz@infradead.org, pgonda@google.com, rientjes@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, seanjc@google.com, slp@redhat.com, srinivas.pandruvada@linux.intel.com, tglx@linutronix.de, thomas.lendacky@amd.com, tobin@ibm.com, tony.luck@intel.com, vbabka@suse.cz, vkuznets@redhat.com, x86@kernel.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B42341C0030 X-Stat-Signature: mgt38t3m6uxphakj5kkagx788zoik3ms X-Rspam-User: X-HE-Tag: 1722536138-596467 X-HE-Meta: U2FsdGVkX1/5uM2RWoeGB7BRn0DdcnL907tOc9oGGq0np/OUur3bNbh7FmbsKECRRRVHfTDxueSuDhR/pP44UaLyY/r1wjr3VztZOLmJ4+4PGb3HeC/o7jZF3cYe+EMEyHG6EeCja/C9Gor0qdKC/0Jq8B4QATBihMAclFXYZzOeCUpWKQeu7omLSGd4pHkLd65zmX4Q6Lac9sWacJu2su2ZNh3wTSeI/oZ9hEEPIrHViabKFgcnqEC3yHjPaYV6yXunNOqDHaSm0Jk6Vco28HcrqX7NEWNFFF0aUJ3kZoO/nTEz0ldrjHZP+buCxaP9I/DFYuk2+utSc43+6fkm76UHCjYe686j6nljtDAgzXNDKNOkzg5paI5djVOOxcY1OCL5eAbHkgeUY3UB+8k8BTfBhHzitM/7qpcbbZheqk/+PNehzgKLi+eCYiJziFQkB2cxUCUNQMJ7vUN3VYuau/Zu9iwAlZCL1uzE5yjPNEQnIzeVi3owso7TQQ2QdpOPc7f3y3gem3mZ+LyisX4vkc+1sl7EvbCePqrH+Pp06A68OjzYzPAMY/OyMW1+lWyvTO1xlZfqE47nnO7QBpvlXyrvVcDORHx4ExTPwDDMBqNpgF1Ch/w/+SefbtHbdVQ+sGvFGJYpY+1MUu7DIWWhYbxAf5Zl/7vQlVRIPyBCMA3pjv7EPiJy7MjyOStQ/eYsbbl0/HrMS5jOOR86V5ZezkZnXF2z03OzWx0ioHawUPxK7zJ3qh7uD4skb53QfKEXtUO/fJvqmA0Dw/xc1T/qRYYhsqMNwjm4wnyYsJmMxfLULfrR9M4xteDpxuhbdhVJMNRWnLBSforhZRgQuN+yOXDJffpMWiOMJRHlbbZtVg+o8ekBRpLlHph/L8BStlHtOkLXMcxtUK9GkO1oDPYrtTiWZzACaAe7x+9MSH4LPJCACIFASPuB0FPmOiRg/y47DVnGxDgZ6XYrrG6mnHw G8bu/RPR cD4t5tFG/m4S02mwSpuzdTywq7bv2MnMIENzLoDcgxNNSWDr1wBJIPpKAV7T9focDqTXm0NBxCl6Ufq2BiHm89VhuKcRulYHEjYAXNWi4QkSGOATeK24SnUWV/LM67dVgPSTfexm9OH+Ql5K+yk7zrukPNCZe89kl7cZD60RkVF8p47Y+1spx3P8Uf4XbpbRd6iSDNHuWUD/O5EekaNWlbF06Ldef6MuVQ0bP7Er/+vu2JO6BCrFnkgzQgg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 1, 2024 at 7:40=E2=80=AFPM Ackerley Tng wrote: > > The `if (req_max_level)` test was meant ignore req_max_level if > PG_LEVEL_NONE was returned. Hence, this function should return > max_level instead of the ignored req_max_level. > > Signed-off-by: Ackerley Tng > Change-Id: I403898aacc379ed98ba5caa41c9f1c52f277adc2 It's worth pointing out that this is only a latent issue for now, since guest_memfd does not support large pages ( __kvm_gmem_get_pfn always returns 0). Queued with a small note in the commit message and fixed subject. Thanks, Paolo > --- > arch/x86/kvm/mmu/mmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c > index 901be9e420a4..e6b73774645d 100644 > --- a/arch/x86/kvm/mmu/mmu.c > +++ b/arch/x86/kvm/mmu/mmu.c > @@ -4335,7 +4335,7 @@ static u8 kvm_max_private_mapping_level(struct kvm = *kvm, kvm_pfn_t pfn, > if (req_max_level) > max_level =3D min(max_level, req_max_level); > > - return req_max_level; > + return max_level; > } > > static int kvm_faultin_pfn_private(struct kvm_vcpu *vcpu, > -- > 2.46.0.rc2.264.g509ed76dc8-goog >