From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28B33C433F5 for ; Sat, 28 May 2022 06:42:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A57318D0003; Sat, 28 May 2022 02:42:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A06108D0002; Sat, 28 May 2022 02:42:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F71F8D0003; Sat, 28 May 2022 02:42:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 80BDE8D0002 for ; Sat, 28 May 2022 02:42:05 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5090760E8A for ; Sat, 28 May 2022 06:42:05 +0000 (UTC) X-FDA: 79514207010.02.5DA10F9 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf12.hostedemail.com (Postfix) with ESMTP id 130E340047 for ; Sat, 28 May 2022 06:41:26 +0000 (UTC) Received: by mail-pl1-f175.google.com with SMTP id s14so5925271plk.8 for ; Fri, 27 May 2022 23:42:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+N70na4UCG10OnKjjOThLzzI1rxM+gAtbkkg3YdCT6s=; b=LwDaDXPzb7CGN3gwE2c9GeJQdASfWHR/fzyQa65L3QDMDutcC5/YK8tk1zQ2+oxE9R F7pYwwQv8GRn9JJD9boz2+3KIX8Yp3LYpVe7IWzxNxDLosaOmnMHqWP31E7zHkWNmh0A hi2BID2ha0FPnOtpPcwnlq4IZpDekxO6N4FzrYFACY9bdhIyufsqvgOVJMZBZqRqghWq B2ePZ6HuQGyhujQldPPtwxFsZd5AxtARLWHPrTm/zcVAg+UgkxcQ38rCWsOD/bJgH0kL cFXZeZ/8uGjpdC2R4XrvvuiKyrDscKhdLgcJPr192Q55qNMG5yXyXADxZnC7tbiIAQBy iZrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+N70na4UCG10OnKjjOThLzzI1rxM+gAtbkkg3YdCT6s=; b=YJ1mCdhGOvyeA6ClqYI7Z5Itnn5xh2NaPYmRtKJjvbU02NqzjX6fzWsgtL17uXtrts tMNHOqwcrukm1drWM8J3po0gZlFDVju9QVMmGInsnl6dkF/kUkH+b9EuNeA4neF6rEbI m7d4Dz+Qu6bpdJx2TPE78SaTKw/2zhtJYYMw1jFPrm8WUXw2iuuYL3af0oys/Deba9kh IJrrCgqNQhql4qQRWXTVYvTNXw2kfaiMl7vps+kH6YLHKUo45zc7J5ySrK6tlimfSvXR VXiXEqNI4t0v34URvqpOUTZ6LeIR8ysviSJcBrPf1drgPvbC66zCZ6565glG3oYzPGd5 kHvA== X-Gm-Message-State: AOAM531la6tnhU+yU0OyHXku36ro8MHpyzJB1u1+HY/JkmBOrBRgpMHl xmmZtxgynyF4BEZ+uLobfZj1BXW5hWbIyKZUiFE= X-Google-Smtp-Source: ABdhPJxqD457xsm5Crl8HSkSd5mTK+lAGjDkeMfcvbyje3/+4y4VFdHZdUowYl9MWD2SY2lRNmP3wEnA3sluopmmE6Q= X-Received: by 2002:a17:90a:bb16:b0:1de:fd98:94c5 with SMTP id u22-20020a17090abb1600b001defd9894c5mr12142188pjr.48.1653720123913; Fri, 27 May 2022 23:42:03 -0700 (PDT) MIME-Version: 1.0 References: <20220527104810.24736-1-matenajakub@gmail.com> <20220527104810.24736-2-matenajakub@gmail.com> <20220527233915.55oe6jittuogavot@box.shutemov.name> In-Reply-To: <20220527233915.55oe6jittuogavot@box.shutemov.name> From: =?UTF-8?Q?Jakub_Mat=C4=9Bna?= Date: Sat, 28 May 2022 08:41:52 +0200 Message-ID: Subject: Re: [PATCH 1/2] [PATCH 1/2] mm: refactor of vma_merge() To: "Kirill A. Shutemov" Cc: akpm@linux-foundation.org, linux-mm@kvack.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, Vlastimil Babka , mhocko@kernel.org, mgorman@techsingularity.net, willy@infradead.org, Liam Howlett , Hugh Dickins , riel@surriel.com, rostedt@goodmis.org, peterz@infradead.org Content-Type: multipart/alternative; boundary="0000000000008b399505e00cb83c" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 130E340047 X-Stat-Signature: 4qnsfq6p8xzm5o74oh7xiw1m4inakas9 X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=LwDaDXPz; spf=pass (imf12.hostedemail.com: domain of matenajakub@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=matenajakub@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1653720086-608148 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --0000000000008b399505e00cb83c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, May 28, 2022, 01:37 Kirill A. Shutemov wrote= : > On Fri, May 27, 2022 at 12:48:09PM +0200, Jakub Mat=C4=9Bna wrote: > > Refactor vma_merge() to make it shorter and more understandable. > > Main change is the elimination of code duplicity in the case of > > merge next check. This is done by first doing checks and caching > > the results before executing the merge itself. The variable 'area' is > > divided into 'mid' and 'res' as previously it was used for two purposes= , > > as the middle VMA between prev and next and also as the result of the > > merge itself. Exit paths are also unified. > > > > Signed-off-by: Jakub Mat=C4=9Bna > > You've ignored my ack. Or is there substantial changes that you want me t= o > review again? > I decided to divide the variable 'area' into two variables 'mid' and 'res'. That's the only change since your ack. You suggested renaming so I wasn't sure if that's big enough change or not to still add the ack. Jakub Mat=C4=9Bna > > -- > Kirill A. Shutemov > --0000000000008b399505e00cb83c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Sat, May 28, 2022, 01:37 Kirill A. Shutemov <kirill@shutemov.name> wrote:
On Fri, May 27, 2022 at 12:48:09PM +0= 200, Jakub Mat=C4=9Bna wrote:
> Refactor vma_merge() to make it shorter and more understandable.
> Main change is the elimination of code duplicity in the case of
> merge next check. This is done by first doing checks and caching
> the results before executing the merge itself. The variable 'area&= #39; is
> divided into 'mid' and 'res' as previously it was used= for two purposes,
> as the middle VMA between prev and next and also as the result of the<= br> > merge itself. Exit paths are also unified.
>
> Signed-off-by: Jakub Mat=C4=9Bna <matenajakub@gmail.com><= br>
You've ignored my ack. Or is there substantial changes that you want me= to
review again?

I decided to divide the variable 'area' into two varia= bles 'mid' and 'res'. That's the only change since your= ack. You suggested renaming so I wasn't sure if that's big enough = change or not to still add the ack.

Jakub Mat=C4=9Bna=C2=A0

--
=C2=A0Kirill A. Shutemov=C2=A0
--0000000000008b399505e00cb83c--