From: Akinobu Mita <akinobu.mita@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Per Forlin <per.forlin@linaro.org>,
Jens Axboe <axboe@kernel.dk>,
Christoph Lameter <cl@linux-foundation.org>,
Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
linux-mm@kvack.org
Subject: Re: [PATCH -mmotm] fault-injection: add ability to export fault_attr in arbitrary directory
Date: Wed, 27 Jul 2011 08:34:55 +0900 [thread overview]
Message-ID: <CAC5umyid7cwwPwnQsSWZhv8LUu3+yGhZ3xbctN-_118-21DKPA@mail.gmail.com> (raw)
In-Reply-To: <20110726161714.9b1b5084.akpm@linux-foundation.org>
2011/7/27 Andrew Morton <akpm@linux-foundation.org>:
> On Wed, 27 Jul 2011 08:06:37 +0900
> Akinobu Mita <akinobu.mita@gmail.com> wrote:
>
>> init_fault_attr_dentries() is used to export fault_attr via debugfs. But
>> it can only export it in debugfs root directory.
>>
>> Per Forlin is working on mmc_fail_request which adds support to inject
>> data errors after a completed host transfer in MMC subsystem.
>>
>> The fault_attr for mmc_fail_request should be defined per mmc host and
>> export it in debugfs directory per mmc host like
>> /sys/kernel/debug/mmc0/mmc_fail_request.
>>
>> init_fault_attr_dentries() doesn't help for mmc_fail_request. So this
>> introduces debugfs_create_fault_attr() which is able to create a directory
>> in the arbitrary directory and replace init_fault_attr_dentries().
>
> The name is wrong. "debugfs_create_fault_attr" refers to some function
> exported by the debugfs code. But this function is exported by the
> fault injection code.
>
> I edited the patch and renamed it to fault_create_debugfs_attr, which
> may not make a ton of sense - please let me know if there's something
> more appropriate.
Thanks for spotting the problem and the new function name sounds good.
> I suggest that all symbols exported by this system should start with
> "fault_". ("fault_injection_" would be more appropriate, but it's
> rather lengthy). Please take a look through the code, see if there's
> anything else we should clean up.
OK, I'll check that.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-07-26 23:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-26 23:06 [PATCH -mmotm] fault-injection: add ability to export fault_attr in arbitrary directory Akinobu Mita
2011-07-26 23:17 ` Andrew Morton
2011-07-26 23:34 ` Akinobu Mita [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAC5umyid7cwwPwnQsSWZhv8LUu3+yGhZ3xbctN-_118-21DKPA@mail.gmail.com \
--to=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
--cc=per.forlin@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).