From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta7.messagelabs.com (mail6.bemta7.messagelabs.com [216.82.255.55]) by kanga.kvack.org (Postfix) with ESMTP id 2E0CE6B00EE for ; Tue, 26 Jul 2011 19:34:58 -0400 (EDT) Received: by vws4 with SMTP id 4so1028954vws.14 for ; Tue, 26 Jul 2011 16:34:55 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20110726161714.9b1b5084.akpm@linux-foundation.org> References: <1311721597-2606-1-git-send-email-akinobu.mita@gmail.com> <20110726161714.9b1b5084.akpm@linux-foundation.org> Date: Wed, 27 Jul 2011 08:34:55 +0900 Message-ID: Subject: Re: [PATCH -mmotm] fault-injection: add ability to export fault_attr in arbitrary directory From: Akinobu Mita Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Per Forlin , Jens Axboe , Christoph Lameter , Pekka Enberg , Matt Mackall , linux-mm@kvack.org 2011/7/27 Andrew Morton : > On Wed, 27 Jul 2011 08:06:37 +0900 > Akinobu Mita wrote: > >> init_fault_attr_dentries() is used to export fault_attr via debugfs. =A0= But >> it can only export it in debugfs root directory. >> >> Per Forlin is working on mmc_fail_request which adds support to inject >> data errors after a completed host transfer in MMC subsystem. >> >> The fault_attr for mmc_fail_request should be defined per mmc host and >> export it in debugfs directory per mmc host like >> /sys/kernel/debug/mmc0/mmc_fail_request. >> >> init_fault_attr_dentries() doesn't help for mmc_fail_request. =A0So this >> introduces debugfs_create_fault_attr() which is able to create a directo= ry >> in the arbitrary directory and replace init_fault_attr_dentries(). > > The name is wrong. =A0"debugfs_create_fault_attr" refers to some function > exported by the debugfs code. =A0But this function is exported by the > fault injection code. > > I edited the patch and renamed it to fault_create_debugfs_attr, which > may not make a ton of sense - please let me know if there's something > more appropriate. Thanks for spotting the problem and the new function name sounds good. > I suggest that all symbols exported by this system should start with > "fault_". =A0("fault_injection_" would be more appropriate, but it's > rather lengthy). =A0Please take a look through the code, see if there's > anything else we should clean up. OK, I'll check that. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org