linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: huang ying <huang.ying.caritas@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Dave Hansen <dave.hansen@intel.com>,
	"Huang, Ying" <ying.huang@intel.com>,
	Michal Hocko <mhocko@kernel.org>,
	Minchan Kim <minchan@kernel.org>,
	linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Rik van Riel <riel@redhat.com>, Shaohua Li <shli@kernel.org>,
	Hugh Dickins <hughd@google.com>,
	Fengguang Wu <fengguang.wu@intel.com>,
	Tim Chen <tim.c.chen@intel.com>
Subject: Re: [PATCH] mm, swap: Make VMA based swap readahead configurable
Date: Fri, 6 Oct 2017 20:28:59 +0800	[thread overview]
Message-ID: <CAC=cRTMMHX1SqPygkh+4scmhQhv3=kZMJAFf=EhZZU9S2006JA@mail.gmail.com> (raw)
In-Reply-To: <20171002144903.d58ed6887adfd9dc4cdfd697@linux-foundation.org>

On Tue, Oct 3, 2017 at 5:49 AM, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Mon, 2 Oct 2017 08:45:40 -0700 Dave Hansen <dave.hansen@intel.com> wrote:
>
>> On 09/27/2017 06:02 PM, Huang, Ying wrote:
>> > I still think there may be a performance regression for some users
>> > because of the change of the algorithm and the knobs, and the
>> > performance regression can be resolved via setting the new knob.  But I
>> > don't think there will be a functionality regression.  Do you agree?
>>
>> A performance regression is a regression.  I don't understand why we are
>> splitting hairs as to what kind of regression it is.
>>
>
> Yes.
>
> Ying, please find us a way of avoiding any disruption to existing
> system setups.  One which doesn't require that the operator perform a
> configuration change to restore prior behaviour/performance.

Sorry for late.  I am in holiday recently.

OK.  For me, I think the most clean way is to use page_cluster to
control both the virtual and physical swap readahead.  If you are OK
with that, I will prepare the patch.

> And please let's get this done well in advance of the 4.14 release.

Sure.

Best Regards,
Huang, Ying

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2017-10-06 12:29 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-21  1:33 [PATCH] mm, swap: Make VMA based swap readahead configurable Huang, Ying
2017-09-25  5:41 ` Minchan Kim
2017-09-25  5:54   ` Huang, Ying
2017-09-25  6:17     ` Minchan Kim
2017-09-25  6:24       ` Huang, Ying
2017-09-25  6:30         ` Minchan Kim
2017-09-26 13:21 ` Michal Hocko
2017-09-27  1:36   ` Huang, Ying
2017-09-27  5:04   ` Minchan Kim
2017-09-27  7:48     ` Michal Hocko
2017-09-27  8:04       ` Minchan Kim
2017-09-27  8:35         ` Michal Hocko
2017-09-27 13:15           ` Minchan Kim
2017-09-27 13:22             ` Michal Hocko
2017-09-27 13:41               ` Minchan Kim
2017-09-27 13:50                 ` Michal Hocko
2017-09-27 14:10                   ` Minchan Kim
2017-09-27 14:17                     ` Michal Hocko
2017-09-28  1:02                       ` Huang, Ying
2017-10-02  7:23                         ` Michal Hocko
2017-10-02 15:45                         ` Dave Hansen
2017-10-02 21:49                           ` Andrew Morton
2017-10-06 12:28                             ` huang ying [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAC=cRTMMHX1SqPygkh+4scmhQhv3=kZMJAFf=EhZZU9S2006JA@mail.gmail.com' \
    --to=huang.ying.caritas@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave.hansen@intel.com \
    --cc=fengguang.wu@intel.com \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=minchan@kernel.org \
    --cc=riel@redhat.com \
    --cc=shli@kernel.org \
    --cc=tim.c.chen@intel.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).