From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1CCFC433B4 for ; Thu, 8 Apr 2021 21:45:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6D4DC610A2 for ; Thu, 8 Apr 2021 21:45:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D4DC610A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 00ABA6B0036; Thu, 8 Apr 2021 17:45:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EFDA36B006C; Thu, 8 Apr 2021 17:45:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4F466B006E; Thu, 8 Apr 2021 17:45:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0162.hostedemail.com [216.40.44.162]) by kanga.kvack.org (Postfix) with ESMTP id BB49F6B0036 for ; Thu, 8 Apr 2021 17:45:36 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 699F7824805A for ; Thu, 8 Apr 2021 21:45:36 +0000 (UTC) X-FDA: 78010531872.22.F1F809A Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by imf17.hostedemail.com (Postfix) with ESMTP id 491DA40002DB for ; Thu, 8 Apr 2021 21:45:34 +0000 (UTC) Received: by mail-lf1-f51.google.com with SMTP id j18so6440428lfg.5 for ; Thu, 08 Apr 2021 14:45:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8MVBTVTbGflc/UsLhIwl2nRzF2EsRH8eZ0QlPXqs5ps=; b=Zk2v3nSMdaCm5adH4aHswvLKgEBKklbkCPH2zPgIVKp64w70n2axR/qGDplIQ0OZ0n HLegwMCSSCAxIt8LPsDPeA7J+lV2LnPtLiSNhLWjp/m3yDKXUPRvs0hxnHugTRrpsB6U uiiThswQsEAPRovlktmLYn49OPrRupsH66VDSzbKlxFr/Wn44w766AsgYLN7vrCHZLyR Uur3yAtqGAhF8O/MxSPYa1P5Yxp+6YntEF7We62ytpY0VEX1MNQUtmH/O+iMLbWa2H+y yeUIQCjgCMD2v6FVfHm061JaiZ7pmmjnI2REqJ3G0vMQF8z8vVWj0AbKZlNKPI0hg/VG eF2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8MVBTVTbGflc/UsLhIwl2nRzF2EsRH8eZ0QlPXqs5ps=; b=FRTg9yVB0qv96bPYLAu7iFy8YPv0XpjeOeTtVmFcwqIrUx5f7XsOjhN3Dp9xpA082Z 8c/foyc/HNtXS6P4kFHQFC2vVgdJLmgey7yvA8dyPokWZpADir7xga6nEvdA7IKsH/Iq SYLgwQxDrC3f5ycz3m1KA7dixe+/VmI41gpsZ3GGEFFYmVlQN+zMlYPHVm7oHdoSjls0 qSXECABXpkPwlekz7xFFWiI2vPhcFCdVwDZhx+c1D5LEcJQ5GbHrcolsZ5yNABcX4ciM nxQWgZ8ZcsOScGqCXIVzX5ufVq+pWELEqKg7YC80J92uit6zjnaDEpDTZT/caKP6jVTZ VCYA== X-Gm-Message-State: AOAM531pDBSOHMxi0VORMtBIvkiboUKV1+n6ZWKAVhEfPmxoxnqeSMCG C9wuFhId1XgTKS3XXSB8r+GY7knzrOwwHotA93FFJQ== X-Google-Smtp-Source: ABdhPJwOR1qaBP0hkaYoeDA9UZM861Q2LgMU2bP4wenXDG9wfbiuruw1rThn3wnUQVO3cDtDB82sQHZzPUH6KOtdfMo= X-Received: by 2002:a19:ef18:: with SMTP id n24mr8062945lfh.291.1617918334556; Thu, 08 Apr 2021 14:45:34 -0700 (PDT) MIME-Version: 1.0 References: <20210408092011.52763-1-david@redhat.com> <20210408092011.52763-3-david@redhat.com> <7496ac87-9676-1b4e-3444-c2a662ec376b@redhat.com> <3a2d64a7-8425-8daf-17ee-95b9f0c635f9@redhat.com> <2ef3b65c-c0ef-7bbe-0e05-39ee8f2bae48@redhat.com> In-Reply-To: <2ef3b65c-c0ef-7bbe-0e05-39ee8f2bae48@redhat.com> From: Linus Walleij Date: Thu, 8 Apr 2021 23:45:23 +0200 Message-ID: Subject: Re: [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv To: David Hildenbrand Cc: Arnd Bergmann , Linux Kernel Mailing List , Linux-MM , Joel Stanley , David Airlie , Daniel Vetter , Andrew Jeffery , Lucas Stach , Russell King , Christian Gmeiner , Mike Rapoport , Bartlomiej Zolnierkiewicz , Michal Simek , Masahiro Yamada , Randy Dunlap , Peter Collingbourne , linux-aspeed , dri-devel , Linux ARM , The etnaviv authors , Linux Fbdev development list Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 491DA40002DB X-Stat-Signature: cutd781h14y4sknqdrzfpy3uw5mu1y3f Received-SPF: none (linaro.org>: No applicable sender policy available) receiver=imf17; identity=mailfrom; envelope-from=""; helo=mail-lf1-f51.google.com; client-ip=209.85.167.51 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617918334-915328 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 8, 2021 at 6:44 PM David Hildenbrand wrote: > > drivers/gpu/drm/mcde/Kconfig > > drivers/gpu/drm/pl111/Kconfig > > drivers/gpu/drm/tve200/Kconfig > > I was assuming these are "real" dependencies. Will it also work without > DMA_CMA? It will mostly work but that is only because the reservations are mostly contiguous anyway because they are done early and are small. The hardware requires contiguous buffers in all three cases. I'm not sure I always got it right. > > certainly needs this as well, and pretty much anything that is > > selecting DRM_KMS_CMA_HELPER or > > DRM_GEM_CMA_HELPER "wants" DMA_CMA. > > "wants" as in "desires to use but can life without" or "wants" as in > "really needs it". ? I don't know the exact semantics of using DRM_KMS_CMA* without actually using DMA_CMA. I suspect small allocations will be contiguous and big allocations will start to fragment? but it's just my guess. I guess "really need it"? Yours, Linus Walleij