From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B401EC00144 for ; Mon, 1 Aug 2022 07:26:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F39DC8E0002; Mon, 1 Aug 2022 03:26:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE9F18E0001; Mon, 1 Aug 2022 03:26:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD92E8E0002; Mon, 1 Aug 2022 03:26:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CF51E8E0001 for ; Mon, 1 Aug 2022 03:26:57 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A4222160803 for ; Mon, 1 Aug 2022 07:26:57 +0000 (UTC) X-FDA: 79750192074.17.502D654 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by imf18.hostedemail.com (Postfix) with ESMTP id 4B2841C00F6 for ; Mon, 1 Aug 2022 07:26:57 +0000 (UTC) Received: by mail-lf1-f45.google.com with SMTP id a9so3139220lfm.12 for ; Mon, 01 Aug 2022 00:26:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=eev/ngFXyxaHBPDnw/5aZRQGPAhtDNUSAfnzXB2KgQc=; b=YNAy9BJbwt1YORPKIS9cE3bm2aqaTMQYa6SwdM1sf5HGbELnjcQi6a4sSwxPNBf7YF 3SFbsTBhE8eDuZjr3vEBS7XVmjgjJfc1OGKyT9zj0hwmbfrYZuD34pKOdPzYkOeAkXeZ 1cTkl/TUm2c3N6UA3lR+Z86MzXxFLCdWlyETBQoQmuvVmJniDRRrB3qfZbLN16jyFf6j KgYr6hQHSSTQlTERN0rV2ngJj132bKoT52wYZ/+Wap82i2u91rujrw/LDnWj6UVflj/U yJPIwp8GE1Znq4omcSOjHTWsmWaAfielCrbFhMYhg7m2tsgSV7KaLwOqpOvW4+e3KhaV FDew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=eev/ngFXyxaHBPDnw/5aZRQGPAhtDNUSAfnzXB2KgQc=; b=1U2D7N2lQbiTihmVM+ImERdvBYNBLX/MGxvq6RXmAv6j2ky7KTH74GDxwjhKjB6CPA DenOvn82XnPPZUvAfyqGGU+SFGwuSPEt3RG7HGl3tjGZci8lfRt/iYs+OZSBVRBC2MTJ +Dw5/UiUvzlImViXN7llgyXGOSMGLMrYwdJ3hVqJdXfzFdfHJTiFr069xaEYJErW3rmr eCv4eWK8qL7KyvP57KcOF6MQWjRzGv40cNXj7viKSvWwhoLWbqTBoQDRRyTl246h9xu5 DpuTkufOtqlYhh524CVZfxGkOB1z7fWF/CvdggsZ5RIw6otdbl2D4bMHmX3OCAdOZA2A vmGA== X-Gm-Message-State: ACgBeo0Nt8wWjYL9Ig0yTsuyp6nONuOmmR5bqGlpKNM1xFSWrtxSrx02 FXwiuOEyl31ceQalcWEnkkiyzanW6VSJP2IQ4f4l8g== X-Google-Smtp-Source: AA6agR6drDVlOxYMehd0E7ikvVTVbRFRLUC7kqR9e7cbtU+MWOwQgEjgZSxHVSps8gGe6BY7fpDFDvmKaJfNQePgyOM= X-Received: by 2002:a05:6512:6c8:b0:48a:f375:9ecc with SMTP id u8-20020a05651206c800b0048af3759eccmr1952910lff.206.1659338815344; Mon, 01 Aug 2022 00:26:55 -0700 (PDT) MIME-Version: 1.0 References: <20220727071042.8796-4-feng.tang@intel.com> In-Reply-To: From: Dmitry Vyukov Date: Mon, 1 Aug 2022 09:26:43 +0200 Message-ID: Subject: Re: [mm/slub] 3616799128: BUG_kmalloc-#(Not_tainted):kmalloc_Redzone_overwritten To: Feng Tang Cc: "Sang, Oliver" , Vlastimil Babka , lkp , LKML , "linux-mm@kvack.org" , "lkp@lists.01.org" , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Hansen, Dave" , Robin Murphy , John Garry , Kefeng Wang , Andrey Konovalov , Andrey Ryabinin , Alexander Potapenko , kasan-dev@googlegroups.com Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=YNAy9BJb; spf=pass (imf18.hostedemail.com: domain of dvyukov@google.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=dvyukov@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659338817; a=rsa-sha256; cv=none; b=MBFgIuhHnQbRJkNhAQnzQ44i9Rpf4zQ9SWyIZw47ZxeT1aI050wtb+X61mUqJcDsbJbXkN d1Fl8iEQ33OG5T1KEG2v0mAEuemlcJaMttL4OrSD+pBAyvUWott9wGvHqydzLwr8aBT8Nv MyTa4rFZWz9gLHFgs64HR83ODnyzjRk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659338817; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eev/ngFXyxaHBPDnw/5aZRQGPAhtDNUSAfnzXB2KgQc=; b=XITGMtX+pNVxxPihbhqysPo1PMtwX1Eq83Yog5YjC/JZutmUhEkmWZ4LmaOk0G71Tf9at2 ZB14GR2iI/4Xvf+YboK+OhaYvI0Tq26EWoebIBVIlnDLzFGCx1/YVtmqpoflxs4CPpxCrI 4X5RmgB2u6rVI2TJcf5dNnE57VQ0SKA= X-Rspamd-Queue-Id: 4B2841C00F6 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=YNAy9BJb; spf=pass (imf18.hostedemail.com: domain of dvyukov@google.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=dvyukov@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam01 X-Rspam-User: X-Stat-Signature: x4w3d1hwsib1h6jqqi8hwg511qo7n4tm X-HE-Tag: 1659338817-952993 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 1 Aug 2022 at 08:22, Feng Tang wrote: > > On Sun, Jul 31, 2022 at 04:16:53PM +0800, Tang, Feng wrote: > > Hi Oliver, > > > > On Sun, Jul 31, 2022 at 02:53:17PM +0800, Sang, Oliver wrote: > > > > > > > > > Greeting, > > > > > > FYI, we noticed the following commit (built with gcc-11): > > > > > > commit: 3616799128612e04ed919579e2c7b0dccf6bcb00 ("[PATCH v3 3/3] mm/slub: extend redzone check to cover extra allocated kmalloc space than requested") > > > url: https://github.com/intel-lab-lkp/linux/commits/Feng-Tang/mm-slub-some-debug-enhancements/20220727-151318 > > > base: git://git.kernel.org/cgit/linux/kernel/git/vbabka/slab.git for-next > > > patch link: https://lore.kernel.org/linux-mm/20220727071042.8796-4-feng.tang@intel.com > > > > > > in testcase: boot > > > > > > on test machine: qemu-system-x86_64 -enable-kvm -cpu SandyBridge -smp 2 -m 16G > > > > > > caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace): > > > > > > > > > If you fix the issue, kindly add following tag > > > Reported-by: kernel test robot > > > > > > > > > [ 50.637839][ T154] ============================================================================= > > > [ 50.639937][ T154] BUG kmalloc-16 (Not tainted): kmalloc Redzone overwritten > > > [ 50.641291][ T154] ----------------------------------------------------------------------------- > > > [ 50.641291][ T154] > > > [ 50.643617][ T154] 0xffff88810018464c-0xffff88810018464f @offset=1612. First byte 0x7 instead of 0xcc > > > [ 50.645311][ T154] Allocated in __sdt_alloc+0x258/0x457 age=14287 cpu=0 pid=1 > > > [ 50.646584][ T154] ___slab_alloc+0x52b/0x5b6 > > > [ 50.647411][ T154] __slab_alloc+0x1a/0x22 > > > [ 50.648374][ T154] __kmalloc_node+0x10c/0x1e1 > > > [ 50.649237][ T154] __sdt_alloc+0x258/0x457 > > > [ 50.650060][ T154] build_sched_domains+0xae/0x10e8 > > > [ 50.650981][ T154] sched_init_smp+0x30/0xa5 > > > [ 50.651805][ T154] kernel_init_freeable+0x1c6/0x23b > > > [ 50.652767][ T154] kernel_init+0x14/0x127 > > > [ 50.653594][ T154] ret_from_fork+0x1f/0x30 > > > [ 50.654414][ T154] Slab 0xffffea0004006100 objects=28 used=28 fp=0x0000000000000000 flags=0x1fffc0000000201(locked|slab|node=0|zone=1|lastcpupid=0x3fff) > > > [ 50.656866][ T154] Object 0xffff888100184640 @offset=1600 fp=0xffff888100184520 > > > [ 50.656866][ T154] > > > [ 50.658410][ T154] Redzone ffff888100184630: cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc cc ................ > > > [ 50.660047][ T154] Object ffff888100184640: 00 32 80 00 81 88 ff ff 01 00 00 00 07 00 80 8a .2.............. > > > [ 50.661837][ T154] Redzone ffff888100184650: cc cc cc cc cc cc cc cc ........ > > > [ 50.663454][ T154] Padding ffff8881001846b4: 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a ZZZZZZZZZZZZ > > > [ 50.665225][ T154] CPU: 0 PID: 154 Comm: systemd-udevd Not tainted 5.19.0-rc5-00010-g361679912861 #1 > > > [ 50.666861][ T154] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.0-debian-1.16.0-4 04/01/2014 > > > [ 50.668694][ T154] Call Trace: > > > [ 50.669331][ T154] > > > [ 50.669832][ T154] dump_stack_lvl+0x57/0x7d > > > [ 50.670601][ T154] check_bytes_and_report+0xca/0xfe > > > [ 50.671436][ T154] check_object+0xdc/0x24d > > > [ 50.672163][ T154] free_debug_processing+0x98/0x210 > > > [ 50.673904][ T154] __slab_free+0x46/0x198 > > > [ 50.675746][ T154] qlist_free_all+0xae/0xde > > > [ 50.676552][ T154] kasan_quarantine_reduce+0x10d/0x145 > > > [ 50.677507][ T154] __kasan_slab_alloc+0x1c/0x5a > > > [ 50.678327][ T154] slab_post_alloc_hook+0x5a/0xa2 > > > [ 50.680069][ T154] kmem_cache_alloc+0x102/0x135 > > > [ 50.680938][ T154] getname_flags+0x4b/0x314 > > > [ 50.681781][ T154] do_sys_openat2+0x7a/0x15c > > > [ 50.706848][ T154] Disabling lock debugging due to kernel taint > > > [ 50.707913][ T154] FIX kmalloc-16: Restoring kmalloc Redzone 0xffff88810018464c-0xffff88810018464f=0xcc > > > > Thanks for the report! > > > > From the log it happened when kasan is enabled, and my first guess is > > the data processing from kmalloc redzone handling had some conflict > > with kasan's in allocation path (though I tested some kernel config > > with KASAN enabled) > > > > Will study more about kasan and reproduce/debug this. thanks > > Cc kansan mail list. > > This is really related with KASAN debug, that in free path, some > kmalloc redzone ([orig_size+1, object_size]) area is written by > kasan to save free meta info. > > The callstack is: > > kfree > slab_free > slab_free_freelist_hook > slab_free_hook > __kasan_slab_free > ____kasan_slab_free > kasan_set_free_info > kasan_set_track > > And this issue only happens with "kmalloc-16" slab. Kasan has 2 > tracks: alloc_track and free_track, for x86_64 test platform, most > of the slabs will reserve space for alloc_track, and reuse the > 'object' area for free_track. The kasan free_track is 16 bytes > large, that it will occupy the whole 'kmalloc-16's object area, > so when kmalloc-redzone is enabled by this patch, the 'overwritten' > error is triggered. > > But it won't hurt other kmalloc slabs, as kasan's free meta won't > conflict with kmalloc-redzone which stay in the latter part of > kmalloc area. > > So the solution I can think of is: > * skip the kmalloc-redzone for kmalloc-16 only, or > * skip kmalloc-redzone if kasan is enabled, or > * let kasan reserve the free meta (16 bytes) outside of object > just like for alloc meta /\/\/\ Please just not the last option. Memory consumption matters. I would do whatever is the simplest, e.g. skip the check for kmalloc-16 when KASAN is enabled. Or does it make sense to prohibit KASAN+SLUB_DEBUG combination? Does SLUB_DEBUG add anything on top of KASAN? > I don't have way to test kasan's SW/HW tag configuration, which > is only enabled on arm64 now. And I don't know if there will > also be some conflict. > > Thanks, > Feng >