From: Dmitry Vyukov <dvyukov@google.com>
To: Paul Lawrence <paullawrence@google.com>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>,
Alexander Potapenko <glider@google.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <mmarek@suse.com>,
LKML <linux-kernel@vger.kernel.org>,
kasan-dev <kasan-dev@googlegroups.com>,
Linux-MM <linux-mm@kvack.org>,
"open list:KERNEL BUILD + fi..." <linux-kbuild@vger.kernel.org>,
Matthias Kaehlcke <mka@chromium.org>,
Michael Davidson <md@google.com>,
Greg Hackmann <ghackmann@google.com>
Subject: Re: [PATCH v2 4/5] kasan: support LLVM-style asan parameters
Date: Thu, 30 Nov 2017 09:33:23 +0100 [thread overview]
Message-ID: <CACT4Y+ZNZNej2w0R0s7wR+Msgyng-SR3Tyfg59fZ74PKY0buFg@mail.gmail.com> (raw)
In-Reply-To: <20171129215050.158653-5-paullawrence@google.com>
On Wed, Nov 29, 2017 at 10:50 PM, 'Paul Lawrence' via kasan-dev
<kasan-dev@googlegroups.com> wrote:
> Use cc-option to figure out whether the compiler's sanitizer uses
> LLVM-style parameters ("-mllvm -asan-foo=bar") or GCC-style parameters
> ("--param asan-foo=bar").
>
> Signed-off-by: Greg Hackmann <ghackmann@google.com>
> Signed-off-by: Paul Lawrence <paullawrence@google.com>
>
> ---
> scripts/Makefile.kasan | 39 +++++++++++++++++++++++++++------------
> 1 file changed, 27 insertions(+), 12 deletions(-)
>
> diff --git a/scripts/Makefile.kasan b/scripts/Makefile.kasan
> index 1ce7115aa499..89c5b166adec 100644
> --- a/scripts/Makefile.kasan
> +++ b/scripts/Makefile.kasan
> @@ -10,24 +10,39 @@ KASAN_SHADOW_OFFSET ?= $(CONFIG_KASAN_SHADOW_OFFSET)
>
> CFLAGS_KASAN_MINIMAL := -fsanitize=kernel-address
>
> -CFLAGS_KASAN := $(call cc-option, -fsanitize=kernel-address \
> - -fasan-shadow-offset=$(KASAN_SHADOW_OFFSET) \
> - --param asan-stack=1 --param asan-globals=1 \
> - --param asan-instrumentation-with-call-threshold=$(call_threshold))
> -
> ifeq ($(call cc-option, $(CFLAGS_KASAN_MINIMAL) -Werror),)
> ifneq ($(CONFIG_COMPILE_TEST),y)
> $(warning Cannot use CONFIG_KASAN: \
> -fsanitize=kernel-address is not supported by compiler)
> endif
> else
> - ifeq ($(CFLAGS_KASAN),)
> - ifneq ($(CONFIG_COMPILE_TEST),y)
> - $(warning CONFIG_KASAN: compiler does not support all options.\
> - Trying minimal configuration)
> - endif
> - CFLAGS_KASAN := $(CFLAGS_KASAN_MINIMAL)
> - endif
> + # -fasan-shadow-offset fails without -fsanitize
> + CFLAGS_KASAN_SHADOW := \
> + $(call cc-option, -fsanitize=kernel-address \
> + -fasan-shadow-offset=$(KASAN_SHADOW_OFFSET))
> + ifeq ($(CFLAGS_KASAN_SHADOW),)
> + CFLAGS_KASAN := $(CFLAGS_KASAN_MINIMAL)
> + else
> + CFLAGS_KASAN := $(CFLAGS_KASAN_SHADOW)
> + endif
> +
> + # Now add all the compiler specific options that are valid standalone
> + CFLAGS_KASAN := $(CFLAGS_KASAN) \
> + $(call cc-option, --param asan-globals=1) \
> + $(call cc-option, --param asan-instrument-allocas=1) \
> + $(call cc-option, --param asan-instrumentation-with-call-threshold=$(call_threshold)) \
> + $(call cc-option, -mllvm -asan-mapping-offset=$(KASAN_SHADOW_OFFSET)) \
> + $(call cc-option, -mllvm -asan-stack=1) \
> + $(call cc-option, -mllvm -asan-globals=1) \
> + $(call cc-option, -mllvm -asan-use-after-scope=1) \
> + $(call cc-option, -mllvm -asan-instrumentation-with-call-threshold=$(call_threshold))
> +
> +
> + # This option crashes on gcc 4.9, and is not available on clang
> + ifeq ($(call cc-ifversion, -ge, 0500, y), y)
> + CFLAGS_KASAN := $(CFLAGS_KASAN) $(call cc-option, --param asan-stack=1)
> + endif
> +
> endif
>
> CFLAGS_KASAN += $(call cc-option, -fsanitize-address-use-after-scope)
Acked-by: Dmitry Vyukov <dvyukov@google.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-11-30 8:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 21:50 [PATCH v2 0/5] kasan: support alloca, LLVM Paul Lawrence
2017-11-29 21:50 ` [PATCH v2 1/5] kasan: support alloca() poisoning Paul Lawrence
2017-11-30 8:26 ` Dmitry Vyukov
2017-11-30 8:29 ` Dmitry Vyukov
2017-11-29 21:50 ` [PATCH v2 2/5] kasan: Add tests for alloca poisonong Paul Lawrence
2017-11-30 8:30 ` Dmitry Vyukov
2017-11-29 21:50 ` [PATCH v2 3/5] kasan: added functions for unpoisoning stack variables Paul Lawrence
2017-11-30 8:31 ` Dmitry Vyukov
2017-11-29 21:50 ` [PATCH v2 4/5] kasan: support LLVM-style asan parameters Paul Lawrence
2017-11-30 8:33 ` Dmitry Vyukov [this message]
2017-11-30 16:36 ` Andrey Ryabinin
2017-11-29 21:50 ` [PATCH v2 5/5] kasan: add compiler support for clang Paul Lawrence
2017-11-30 8:34 ` Dmitry Vyukov
2017-11-30 16:45 ` Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACT4Y+ZNZNej2w0R0s7wR+Msgyng-SR3Tyfg59fZ74PKY0buFg@mail.gmail.com \
--to=dvyukov@google.com \
--cc=aryabinin@virtuozzo.com \
--cc=ghackmann@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=md@google.com \
--cc=mka@chromium.org \
--cc=mmarek@suse.com \
--cc=paullawrence@google.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).