From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f69.google.com (mail-pl0-f69.google.com [209.85.160.69]) by kanga.kvack.org (Postfix) with ESMTP id 4DC306B000C for ; Mon, 19 Mar 2018 04:44:10 -0400 (EDT) Received: by mail-pl0-f69.google.com with SMTP id w19-v6so8038432plq.2 for ; Mon, 19 Mar 2018 01:44:10 -0700 (PDT) Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id x13-v6sor3959499pln.55.2018.03.19.01.44.09 for (Google Transport Security); Mon, 19 Mar 2018 01:44:09 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: From: Dmitry Vyukov Date: Mon, 19 Mar 2018 09:43:48 +0100 Message-ID: Subject: Re: [PATCH v2 0/7] KASan for arm Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-mm@kvack.org List-ID: To: "Liuwenliang (Abbott Liu)" Cc: Florian Fainelli , "linux@armlinux.org.uk" , "aryabinin@virtuozzo.com" , "marc.zyngier@arm.com" , "kstewart@linuxfoundation.org" , "gregkh@linuxfoundation.org" , "akpm@linux-foundation.org" , "afzal.mohd.ma@gmail.com" , "alexander.levin@verizon.com" , "glider@google.com" , "christoffer.dall@linaro.org" , "linux@rasmusvillemoes.dk" , "mawilcox@microsoft.com" , "pombredanne@nexb.com" , "ard.biesheuvel@linaro.org" , "vladimir.murzin@arm.com" , "nicolas.pitre@linaro.org" , "tglx@linutronix.de" , "thgarnie@google.com" , "dhowells@redhat.com" , "keescook@chromium.org" , "arnd@arndb.de" , "geert@linux-m68k.org" , "tixy@linaro.org" , "mark.rutland@arm.com" , "james.morse@arm.com" , "zhichao.huang@linaro.org" , "jinb.park7@gmail.com" , "labbott@redhat.com" , "philip@cog.systems" , "grygorii.strashko@linaro.org" , "catalin.marinas@arm.com" , "opendmb@gmail.com" , "kirill.shutemov@linux.intel.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "kasan-dev@googlegroups.com" , "kvmarm@lists.cs.columbia.edu" , "linux-mm@kvack.org" On Mon, Mar 19, 2018 at 2:56 AM, Liuwenliang (Abbott Liu) wrote: > On 03/19/2018 09:23 AM, Florian Fainelli wrote: >>On 03/18/2018 06:20 PM, Liuwenliang (Abbott Liu) wrote: >>> On 03/19/2018 03:14 AM, Florian Fainelli wrote: >>>> Thanks for posting these patches! Just FWIW, you cannot quite add >>>> someone's Tested-by for a patch series that was just resubmitted given >>>> the differences with v1. I just gave it a spin on a Cortex-A5 (no LPAE) >>>> and it looks like test_kasan.ko is passing, great job! >>> >>> I'm sorry. >>> Thanks for your testing very much! >>> I forget to add Tested-by in cover letter patch file. But I have alreadly added >>> Tested-by in some of following patch. >>> In the next version I am going to add Tested-by in all patches. >> >>This is not exactly what I meant. When you submit a v2 of your patches, >>you must wait for people to give you their test results. The Tested-by >>applied to v1, and so much has changed it is no longer valid for v2 >>unless someone tells you they tested v2. Hope this is clearer. > > Ok, I understand now. thank you for your explanation. Hi Abbott, I've skimmed through the changes and they generally look good to me. I am not an expect in arm, so I did not look too closely on these parts (which is actually most of the changes). FWIW Acked-by: Dmitry Vyukov Please also update set of supported archs at the top of Documentation/dev-tools/kasan.rst Thanks for working on upstreaming this!