linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Zheng Zhang <zheng.zhang@email.ucr.edu>
To: Kees Cook <keescook@chromium.org>
Cc: Sean Christopherson <seanjc@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	 Zheng Zhang <zheng.zhang@email.ucr.edu>,
	linux-hardening@vger.kernel.org,  linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	 Matthew Wilcox <willy@infradead.org>
Subject: Re: [BUG]: bad usercopy in kvm_stats_read in mm/usercopy.c
Date: Tue, 11 Jul 2023 12:08:15 -0700	[thread overview]
Message-ID: <CAC_GQSphJRCep+i8vV2Ec589WhQFGRMdcwF_wedYWxG44HzkPQ@mail.gmail.com> (raw)
In-Reply-To: <202307110925.CBAF286C0A@keescook>

[-- Attachment #1: Type: text/plain, Size: 1293 bytes --]

Thanks for confirming!

On Tue, Jul 11, 2023 at 9:26 AM Kees Cook <keescook@chromium.org> wrote:

> On Tue, Jul 11, 2023 at 09:15:00AM -0700, Sean Christopherson wrote:
> > On Mon, Jul 10, 2023, Andrew Morton wrote:
> > > On Sun, 9 Jul 2023 14:32:09 -0700 Zheng Zhang <
> zheng.zhang@email.ucr.edu> wrote:
> > >
> > > > Kees, Andrew, and  to whom it may concern:
> > > >
> > > > Hello! We have found a bug in the Linux kernel version 6.2.0 by
> syzkaller
> > > > with our own templates. It also produces a POC.
> > > > Attached is the report, log, and reproducers generated by syzkaller
> > > > Please let me know if there is any additional information that I can
> > > > provide to help debug this issue.
> > > > Thanks!
> > >
> > > Let's cc the kvm mailing list.
> > >
> > > Original email is at
> > >
> https://lkml.kernel.org/r/CAC_GQSr3xzZaeZt85k_RCBd5kfiOve8qXo7a81Cq53LuVQ5r=Q@mail.gmail.com
> >
> > Yeaaaah.  We failed kernel programming 101.  KVM installs file
> descriptors to
> > let userspace read VM and vCPU stats, but doesn't grab a reference to
> the VM to
> > ensure the VM and its vCPUs are kept alive until the stats fds are
> closed.  I'll
> > send a patch.
>
> Thanks! Another victory for hardened usercopy. :)
>
> --
> Kees Cook
>

[-- Attachment #2: Type: text/html, Size: 1967 bytes --]

      reply	other threads:[~2023-07-11 19:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-09 21:32 [BUG]: bad usercopy in kvm_stats_read in mm/usercopy.c Zheng Zhang
2023-07-10 20:34 ` Andrew Morton
2023-07-11 16:15   ` Sean Christopherson
2023-07-11 16:26     ` Kees Cook
2023-07-11 19:08       ` Zheng Zhang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAC_GQSphJRCep+i8vV2Ec589WhQFGRMdcwF_wedYWxG44HzkPQ@mail.gmail.com \
    --to=zheng.zhang@email.ucr.edu \
    --cc=akpm@linux-foundation.org \
    --cc=keescook@chromium.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=seanjc@google.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).