From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E045C5B552 for ; Tue, 10 Jun 2025 11:12:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 714306B007B; Tue, 10 Jun 2025 07:12:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EBC26B0089; Tue, 10 Jun 2025 07:12:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 601D86B008A; Tue, 10 Jun 2025 07:12:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 416A56B007B for ; Tue, 10 Jun 2025 07:12:15 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8DC8CC1A80 for ; Tue, 10 Jun 2025 11:12:13 +0000 (UTC) X-FDA: 83539226946.18.FA15B94 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by imf24.hostedemail.com (Postfix) with ESMTP id 978F0180007 for ; Tue, 10 Jun 2025 11:12:11 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=z6BImITC; spf=pass (imf24.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.128.174 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749553931; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LAasWsF+eqCK/f8XAQ+UlekFNlTdm6esn8JjFvKIvek=; b=xddcPpaKK5LHClp22Sedldd0eODTpOreSJii9uwYIgvGUxTJY+9n7UCJbe01vsdJI18MHK 9/OrN5fCbUZwct7ps6WQ40wmPOHuKAo3LmPRSIhgwvlE6bTOEykMZ6+5V5dhiekgDYc9U0 OeBf/DNMFAd9KtpxqJ0SYQITi8OUgVQ= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=z6BImITC; spf=pass (imf24.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.128.174 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749553931; a=rsa-sha256; cv=none; b=aiaXiEWJ09U3p6W7TWIawDpXGbdaKOqNvKeJO1I/aD1tKOKksbTZ8iqiQzf9w75iXjk2tx 3Jg8eyoUxTp9BgWm8oKP5a1zIiF7IRLOgUmxBI1G9V9TXMy+VYrK4jqqz/tHGTBtVQOmgp fkqtmCdkW8my78+/BN1ozYsQrO50tbw= Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-70a57a8ffc3so51758087b3.0 for ; Tue, 10 Jun 2025 04:12:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749553930; x=1750158730; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LAasWsF+eqCK/f8XAQ+UlekFNlTdm6esn8JjFvKIvek=; b=z6BImITCqr0x5s/suna9ELyke56Ac6odqgKdw/AjZOGLj4BhpvM5qoaaMggRuG8muV RTapoFhuXeLxk5BGfB8ycqYMvjaRVHLnAlAL0S0hr/XtBcWdWoSZ2uhFdLW6Zpvko+Eg 4ZgzeDn7MjXif0Nwt5aDO9Lk31lCDlbXJMe0n4pqajZs2YamHgpjXnm9MBFa0Xr0I0Rc KYWdYyWJwoa/RZik/K3alJ6jdklQswu3GfRC+idc+IALKVRaB7A6WleFWy11KdN0z8Sc msnpXy2GHPDPIfffTVaA1HTJcmfhOBwgmR/0OekqzvFNyaP/hqPOo8EeRFUEMFum2DEC 7sKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749553930; x=1750158730; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LAasWsF+eqCK/f8XAQ+UlekFNlTdm6esn8JjFvKIvek=; b=bRh5UiFr4FFjBuSwPFXIYTvv03gAoHnyHYsPAPDsPHVZbIGA5unTbXnKuEO390vKyF V3CGKY8lAZX1Afr6VeBjhzZwZnY6wZ8kSqprmxoyLY4R0MheWhedDv9kIEms9N3dbUBU EHTpL1CLNh0BOT4eScrfuaj5MAyibjk9UyihXAcT1E03drH7pWS+y7RLvKjZeKlUhXmw 0AFJRsk9qdDOz8MF4DgnumoTp5vBvb3KHigsHzNmOWi2uN8UQYUWHNs6UzEx25j7OaDB bVKs/lgH2PiBpRx7mPePJJlS/qzD0G7aEEehD8BG7qOXlbQB6d9hl0JV/+/Wj7REDNFg 3CwQ== X-Forwarded-Encrypted: i=1; AJvYcCUjrK857Kd9Qz6+PKwgxJhTk6s9BxhedHK7swxWYtjLxgXE4OHhh3P+grJTjONgvCA+huLHY9pNRw==@kvack.org X-Gm-Message-State: AOJu0Yy8k3vCJroM5Rmn0ULQPgSuL41lSoCXyyAYC5+tzAGTEBYCHRF4 BJZhOgT2BWDnl3Rz8wTmXk5eepbXIDTMxM0CRCMseQQYJwT5mvifubfI4RFsAEYAV6YSA+esXb5 83Pmi3QUiQ+1U70RTe1uI6XlMpDMYSTGgaEL9WipfMA== X-Gm-Gg: ASbGncvqV9MNJOM15+HPE5DqoMHobUqUX6xdYCDLc6gIWNJ8Agfrxbh6j07WWpZ7lEf jiMBtwYXBeCFySvdyfhoZOuXBePKIHQtqwrj3z1Kae33ONYVF6F2WxE9dYhgJk/3NMYTgqzRdKV 9Uu0J3PXVsuYswi5jolhpH3ERAnEVNFnlO0SoFuNpYXVBZ X-Google-Smtp-Source: AGHT+IEus4fAgfpA04VnzbpCBIk4pcLfZh1F4oLtFfc4L//yX8/NM2y06/TIMi8ieJhHRR9+7Ovs9MDTFh1COb9mV8I= X-Received: by 2002:a05:690c:700e:b0:702:52fb:4649 with SMTP id 00721157ae682-710f770f580mr243841697b3.27.1749553930576; Tue, 10 Jun 2025 04:12:10 -0700 (PDT) MIME-Version: 1.0 References: <20250609043225.77229-1-byungchul@sk.com> <20250609043225.77229-7-byungchul@sk.com> In-Reply-To: <20250609043225.77229-7-byungchul@sk.com> From: Ilias Apalodimas Date: Tue, 10 Jun 2025 14:11:34 +0300 X-Gm-Features: AX0GCFuhc6OdkS5KHRqDnMJaP6aChThQllVzaiTd7yB-canYZ7c373Kcyan1HIw Message-ID: Subject: Re: [PATCH net-next 6/9] netmem: remove __netmem_get_pp() To: Byungchul Park Cc: willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, asml.silence@gmail.com, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 978F0180007 X-Rspamd-Server: rspam09 X-Stat-Signature: 5y863fgrfzajexw8dfqnp845gaps1uny X-HE-Tag: 1749553931-597983 X-HE-Meta: U2FsdGVkX1+GP9ibACEoW7UBKXSw4645oI17B8+r77o+/HkbDU8O8IpsrxOkO6WhyHusFKgPltQwukB5HP8G3ZbMhAEyE/+Fbvp+NVzhTEZQausueWG/O5gsRxCKZJ9RSCVB2bsI4VYeYPQjrOp7wF/Ps3cFiMzBzhi0iWW1D5IJywN/rNCPzO14C8sJhZJ+CyHHmB1leArH0paCcyRpbNIqoGnUvcpJqTw++UXseI0hINywbICo/ImfX44Ob8Pecq3razeR9hL1grNnf7fnYT+L67K/vyUfKCIfZ3IrJ6fFbChg8cMKXmHbFXaYaem859nQO+6PVsrnkcBISR7Ry/+AbytbrNUWExBgNCWLuEeOjN1zbTdsdk7V+nGIARx4Rwz86re8l2edJdLoKdzNAU8RpRSL9QcqQPUO0t1yX/IosXFBrp1tJJc5Q8s6L0T+OIOp/h2kaxAIgIWCjquY4HdETalsFuo+s4ffw6sYQHrRo9Wb9HGd/9EKxZJ3LftqJ3fw3ZuWcrQqvYHM5n4+0wgEUCv7Rf86nIIYny0hgVGTjMWPfBEaXbSRD2WiSBwvW982Vyy7FDjIDRSvd66LyukMbPIBFsHDKdtME0lR8OrFwp6oSgyKXC7yI8NIkC+vdPn3pxzsyEs2BWNuPGVJtKZxaIiwRhuNGig9XWMTIg0SLqt0/LW/Xs4Jv3JOUnBeLRUkZY0gQkVhhU8GwtXVlK76REnr03FEsumfs+mzgBliY/z/qgOFnrGrLbSjloQrIzN8d5rjbXeFma8UncWniZFiyQgp/tFrVx3chl4loJ7Gn0j3Ft2yBai4F4M1rp0M4iubhQRg+RfH0Q85devZtPvhJxZKsu+HEMw5aJjmGFoOQ4E06NHBZWW2hZgvgShM2QUtKlR7aIUq1+raXKh4y4Ei78LiwzXWquGDqtPycI4vH4A7vdusz+zQcZtVq0JWrS7dQNGIu7ljBX4GIbW tXdIsRip mtmcW6LXil5y6/3v96M8TmfUpMhQqzbcSiIcATXq6odeNc6rDYcvBrFCcJxBZC6yJbneMMr+EhjfhhK6ZUGuE+n/I29EyUdh++hmlbHC7iLITZwNub3ZktL2FW7ig3yZlP9v6WX+Kn8TdNimgsRDsn8WmSxTmN3dBCylpRMkHeblpE1oZJew9h2n5eTX0VQ7hWyv4SoZhIQGCTe4RHvkBoW33DxJo5L3kz6m2sjH0Hgh99J6cueQB/epWdpZmLlcWLYqqRvotOHBOpzmF9za+Czq0OvD8EAcPyVXSnuzIzzXDreQYuObLBBE4rbF9Nq3ZSBDbLveozTtbhsE1aNsmDJ+OLa9xYRPgiwEoGcNW1QienCHm0gp0PW0PzCfpG6RuvOB0fi9mlTIzEag2FmcIe1UVpd1GDJzNR7Ct1K2pUfKtqnD9buc2Zc330A4Q0PYFssxb7GiqvDGxdMmA9zHPN6dCVp0SFdDUmjg+lylUqIP4S3ypL54bFsvzoxFjIRFgbux+td2pQvu4qCoGq0+7TdAyHaPqzI4+JvZ+bxriRUdWnW8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 9 Jun 2025 at 07:32, Byungchul Park wrote: > > There are no users of __netmem_get_pp(). Remove it. > > Signed-off-by: Byungchul Park > Reviewed-by: Mina Almasry > Reviewed-by: Toke H=C3=B8iland-J=C3=B8rgensen > Reviewed-by: Pavel Begunkov > --- Reviewed-by: Ilias Apalodimas > include/net/netmem.h | 16 ---------------- > 1 file changed, 16 deletions(-) > > diff --git a/include/net/netmem.h b/include/net/netmem.h > index 65bb87835664..d4066fcb1fee 100644 > --- a/include/net/netmem.h > +++ b/include/net/netmem.h > @@ -234,22 +234,6 @@ static inline struct net_iov *__netmem_clear_lsb(net= mem_ref netmem) > return (struct net_iov *)((__force unsigned long)netmem & ~NET_IO= V); > } > > -/** > - * __netmem_get_pp - unsafely get pointer to the &page_pool backing @net= mem > - * @netmem: netmem reference to get the pointer from > - * > - * Unsafe version of netmem_get_pp(). When @netmem is always page-backed= , > - * e.g. when it's a header buffer, performs faster and generates smaller > - * object code (avoids clearing the LSB). When @netmem points to IOV, > - * provokes invalid memory access. > - * > - * Return: pointer to the &page_pool (garbage if @netmem is not page-bac= ked). > - */ > -static inline struct page_pool *__netmem_get_pp(netmem_ref netmem) > -{ > - return __netmem_to_page(netmem)->pp; > -} > - > static inline struct page_pool *netmem_get_pp(netmem_ref netmem) > { > return __netmem_clear_lsb(netmem)->pp; > -- > 2.17.1 >