Re: [PATCH 3/9] mm, swap: rename and move some swap cluster definition and helpers

[Chris Li <chrisl@kernel.org>]

On Tue, Sep 2, 2025 at 3:21 AM David Hildenbrand <david@redhat.com> wrote:
>
> On 22.08.25 21:20, Kairui Song wrote:
> > From: Kairui Song <kasong@tencent.com>
> >
> > No feature change, move cluster related definitions and helpers to
> > mm/swap.h, also tidy up and add a "swap_" prefix for cluster lock/unlock
> > helpers, so they can be used outside of swap files.
> >
> > Signed-off-by: Kairui Song <kasong@tencent.com>
> > ---
>
> [...]
>
> >
> > -#ifdef CONFIG_THP_SWAP
> > -#define SWAPFILE_CLUSTER     HPAGE_PMD_NR
> > -
> > -#define swap_entry_order(order)      (order)
> > -#else
> > -#define SWAPFILE_CLUSTER     256
> > -
> > -/*
> > - * Define swap_entry_order() as constant to let compiler to optimize
> > - * out some code if !CONFIG_THP_SWAP
> > - */
> > -#define swap_entry_order(order)      0
> > -#endif
> > -#define LATENCY_LIMIT                256
> > +#define LATENCY_LIMIT 256
>
> No need to touch that line IMHO.
>
>
> I enjoy the new function names.

I enjoy that naming convention too, wink wink.

Chris