From: Chris Li <chrisl@kernel.org>
To: Barry Song <21cnbao@gmail.com>
Cc: aaron.lu@intel.com, akpm@linux-foundation.org, bhe@redhat.com,
kasong@tencent.com, linux-mm@kvack.org, nphamcs@gmail.com,
shikemeng@huaweicloud.com, youngjun.park@lge.com
Subject: Re: [PATCH v4 mm-new 1/2] mm/swap: do not choose swap device according to numa node
Date: Wed, 15 Oct 2025 06:27:56 -0700 [thread overview]
Message-ID: <CACePvbVtt3+-_uW8H1Qk_17sRWMRrdTAoX8EiE=GfpwYkUPJ+Q@mail.gmail.com> (raw)
In-Reply-To: <20251015080925.4008-1-21cnbao@gmail.com>
On Wed, Oct 15, 2025 at 1:09 AM Barry Song <21cnbao@gmail.com> wrote:
> >
> > Optane was not even supported in Skylake. Commit a2468cc9bfdf has
> > nothing to do with Optane. The Op]tane talk in a2468cc9bfdf is just a
> > red herring. I fail to see why reverting a2468cc9bfdf needs to mention
> > Optane is obsolete.
>
> Thanks for the clarification. The Optane discussion turned out to be a goof :-)
>
> Just for the record, this paper [1] also mentions that accessing remote SSDs
> can significantly decrease performance. However, it is rare to find any NUMA
Ack. I am not saying NUMA is aware SSD does not matter. I am sure it
does. The question is does the benefit in real world usage cases
justify the extra complexity.
> machine using SSDs directly as swap files without a RAM compression frontend,
> so I don’t think the performance penalty of remote access would be a problem
> when choosing a direct swapfile.
The per NUMA aware SSD swap setup is so hard to come by, very few
users are actually benefiting from it in real life. You need to have
each NUMA node a SSD attached to that node. Also each SSD on the node
needs to set up the swap partition, preferably the same size. If you
have only one SSD setup the swap partition, it does not matter if it
is local or remote, that is the only SSD swap can write to anyway.
Both Android and data center usage I am aware of do not satisfy this
per NUMA node swapfile requirement. If anyone has a counterexample, I
would like to hear about it. My conguesture is that this setup is so
rare, it does not justify the complexity it adds to the swap core.
Especially considering it has conflict with the swap.tiers down the
road.
Agree that nowadays the zswap or zram is the more common swap usage
case by far, the SSD swap is just an overflow secondary swap. The
local vs remote SSD speed difference there matters much less.
Chris
next prev parent reply other threads:[~2025-10-15 13:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-11 8:16 [PATCH v4 mm-new 0/2] mm/swapfile.c: select the swap device with default priority round robin Baoquan He
2025-10-11 8:16 ` [PATCH v4 mm-new 1/2] mm/swap: do not choose swap device according to numa node Baoquan He
2025-10-11 20:45 ` kernel test robot
2025-10-11 22:04 ` Andrew Morton
2025-10-12 2:08 ` Baoquan He
2025-10-14 11:56 ` Baoquan He
2025-10-13 6:09 ` Barry Song
2025-10-14 21:50 ` Chris Li
2025-10-15 3:06 ` Baoquan He
2025-10-15 5:02 ` Barry Song
2025-10-15 6:23 ` Chris Li
2025-10-15 8:09 ` Barry Song
2025-10-15 13:27 ` Chris Li [this message]
2025-10-11 8:16 ` [PATCH v4 mm-new 2/2] mm/swap: select swap device with default priority round robin Baoquan He
2025-10-12 20:40 ` Barry Song
2025-10-13 3:58 ` Baoquan He
2025-10-13 6:17 ` Barry Song
2025-10-13 23:07 ` Baoquan He
2025-10-14 22:11 ` Chris Li
2025-10-15 4:29 ` Barry Song
2025-10-15 6:24 ` Chris Li
2025-10-14 22:01 ` Chris Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACePvbVtt3+-_uW8H1Qk_17sRWMRrdTAoX8EiE=GfpwYkUPJ+Q@mail.gmail.com' \
--to=chrisl@kernel.org \
--cc=21cnbao@gmail.com \
--cc=aaron.lu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=kasong@tencent.com \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=shikemeng@huaweicloud.com \
--cc=youngjun.park@lge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).