linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Jiaqi Yan <jiaqiyan@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kirill.shutemov@linux.intel.com, kirill@shutemov.name,
	 tongtiangen@huawei.com, tony.luck@intel.com,
	naoya.horiguchi@nec.com,  linmiaohe@huawei.com,
	linux-mm@kvack.org, Oscar Salvador <osalvador@suse.de>,
	 Yang Shi <shy828301@gmail.com>
Subject: Re: [PATCH v6 0/2] Memory poison recovery in khugepaged collapsing
Date: Wed, 16 Nov 2022 09:58:23 -0800	[thread overview]
Message-ID: <CACw3F512ta=zvgeLkHahBuvdhO-93656Sr-xQP3bc4-APXRDUw@mail.gmail.com> (raw)
In-Reply-To: <20221107125315.b2916c557ff35d3b74aee503@linux-foundation.org>

Thanks for ccing Oscar, Andrew.

After getting this patch into our internal production environment, I
recently found a regression bug introduced by my commit a0157a2c735b
("mm/khugepaged: recover from poisoned file-backed memory").
Given it is only in mm-unstable, I wonder should I put out a v7 with
the fix, or should I make it a new and separate commit?
Sorry for the bug.


On Mon, Nov 7, 2022 at 12:53 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Sun,  6 Nov 2022 18:53:57 -0800 Jiaqi Yan <jiaqiyan@google.com> wrote:
>
> > Memory DIMMs are subject to multi-bit flips, i.e. memory errors.
> > As memory size and density increase, the chances of and number of
> > memory errors increase. The increasing size and density of server
> > RAM in the data center and cloud have shown increased uncorrectable
> > memory errors. There are already mechanisms in the kernel to recover
> > from uncorrectable memory errors. This series of patches provides
> > the recovery mechanism for the particular kernel agent khugepaged
> > when it collapses memory pages.
>
> Thanks, I'll toss v6 into mm-unstable for some testing, pending further review.
>
> When resending a patchset, please try to also cc the people who have
> commented on previous versions.
>


  reply	other threads:[~2022-11-16 17:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-07  2:53 [PATCH v6 0/2] Memory poison recovery in khugepaged collapsing Jiaqi Yan
2022-11-07  2:53 ` [PATCH v6 1/2] mm/khugepaged: recover from poisoned anonymous memory Jiaqi Yan
2022-11-07  2:53 ` [PATCH v6 2/2] mm/khugepaged: recover from poisoned file-backed memory Jiaqi Yan
2022-11-07 20:53 ` [PATCH v6 0/2] Memory poison recovery in khugepaged collapsing Andrew Morton
2022-11-16 17:58   ` Jiaqi Yan [this message]
2022-11-16 21:52     ` Andrew Morton
2022-11-18  1:34       ` Jiaqi Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACw3F512ta=zvgeLkHahBuvdhO-93656Sr-xQP3bc4-APXRDUw@mail.gmail.com' \
    --to=jiaqiyan@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=kirill@shutemov.name \
    --cc=linmiaohe@huawei.com \
    --cc=linux-mm@kvack.org \
    --cc=naoya.horiguchi@nec.com \
    --cc=osalvador@suse.de \
    --cc=shy828301@gmail.com \
    --cc=tongtiangen@huawei.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).