From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6703DC433FE for ; Wed, 16 Nov 2022 17:58:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA3156B0073; Wed, 16 Nov 2022 12:58:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A2B736B0074; Wed, 16 Nov 2022 12:58:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CC3B8E0001; Wed, 16 Nov 2022 12:58:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7AF2D6B0073 for ; Wed, 16 Nov 2022 12:58:36 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 31005140399 for ; Wed, 16 Nov 2022 17:58:36 +0000 (UTC) X-FDA: 80140065432.26.02D8A85 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf15.hostedemail.com (Postfix) with ESMTP id 86E9EA0011 for ; Wed, 16 Nov 2022 17:58:35 +0000 (UTC) Received: by mail-pf1-f174.google.com with SMTP id y203so18212369pfb.4 for ; Wed, 16 Nov 2022 09:58:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3EErQqWhFRpGh+J+sESu0YvNbQw/vA5Rskns9BnSu9o=; b=mIsgnvgkDWxyQb3qB6acRQGdGXRLyBZfVAbBvWq7H+m68dAVV57tjt9RyjPPky8f84 eEmXKTmnhU7NfoTAegpx7z90RAUMMirXZQP3e7vGLgMoOh+j9+GlHNp32UOfb6e5bvSZ RC9ZnZ7pi/akWAm6874AWcuOuozv0EPx9UmsH+o7J21G7+kHsrf9boxysAHfM0dxSKMj bWeO9cyRPl4Dhzk3F1/t7n5aL4d9hDOJdEZdQahW3VPJQ4q80nqveIK+bfXzNSxS3pcY 9ghj40ykgab7axgEvjrVPCIL6btADHKrDIl0smiksAVfgaBplmq+z+akeV+18VQuhLd5 P/gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3EErQqWhFRpGh+J+sESu0YvNbQw/vA5Rskns9BnSu9o=; b=JlchScak9I45muY75Bmql4GnhEZ5HKHSoBbtBAh7DcBwnSFBg16oh+0oOmw8+5j38P +HBGDCN/b6/AvIBy5Zsm6ucNLfbAaXWs1R6OR1gfmxqsPNpOlogLDkXvimtFj7ushf6z kT3w6kKiagEd/V4UOAlIxXaf5HpBiOVc2Bldl4frvjSdXk871hDaiVu1jL2TqoFHSk2S vOXkpQeqCQWKnuZI8Wa7pf8GC4osFRD3GjuySPTKykPUWwM8ipsC72Utxr30gPbfApHZ AFRfVkQFjq8oiG19NlFBtwqNV3YmZ23T343wA3pMeSTxM2oiDMA+D2Cs8mJAXz0nM+kw tBvA== X-Gm-Message-State: ANoB5pl/IxT3H2uHdW84fXuB5q4drjB1yjcsW5BbQLbRRN+G1VTPgVii ifX1sxJplFHFwguO/47OE0udvi2xNNpMVzFm4pQysw== X-Google-Smtp-Source: AA0mqf5NNywHpfytqGKtPJShHd8CWNnWWJ46bdcGdzZVTchA+GDGHpkHi4ns8vEUQP+4kCoGnX6noaQkDFDfv/9OSpI= X-Received: by 2002:a63:1348:0:b0:46e:96b9:ed63 with SMTP id 8-20020a631348000000b0046e96b9ed63mr21866528pgt.258.1668621514154; Wed, 16 Nov 2022 09:58:34 -0800 (PST) MIME-Version: 1.0 References: <20221107025359.2911028-1-jiaqiyan@google.com> <20221107125315.b2916c557ff35d3b74aee503@linux-foundation.org> In-Reply-To: <20221107125315.b2916c557ff35d3b74aee503@linux-foundation.org> From: Jiaqi Yan Date: Wed, 16 Nov 2022 09:58:23 -0800 Message-ID: Subject: Re: [PATCH v6 0/2] Memory poison recovery in khugepaged collapsing To: Andrew Morton Cc: kirill.shutemov@linux.intel.com, kirill@shutemov.name, tongtiangen@huawei.com, tony.luck@intel.com, naoya.horiguchi@nec.com, linmiaohe@huawei.com, linux-mm@kvack.org, Oscar Salvador , Yang Shi Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668621515; a=rsa-sha256; cv=none; b=wtTi0H06Y+arN+/JM6DZURVZ4/EWvYxgPXb1OsGuzHkvTOE4v/E7j4JNYElWeTnI0C6+Vr Zr51/QOhB2XtS/pXdK68y015fkEJKwsMS2iPDB3TpHk8PvrAJGHKFzJ3WCLETYpuTrntGF BPvHBmP8i1jGxYufaGFvjCQeFZ0l+KI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=mIsgnvgk; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of jiaqiyan@google.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=jiaqiyan@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668621515; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3EErQqWhFRpGh+J+sESu0YvNbQw/vA5Rskns9BnSu9o=; b=3ck603GrPCUzbruV6vR2xwO7xqtpURw4eDmyAIvc7Jh+Z++w+rs9GpCS6Yyqy4FFxaAq0Q 6rcvAX4xwEU/WUO+8ueL1VyT8npowEinxTG6Fa5VaQ7dbumFzy8xzSLofz1OwWiWyapfRV dDxiQXjK5NdoQUGmdREy6ayr36zpqlg= X-Stat-Signature: uf7kfkeqq7dikfjm6q8zi3k3i7ekrhn4 X-Rspamd-Queue-Id: 86E9EA0011 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=mIsgnvgk; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of jiaqiyan@google.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=jiaqiyan@google.com X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1668621515-793179 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thanks for ccing Oscar, Andrew. After getting this patch into our internal production environment, I recently found a regression bug introduced by my commit a0157a2c735b ("mm/khugepaged: recover from poisoned file-backed memory"). Given it is only in mm-unstable, I wonder should I put out a v7 with the fix, or should I make it a new and separate commit? Sorry for the bug. On Mon, Nov 7, 2022 at 12:53 PM Andrew Morton wrote: > > On Sun, 6 Nov 2022 18:53:57 -0800 Jiaqi Yan wrote: > > > Memory DIMMs are subject to multi-bit flips, i.e. memory errors. > > As memory size and density increase, the chances of and number of > > memory errors increase. The increasing size and density of server > > RAM in the data center and cloud have shown increased uncorrectable > > memory errors. There are already mechanisms in the kernel to recover > > from uncorrectable memory errors. This series of patches provides > > the recovery mechanism for the particular kernel agent khugepaged > > when it collapses memory pages. > > Thanks, I'll toss v6 into mm-unstable for some testing, pending further review. > > When resending a patchset, please try to also cc the people who have > commented on previous versions. >